New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run3-hcx277 Make the other shower library producer to work for HF #32568
Conversation
-code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-32568/20540
Code check has found code style and quality issues which could be resolved by applying following patch(s)
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-32568/20541
|
A new Pull Request was created by @bsunanda (Sunanda Banerjee) for master. It involves the following packages: Geometry/HcalCommonData @civanch, @Dr15Jones, @makortel, @cvuosalo, @ianna, @mdhildreth, @cmsbuild can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
-code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-32568/20542
Code check has found code style and quality issues which could be resolved by applying following patch(s)
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-32568/20543
|
<PartSelector path="//HFFibre.*"/> | ||
<Parameter name="SensitiveDetector" value="FiberSensitiveDetector" eval="false"/> | ||
<Parameter name="ReadOutName" value="FibreHits" eval="false"/> | ||
<Parameter name="rTable" value="12.50*cm"/> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't you want the numeric parameters to have eval="true"
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SpecParSection has eval="true" which is valid for all parts of spectra except some parameters which are string and has eval="false"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, thanks.
New XML files should be put into |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-32568/20548 |
Pull request #32568 was updated. @civanch, @Dr15Jones, @makortel, @cvuosalo, @ianna, @mdhildreth, @cmsbuild can you please check and sign again. |
@cmsbuild Please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6d42f6/11834/summary.html Comparison SummarySummary:
|
+1 |
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
Make the other shower library producer using a standalone geometry setup (as done in HF TestBeam) to work for HF
PR validation:
Use the test workflows in SimG4CMS/ShowerLibraryProducer/test/python
if this PR is a backport please specify the original PR and why you need to backport that PR:
Nothing special