L1 Phase2 for HLT TDR - Multy Primary Vtx, TkMuons Fix for low-pt #32571
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rekovic
changed the title
|
please test |
|
-code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-32571/20552
Code check has found code style and quality issues which could be resolved by applying following patch(s)
|
|
interesting ... and
don't give any changes. |
rekovic
force-pushed
the
pr113x-phase2-MultPrimVtx-TkMuonsFix
branch
from
c2d230b
to
1eafbf7
Compare
cmsbuild
added
code-checks-pending
tests-pending
and removed
code-checks-rejected
tests-started
labels
|
please test |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-32571/20560
|
|
A new Pull Request was created by @rekovic for master. It involves the following packages: DataFormats/L1TCorrelator @rekovic, @kpedro88, @jmduarte can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
+1 |
|
-1 Failed Tests: RelVals AddOn RelValsAddOn Tests |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-32571/20806
|
|
please test |
|
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c1be85/12379/summary.html Comparison SummarySummary:
|
|
+1 |
|
@rekovic can I suggest renaming the PR to "L1T Phase 2 update for HLT TDR: multiple primary vtx, fix for low pT tk muons" ? |
silviodonato
changed the title
kpedro88
reviewed
Jan 20, 2021
| @@ -468,11 +490,26 @@ void L1TkMuonProducer::runOnMTFCollection_v1(const edm::Handle<RegionalMuonCandB | |||
|
|
|||
| TkMuon l1tkmu(l1tkp4, l1muRef, l1tkPtr, trkisol); | |||
|
|
|||
| if (useRegionEtaMatching_) { | |||
There was a problem hiding this comment.
this exact pattern appears twice in the PR: it could be made into a function like
bool inRegionEta(const TkMuon& l1tkmu, int detector) {
return ((detector == barrel_MTF_region and std::abs(l1tkmu.eta()) <= etaBO_) or
(detector == overlap_MTF_region and (std::abs(l1tkmu.eta()) >= etaBO_ and std::abs(l1tkmu.eta()) <= etaOE_)) or
(detector == endcap_MTF_region and std::abs(l1tkmu.eta()) >= etaOE_));
}then here and below would just be:
if (useRegionEtaMatching_ and !inRegionEta(l1tkmu, detector))
continue;| @@ -635,6 +677,12 @@ std::vector<L1TkMuMantraDF::muon_df> L1TkMuonProducer::product_to_muvec(const EM | |||
| std::vector<L1TkMuMantraDF::muon_df> result(l1mus.size()); | |||
| for (uint imu = 0; imu < l1mus.size(); ++imu) { | |||
| auto& mu = l1mus[imu]; | |||
|
|
|||
| // dropping the emtf tracks with certain quality... | |||
| int emtfQual = (mu.Mode() == 11 || mu.Mode() == 13 || mu.Mode() == 14 || mu.Mode() == 15); | |||
There was a problem hiding this comment.
do these quality values have particular meanings? (useful to explain such meanings in a comment, or use named constants if appropriate)
| float trkisol = -999; | ||
| TkMuon l1tkmu(l1tkp4, l1emtfTrk, l1tkPtr, trkisol); | ||
| l1tkmu.setTrackCurvature(matchTk.rInv()); | ||
| l1tkmu.setTrkzVtx((float)tkv3.z()); |
There was a problem hiding this comment.
is the extra float cast necessary? (c-style casts should be avoided in general, code rule 4.15 http://cms-sw.github.io/cms_coding_rules.html)
|
+upgrade |
cmsbuild
added
fully-signed
upgrade-approved
and removed
pending-signatures
upgrade-pending
labels
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
|
+1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description:
LT Phase2 for HLT TDR, featuring:
PR validation:
Done with the integration branch phase2-l1t-integration-CMSSW_11_1_3.
if this PR is a backport please specify the original PR and why you need to backport that PR:
Before submitting your pull requests, make sure you followed this checklist: