Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug fix for coral MessageService wrapper #32575

Merged
merged 1 commit into from Jan 11, 2021

Conversation

ggovi
Copy link
Contributor

@ggovi ggovi commented Dec 22, 2020

PR description:

Back-port of #32503:

Addressing #31896

The fixes involve a wrapper for the Coral message Reporter:

  • complying with expected pointer ownership in coral
  • ensuring better hand-shake while de-scoping objects

PR validation:

Unit test, integration test ( with BeamSpot workflow )

if this PR is a backport please specify the original PR and why you need to backport that PR:

Back-port of #32503. Needed to avoid memory corruption issues. Involved in MWGR operations.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @ggovi for CMSSW_11_2_X.

It involves the following packages:

CondCore/CondDB
CondCore/DBOutputService

@yuanchao, @christopheralanwest, @cmsbuild, @tlampen, @ggovi, @pohsun can you please review it and eventually sign? Thanks.
@mmusich, @tocheng this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@christopheralanwest
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e340cd/11853/summary.html
CMSSW: CMSSW_11_2_X_2020-12-23-1100/slc7_amd64_gcc900

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 35
  • DQMHistoTests: Total histograms compared: 2529619
  • DQMHistoTests: Total failures: 6
  • DQMHistoTests: Total nulls: 1
  • DQMHistoTests: Total successes: 2529590
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -0.004 KiB( 34 files compared)
  • DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
  • Checked 148 log files, 37 edm output root files, 35 DQM output files

@silviodonato
Copy link
Contributor

Kind reminder @cms-sw/alca-l2 @cms-sw/db-l2

@tlampen
Copy link
Contributor

tlampen commented Jan 11, 2021

+1

@ggovi
Copy link
Contributor Author

ggovi commented Jan 11, 2021

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_11_2_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_11_3_X is complete. This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@silviodonato
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 9050199 into cms-sw:CMSSW_11_2_X Jan 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants