Rename local variables according to the coding rules #32591
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
please test |
fwyzard
added a commit
to fwyzard/cmssw
that referenced
this pull request
Dec 30, 2020
Address the pixel local reconstruction review comments:
- rename local variables according to the coding rules and for
consistency with cms-sw#32591.
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-32591/20611
|
|
A new Pull Request was created by @fwyzard (Andrea Bocci) for master. It involves the following packages: CondFormats/SiPixelTransient @ggovi, @perrotta, @jpata, @slava77 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
fwyzard
added a commit
to cms-patatrack/cmssw
that referenced
this pull request
Dec 30, 2020
Address the pixel local reconstruction review comments:
- remove obsolete comments;
- consistently use named constants;
- rename data members and methods to be more descriptive;
- rename local variables according to the coding rules and for
consistency with cms-sw#32591;
- update transient dictionaries to match data types.
cmsbuild
added
code-checks-pending
tests-pending
and removed
code-checks-approved
tests-started
labels
|
please test |
|
-code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-32591/20614
Code check has found code style and quality issues which could be resolved by applying following patch(s)
|
|
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-95aad2/11904/summary.html The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
You can see more details here: Comparison Summary@slava77 comparisons for the following workflows were not done due to missing matrix map:
Summary:
|
fwyzard
added a commit
to fwyzard/cmssw
that referenced
this pull request
Dec 30, 2020
Address the pixel local reconstruction review comments:
- rename data members and methods to be more descriptive;
- rename local variables according to the coding rules and for
consistency with cms-sw#32591.
fwyzard
added a commit
to cms-patatrack/cmssw
that referenced
this pull request
Dec 30, 2020
Address the pixel local reconstruction review comments:
- remove obsolete comments;
- consistently use named constants;
- rename data members and methods to be more descriptive;
- rename local variables according to the coding rules and for
consistency with cms-sw#32591;
- update transient dictionaries to match data types.
fwyzard
added a commit
to cms-patatrack/cmssw
that referenced
this pull request
Dec 30, 2020
Address the pixel local reconstruction review comments:
- remove obsolete comments;
- consistently use named constants;
- rename data members and methods to be more descriptive;
- rename local variables according to the coding rules and for
consistency with cms-sw#32591;
- update transient dictionaries to match data types.
fwyzard
added a commit
to cms-patatrack/cmssw
that referenced
this pull request
Dec 30, 2020
Address the pixel local reconstruction review comments:
- remove obsolete comments;
- consistently use named constants;
- rename data members and methods to be more descriptive;
- rename local variables according to the coding rules and for
consistency with cms-sw#32591;
- update transient dictionaries to match data types.
fwyzard
added a commit
to cms-patatrack/cmssw
that referenced
this pull request
Dec 30, 2020
Address the pixel local reconstruction review comments:
- remove obsolete comments;
- consistently use named constants;
- rename data members and methods to be more descriptive;
- rename local variables according to the coding rules and for
consistency with cms-sw#32591;
- update transient dictionaries to match data types.
|
+1
|
|
@cms-sw/db-l2 |
fwyzard
added a commit
to cms-patatrack/cmssw
that referenced
this pull request
Jan 13, 2021
Address the pixel local reconstruction review comments:
- remove obsolete comments;
- consistently use named constants;
- rename data members and methods to be more descriptive;
- rename local variables according to the coding rules and for
consistency with cms-sw#32591;
- update transient dictionaries to match data types.
|
+1 |
cmsbuild
added
db-approved
fully-signed
and removed
db-pending
pending-signatures
labels
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
|
+1 |
fwyzard
added a commit
to cms-patatrack/cmssw
that referenced
this pull request
Jan 15, 2021
Address the pixel local reconstruction review comments:
- remove obsolete comments;
- consistently use named constants;
- rename data members and methods to be more descriptive;
- rename local variables according to the coding rules and for
consistency with cms-sw#32591;
- update transient dictionaries to match data types.
fwyzard
added a commit
to cms-patatrack/cmssw
that referenced
this pull request
Mar 23, 2021
Address the pixel local reconstruction review comments:
- remove obsolete comments;
- consistently use named constants;
- rename data members and methods to be more descriptive;
- rename local variables according to the coding rules and for
consistency with cms-sw#32591;
- update transient dictionaries to match data types.
fwyzard
added a commit
to cms-patatrack/cmssw
that referenced
this pull request
Apr 1, 2021
Address the pixel local reconstruction review comments:
- remove obsolete comments;
- consistently use named constants;
- rename data members and methods to be more descriptive;
- rename local variables according to the coding rules and for
consistency with cms-sw#32591;
- update transient dictionaries to match data types.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description:
Rename local variables in
SiPixelUtilsandPixelCPEGenericaccording to the coding rules.PR validation:
None.