Add PixelBaryCentreAnalyzer in Alignment offline validation tool #32601

tocheng · 2021-01-05T06:25:23Z

PR description:

PixelBaryCentreAnalyzer is an ED Analyzer that reads global tracker position from GlobalTag and tracker alignment constants from different ESsources, calculates and stores barycentres of different pixel detector substructure in ROOT TTrees, one for each ESsource.

The One module is used because the analyzer is expected to read (empty event) data in orders of lumi section/run number. (Concurrent lumi section processing is not very needed here).

Plotting script is added to compare barycentres from Prompt Reco, End-of-Year Rereco and so-called Run-2 (Ultra)Legacy Rereco.

PR validation:

Plotting script is used as a validation of the output (Ntuple) from the analyzer

if this PR is a backport please specify the original PR and why you need to backport that PR:

The PR is not a backport.

cmsbuild · 2021-01-05T06:33:33Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-32601/20638

This PR adds an extra 28KB to repository

cmsbuild · 2021-01-05T06:33:57Z

A new Pull Request was created by @tocheng (Tongguang) for master.

It involves the following packages:

Alignment/OfflineValidation

@cmsbuild, @pohsun, @yuanchao, @christopheralanwest, @tlampen can you please review it and eventually sign? Thanks.
@mschrode, @mmusich, @adewit, @tocheng, @tlampen this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

tocheng · 2021-01-05T06:43:36Z

@cmsbuild please test

tocheng · 2021-01-05T06:45:28Z

@connorpa @vbotta This is something you want to watch and comment. Thanks.

smuzaffar · 2021-01-05T09:04:47Z

please test

cmsbuild · 2021-01-05T11:39:18Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a64171/11962/summary.html
CMSSW: CMSSW_11_3_X_2021-01-04-2300/slc7_amd64_gcc900

Comparison Summary

Summary:

No significant changes to the logs found
Reco comparison results: 7 differences found in the comparisons
DQMHistoTests: Total files compared: 37
DQMHistoTests: Total histograms compared: 2716967
DQMHistoTests: Total failures: 12
DQMHistoTests: Total nulls: 1
DQMHistoTests: Total successes: 2716932
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.004 KiB( 36 files compared)
DQMHistoSizes: changed ( 312.0 ): 0.004 KiB MessageLogger/Warnings
Checked 156 log files, 37 edm output root files, 37 DQM output files

vbotta · 2021-01-05T12:03:09Z

Hi @tocheng,
thanks. After looking at the code, I have the following comments:

Could you add to the produced tree the barycentre of the two FPIX endcaps separately? As far as I can see, this is not stored right now, but will be useful in the future.
It would be nice to make the plotting script a little more general, so that it can be used also for other comparisons in the future. Some concrete suggestions:
- pass the pixel templates tag and the input ROOT file name as arguments
- add a check on the existence of the input file
- make the plotting configurable (number of curves, names, colours, labels), e.g. with a .json you pass as input.
Could you add the python cfg to run the analyzer as well?

mmusich · 2021-01-05T12:31:19Z

Alignment/OfflineValidation/plugins/PixelBaryCentreAnalyzer.h

@@ -0,0 +1,117 @@
+#ifndef Alignment_OfflineValidation_PixelBaryCentreAnalyzer_H


cmssw plugins should not have header files, but be fully contained in the .cc file.

mmusich · 2021-01-05T12:31:59Z

Alignment/OfflineValidation/plugins/PixelBaryCentreAnalyzer.cc

+    const SiPixelQuality* badPixelInfo = &iSetup.getData(siPixelQualityToken_);
+
+    // global position
+    edm::ESHandle<Alignments> globalAlignments;


missing esConsumes migration.

mmusich · 2021-01-05T12:32:17Z

Alignment/OfflineValidation/plugins/PixelBaryCentreAnalyzer.cc

+      PixelBaryCentreAnalyzer::initBC();
+
+      // Get TkAlign from EventSetup:
+      edm::ESHandle<Alignments> alignments;


missing esConsumes migration.

mmusich · 2021-01-05T12:32:53Z

Alignment/OfflineValidation/plugins/PixelBaryCentreAnalyzer.cc

+      PixelBaryCentreAnalyzer::initBS();
+
+      // Get BeamSpot from EventSetup
+      edm::ESHandle<BeamSpotObjects> beamhandle;


missing esConsumes migration.

mmusich · 2021-01-05T12:33:04Z

Alignment/OfflineValidation/plugins/PixelBaryCentreAnalyzer.h

+#include "FWCore/Framework/interface/Event.h"
+#include "FWCore/Framework/interface/MakerMacros.h"
+#include "FWCore/Framework/interface/EventSetup.h"
+#include "FWCore/Framework/interface/ESHandle.h"


this should go.

I got compile error removing Event.h header
"invalid use of incomplete type 'const class edm::Event'
212 | ls_ = iEvent.id().luminosityBlock()"
and compile error removing MakerMacros header
aggregate 'edm::ParameterSetDescription desc' has incomplete type and cannot be defined

In case it was not clear it's just

#include "FWCore/Framework/interface/ESHandle.h

that is unnecessary after the esConsumes migration.

yuanchao · 2021-01-11T14:38:28Z

Hi @tocheng ,
edm::eventsetup::EventSetupRecord::get<edm::ESHandle > is deprecated. Please update the corresponding code with esConsumes style in PixelBaryCentreAnalyzer.cc and TrackerOfflineValidationSummary.cc . You can refer to this twiki page: https://twiki.cern.ch/twiki/bin/view/CMSPublic/SWGuideHowToGetDataFromES#Getting_data_from_EventSetup_wit

cmsbuild · 2021-01-11T14:58:31Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-32601/20685

This PR adds an extra 12KB to repository

cmsbuild · 2021-01-11T14:58:53Z

Pull request #32601 was updated. @cmsbuild, @pohsun, @yuanchao, @christopheralanwest, @tlampen can you please check and sign again.

cmsbuild · 2021-01-27T08:23:26Z

Pull request #32601 was updated. @cmsbuild, @pohsun, @yuanchao, @christopheralanwest, @tlampen can you please check and sign again.

tlampen · 2021-01-27T08:33:51Z

please test

cmsbuild · 2021-01-27T09:18:26Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-32601/20906

This PR adds an extra 24KB to repository
Found files with invalid states:
- Alignment/OfflineValidation/plugins/PixelBaryCentreAnalyzer.h:
  - Added: a2a5877
  - Modified: 8504c54
  - Deleted: 86d718c

cmsbuild · 2021-01-27T09:18:51Z

Pull request #32601 was updated. @cmsbuild, @pohsun, @yuanchao, @christopheralanwest, @tlampen can you please check and sign again.

mmusich · 2021-01-27T21:31:39Z

@cmsbuild, please test

cmsbuild · 2021-01-28T00:22:39Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a64171/12574/summary.html
COMMIT: 0e60337
CMSSW: CMSSW_11_3_X_2021-01-27-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/32601/12574/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

No significant changes to the logs found
Reco comparison results: 4 differences found in the comparisons
DQMHistoTests: Total files compared: 37
DQMHistoTests: Total histograms compared: 2716596
DQMHistoTests: Total failures: 7
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 2716567
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 36 files compared)
Checked 156 log files, 37 edm output root files, 37 DQM output files

yuanchao · 2021-01-28T11:41:12Z

+1
Thanks a lot for the update.

cmsbuild · 2021-01-28T11:41:37Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

qliphy · 2021-01-28T11:59:26Z

+1

cmsbuild added this to the CMSSW_11_3_X milestone Jan 5, 2021

cmsbuild added alca-pending code-checks-pending orp-pending pending-signatures tests-pending labels Jan 5, 2021

cmsbuild added code-checks-approved and removed code-checks-pending labels Jan 5, 2021

cmsbuild added tests-started and removed tests-pending labels Jan 5, 2021

cmsbuild added tests-approved and removed tests-started labels Jan 5, 2021

mmusich suggested changes Jan 5, 2021

View reviewed changes

tocheng force-pushed the PixelBaryCentreAnalyzer_11_3_X branch from bc8036e to 6933359 Compare January 11, 2021 14:49

cmsbuild added code-checks-pending tests-pending and removed code-checks-approved tests-approved labels Jan 11, 2021

cmsbuild added code-checks-approved and removed code-checks-pending labels Jan 11, 2021

cmsbuild added the code-checks-approved label Jan 27, 2021

cmsbuild added tests-started and removed tests-pending labels Jan 27, 2021

update plotting script according to branch type change

0e60337

cmsbuild added code-checks-pending tests-pending and removed code-checks-approved tests-started labels Jan 27, 2021

cmsbuild added code-checks-approved and removed code-checks-pending labels Jan 27, 2021

cmsbuild added tests-started and removed tests-pending labels Jan 27, 2021

cmsbuild added tests-approved and removed tests-started labels Jan 28, 2021

cmsbuild added alca-approved fully-signed and removed alca-pending pending-signatures labels Jan 28, 2021

cmsbuild added orp-approved and removed orp-pending labels Jan 28, 2021

cmsbuild merged commit cd0fab1 into cms-sw:master Jan 28, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add PixelBaryCentreAnalyzer in Alignment offline validation tool #32601

Add PixelBaryCentreAnalyzer in Alignment offline validation tool #32601

tocheng commented Jan 5, 2021

cmsbuild commented Jan 5, 2021

cmsbuild commented Jan 5, 2021

tocheng commented Jan 5, 2021

tocheng commented Jan 5, 2021

smuzaffar commented Jan 5, 2021

cmsbuild commented Jan 5, 2021

vbotta commented Jan 5, 2021

mmusich Jan 5, 2021

tocheng Jan 15, 2021

mmusich Jan 5, 2021

tocheng Jan 15, 2021

mmusich Jan 5, 2021

tocheng Jan 15, 2021

mmusich Jan 5, 2021

tocheng Jan 15, 2021

mmusich Jan 5, 2021

tocheng Jan 15, 2021

mmusich Jan 15, 2021

yuanchao commented Jan 11, 2021

cmsbuild commented Jan 11, 2021

cmsbuild commented Jan 11, 2021

cmsbuild commented Jan 27, 2021

tlampen commented Jan 27, 2021

cmsbuild commented Jan 27, 2021

cmsbuild commented Jan 27, 2021

mmusich commented Jan 27, 2021

cmsbuild commented Jan 28, 2021

yuanchao commented Jan 28, 2021

cmsbuild commented Jan 28, 2021

qliphy commented Jan 28, 2021

		@@ -0,0 +1,117 @@
		#ifndef Alignment_OfflineValidation_PixelBaryCentreAnalyzer_H

Add PixelBaryCentreAnalyzer in Alignment offline validation tool #32601

Add PixelBaryCentreAnalyzer in Alignment offline validation tool #32601

Conversation

tocheng commented Jan 5, 2021

PR description:

PR validation:

if this PR is a backport please specify the original PR and why you need to backport that PR:

cmsbuild commented Jan 5, 2021

cmsbuild commented Jan 5, 2021

tocheng commented Jan 5, 2021

tocheng commented Jan 5, 2021

smuzaffar commented Jan 5, 2021

cmsbuild commented Jan 5, 2021

Comparison Summary

vbotta commented Jan 5, 2021

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

yuanchao commented Jan 11, 2021

cmsbuild commented Jan 11, 2021

cmsbuild commented Jan 11, 2021

cmsbuild commented Jan 27, 2021

tlampen commented Jan 27, 2021

cmsbuild commented Jan 27, 2021

cmsbuild commented Jan 27, 2021

mmusich commented Jan 27, 2021

cmsbuild commented Jan 28, 2021

Comparison Summary

yuanchao commented Jan 28, 2021

cmsbuild commented Jan 28, 2021

qliphy commented Jan 28, 2021