Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Phase2-hgx283x Correct earlier versions for orientations of the depleted layers #32615

Merged
merged 2 commits into from Jan 12, 2021

Conversation

bsunanda
Copy link
Contributor

@bsunanda bsunanda commented Jan 7, 2021

PR description:

Correct earlier versions for orientations of the depleted layers

PR validation:

Tested using the runTheMatrix test workflows

if this PR is a backport please specify the original PR and why you need to backport that PR:

Nothing special

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 7, 2021

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-32615/20665

  • This PR adds an extra 48KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

@bsunanda
Copy link
Contributor Author

bsunanda commented Jan 7, 2021

@cmsbuild Please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 7, 2021

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-32615/20667

  • This PR adds an extra 48KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 7, 2021

A new Pull Request was created by @bsunanda (Sunanda Banerjee) for master.

It involves the following packages:

Geometry/HGCalCommonData

@civanch, @Dr15Jones, @makortel, @cvuosalo, @ianna, @mdhildreth, @srimanob, @kpedro88 can you please review it and eventually sign? Thanks.
@fabiocos this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 8, 2021

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-eb10d0/12014/summary.html
COMMIT: deb6246
CMSSW: CMSSW_11_3_X_2021-01-07-1100/slc7_amd64_gcc900

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 10885 differences found in the comparisons
  • DQMHistoTests: Total files compared: 37
  • DQMHistoTests: Total histograms compared: 2716967
  • DQMHistoTests: Total failures: 126807
  • DQMHistoTests: Total nulls: 555
  • DQMHistoTests: Total successes: 2589583
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 36 files compared)
  • Checked 156 log files, 37 edm output root files, 37 DQM output files

@cvuosalo
Copy link
Contributor

cvuosalo commented Jan 8, 2021

Are the numerous comparison differences due to the HGCal changes and statistical fluctuations?

@bsunanda
Copy link
Contributor Author

bsunanda commented Jan 9, 2021

These are due to changes in HGCal geometry definition. There were issues in the earlier geometry definition.

@srimanob
Copy link
Contributor

@bsunanda
Would you mind to point to the material/presentation that shows the issue found in the earlier version? Just to complete the information on this PR. Thanks a lot.

@bsunanda
Copy link
Contributor Author

EDMS 2051653 is the bible for longitudinal segmentation. You could see the sequence there is
MotherBoard-Connector-PCB-Glue-Silicon-Glue-Kapton-Glue-Kapton-Glue-BasePlate for EE and similarly for HE. In earlier version silicon was placed next to baseplate which was incorrect.

@cvuosalo
Copy link
Contributor

+1

@srimanob
Copy link
Contributor

+upgrade

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@qliphy
Copy link
Contributor

qliphy commented Jan 12, 2021

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants