New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Phase2-hgx283x Correct earlier versions for orientations of the depleted layers #32615
Conversation
-code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-32615/20665
Code check has found code style and quality issues which could be resolved by applying following patch(s)
|
@cmsbuild Please test |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-32615/20667
|
A new Pull Request was created by @bsunanda (Sunanda Banerjee) for master. It involves the following packages: Geometry/HGCalCommonData @civanch, @Dr15Jones, @makortel, @cvuosalo, @ianna, @mdhildreth, @srimanob, @kpedro88 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-eb10d0/12014/summary.html Comparison SummarySummary:
|
Are the numerous comparison differences due to the HGCal changes and statistical fluctuations? |
These are due to changes in HGCal geometry definition. There were issues in the earlier geometry definition. |
@bsunanda |
EDMS 2051653 is the bible for longitudinal segmentation. You could see the sequence there is |
+1 |
+upgrade |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
Correct earlier versions for orientations of the depleted layers
PR validation:
Tested using the runTheMatrix test workflows
if this PR is a backport please specify the original PR and why you need to backport that PR:
Nothing special