Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix unsafe dqmed analyzers for710pre6 #3262

Merged
merged 21 commits into from Apr 9, 2014

Conversation

deguio
Copy link
Contributor

@deguio deguio commented Apr 9, 2014

new layer class (thread_unsafe::DQMEDAnalyzer) now available. the classes which use unsafe ES products which have already migrated to the DQMEDAnalyzer interface have been modified to inherit from this new class in order:

  • not to loose the work done by the developers
  • not to brake the threaded IB

the following pull requests are superseeded by this one:

webermat and others added 21 commits March 25, 2014 23:22
… functionality from OfflineClient now in other analyzers, take out of sequence
Conflicts:
	HLTriggerOffline/Common/python/HLTValidationHarvest_cff.py
Added "const" qualifier to getTypeString function for thread safety.
…yzer to be able to handle the transition to the threaded fwk while not all the product used are thread safe
@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 9, 2014

A new Pull Request was created by @deguio for CMSSW_7_1_X.

Fix unsafe dqmed analyzers for710pre6

It involves the following packages:

DQMOffline/JetMET
DQMServices/Core
HLTriggerOffline/Common
HLTriggerOffline/Exotica
Validation/RecoEgamma
Validation/RecoTrack
Validation/TrackerDigis
Validation/TrackerHits
Validation/TrackerRecHits
Validation/TrackingMCTruth

@ojeda, @danduggan, @rovere, @cmsbuild, @nclopezo, @deguio, @Degano can you please review it and eventually sign? Thanks.
@TaiSakuma, @GiacomoSguazzoni, @rovere, @nhanvtran, @cerati, @richard-cms this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@nclopezo, @ktf you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@deguio
Copy link
Contributor Author

deguio commented Apr 9, 2014

+1
if tests confirm (I have tested a number of WFs in a threaded IB and everything seems to work fine.)

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 9, 2014

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_1_X IBs unless changes or unless it breaks tests. @nclopezo, @ktf can you please take care of it?

@Dr15Jones
Copy link
Contributor

thanks

@ktf
Copy link
Contributor

ktf commented Apr 9, 2014

Being tested...

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 9, 2014

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 9, 2014

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_1_X IBs unless changes (tests are also fine). @nclopezo, @ktf can you please take care of it?

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 9, 2014

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 9, 2014

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_1_X IBs unless changes (tests are also fine). @nclopezo, @ktf can you please take care of it?

ktf added a commit that referenced this pull request Apr 9, 2014
DQM -- Fix unsafe dqmed analyzers for710pre6
@ktf ktf merged commit a25aeb1 into cms-sw:CMSSW_7_1_X Apr 9, 2014
barvic pushed a commit to barvic/cmssw that referenced this pull request Apr 30, 2014
…710pre6

DQM -- Fix unsafe dqmed analyzers for710pre6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants