Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

drop type specifications in RecoLocalCalo #32624

Merged
merged 1 commit into from Jan 10, 2021

Conversation

jeongeun
Copy link
Contributor

@jeongeun jeongeun commented Jan 9, 2021

PR description:

Update the safer syntax for existing parameter :

  • drop type specifications where the original parameter exists.

Instead of modifying parameters with full type specs, which can be interpreted as an insertion of a new parameter, it is a safer way to protect from parameter name mistakes and will also help in possible parameter migrations.
(The previous PR for RecoLocalCalo is PR#29979 and PR#30147. )

In this PR, a total of 3 files changed.
RecoLocalCalo/CaloTowersCreator
RecoLocalCalo/HcalRecAlgos
RecoLocalCalo/HcalRecProducers

PR validation:

Event Content comparison check was also done and there is no change with these updates.
Tested in CMSSW_11_2_X, the basic test all passed in the CMSSW PR instructions.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 9, 2021

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-32624/20679

  • This PR adds an extra 20KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 9, 2021

A new Pull Request was created by @jeongeun (JeongEun Lee) for master.

It involves the following packages:

RecoLocalCalo/CaloTowersCreator
RecoLocalCalo/HcalRecAlgos
RecoLocalCalo/HcalRecProducers

@perrotta, @jpata, @cmsbuild, @slava77 can you please review it and eventually sign? Thanks.
@rchatter, @argiro, @apsallid, @thomreis, @mariadalfonso, @abdoulline this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@perrotta
Copy link
Contributor

perrotta commented Jan 9, 2021

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 9, 2021

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-afdbc7/12040/summary.html
COMMIT: 4ac2f10
CMSSW: CMSSW_11_3_X_2021-01-09-1100/slc7_amd64_gcc900

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 3 differences found in the comparisons
  • DQMHistoTests: Total files compared: 37
  • DQMHistoTests: Total histograms compared: 2716967
  • DQMHistoTests: Total failures: 6
  • DQMHistoTests: Total nulls: 1
  • DQMHistoTests: Total successes: 2716938
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.004 KiB( 36 files compared)
  • DQMHistoSizes: changed ( 312.0 ): 0.004 KiB MessageLogger/Warnings
  • Checked 156 log files, 37 edm output root files, 37 DQM output files

@perrotta
Copy link
Contributor

perrotta commented Jan 9, 2021

+1

  • Technical: types dropped as planned from cloned/modified configs
  • Jenkins tests pass

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 9, 2021

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@qliphy
Copy link
Contributor

qliphy commented Jan 10, 2021

+1

@cmsbuild cmsbuild merged commit c02dff9 into cms-sw:master Jan 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants