Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed unnecessary dependency from RecoParticleFlow/PFProducer #32629

Merged

Conversation

Dr15Jones
Copy link
Contributor

PR description:

The dependency upon the Sonic packages is unnecessary and caused a linking problem on the UBSAN builds.

PR validation:

The code compiles.

The dependency upon the Sonic packages is unnecessary and caused
a linking problem on the UBSAN builds.
@jpata
Copy link
Contributor

jpata commented Jan 11, 2021

thank you for catching this & sorry for forgetting that!

@jpata
Copy link
Contributor

jpata commented Jan 11, 2021

@cmsbuild please test workflow 11834.13

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-32629/20688

  • This PR adds an extra 12KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @Dr15Jones (Chris Jones) for master.

It involves the following packages:

RecoParticleFlow/PFProducer

@perrotta, @jpata, @slava77 can you please review it and eventually sign? Thanks.
@mmarionncern, @cbernet, @lgray, @seemasharmafnal, @hatakeyamak this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@Dr15Jones
Copy link
Contributor Author

@jpata glad to help

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b87471/12087/summary.html
COMMIT: 7b7f22a
CMSSW: CMSSW_11_3_X_2021-01-10-2300/slc7_amd64_gcc900

Comparison Summary

@slava77 comparisons for the following workflows were not done due to missing matrix map:

  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-b87471/11834.13_TTbar_14TeV+2021PU_mlpf+TTbar_14TeV_TuneCP5_GenSim+DigiPU+RecoPU+HARVESTPU+Nano

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 37
  • DQMHistoTests: Total histograms compared: 2716967
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2716944
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 36 files compared)
  • Checked 156 log files, 37 edm output root files, 37 DQM output files

@slava77
Copy link
Contributor

slava77 commented Jan 11, 2021

+1

for #32629 7b7f22a

  • technical

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@qliphy
Copy link
Contributor

qliphy commented Jan 12, 2021

+1

@cmsbuild cmsbuild merged commit 8716350 into cms-sw:master Jan 12, 2021
@Dr15Jones Dr15Jones deleted the removeSonicDependencyFromPFProducer branch January 14, 2021 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants