Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

E/gamma HLT L1 Track Isolation Producer & TTTrack typedef: 11_1_X #32644

Merged
merged 5 commits into from Jan 14, 2021

Conversation

Sam-Harper
Copy link
Contributor

PR description:

This is allows track isolation with L1 tracks to be produced for electrons for the E/g Phase-II HLT

PR validation:

Tested in phase-II workflows

if this PR is a backport please specify the original PR and why you need to backport that PR:

backport of #32594

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @Sam-Harper (Sam Harper) for CMSSW_11_1_X.

It involves the following packages:

DataFormats/L1TrackTrigger
RecoEgamma/EgammaHLTProducers
RecoEgamma/EgammaIsolationAlgos

@perrotta, @cmsbuild, @fwyzard, @kpedro88, @jmduarte, @Martin-Grunewald, @rekovic, @srimanob, @slava77, @jpata can you please review it and eventually sign? Thanks.
@sobhatta, @jainshilpi, @Fedespring, @lgray, @calderona, @HuguesBrun, @rovere, @sviret, @afiqaize, @varuns23, @cericeci, @ram1123 this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@Martin-Grunewald
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6c66ec/12234/summary.html
COMMIT: aa6df7c
CMSSW: CMSSW_11_1_X_2021-01-10-0000/slc7_amd64_gcc820

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 2 differences found in the comparisons
  • DQMHistoTests: Total files compared: 36
  • DQMHistoTests: Total histograms compared: 2784828
  • DQMHistoTests: Total failures: 3
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2784775
  • DQMHistoTests: Total skipped: 50
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 35 files compared)
  • Checked 152 log files, 31 edm output root files, 36 DQM output files

@jpata
Copy link
Contributor

jpata commented Jan 13, 2021

+reconstruction

@Martin-Grunewald
Copy link
Contributor

+1

@rekovic
Copy link
Contributor

rekovic commented Jan 13, 2021

+1

@srimanob
Copy link
Contributor

+Upgrade

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_11_1_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_11_3_X is complete. This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@qliphy
Copy link
Contributor

qliphy commented Jan 14, 2021

+1

@cmsbuild cmsbuild merged commit 5deb424 into cms-sw:CMSSW_11_1_X Jan 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants