Maintain access to genParticles from signal event in packed collection for HI miniAOD #32668

mandrenguyen · 2021-01-14T08:29:16Z

PR description:

For event-overlay MC workflows, we need to know which particles are from the signal event, i.e., the one with collisionID =0. This method is not available in the packedGenParticle collection. This PR adds a PackedGenParticleRefVector containing the PackedGenParticles with collisionID =0. It's run for all HI eras; there is no change to pp workflows.

PR validation:

Tested with 158.01

if this PR is a backport please specify the original PR and why you need to backport that PR:

Will need an 11_2_X backport

@ttrk @stepobr @stahlleiton

cmsbuild · 2021-01-14T08:37:29Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-32668/20745

This PR adds an extra 32KB to repository
There are other open Pull requests which might conflict with changes you have proposed:
- File DataFormats/PatCandidates/src/classes_def_objects.xml modified in PR(s): Add track-based isolation, recHit energy sum to IsolatedTrack class #31399

cmsbuild · 2021-01-14T08:37:56Z

A new Pull Request was created by @mandrenguyen (Matthew Nguyen) for master.

It involves the following packages:

DataFormats/PatCandidates
PhysicsTools/PatAlgos

@perrotta, @jpata, @cmsbuild, @santocch, @slava77 can you please review it and eventually sign? Thanks.
@emilbols, @gouskos, @jdolen, @ahinzmann, @smoortga, @schoef, @rappoccio, @rovere, @jdamgov, @JyothsnaKomaragiri, @nhanvtran, @gkasieczka, @clelange, @cbernet, @hatakeyamak, @ferencek, @gpetruc, @andrzejnovak, @mariadalfonso, @seemasharmafnal, @mmarionncern this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

slava77 · 2021-01-14T13:04:18Z

@cmsbuild please test

perrotta · 2021-01-14T15:23:40Z

assign xpog
(perhaps more appropriate than reco for packedGenParticles)

cmsbuild · 2021-01-14T15:24:04Z

New categories assigned: xpog

@fgolf,@mariadalfonso,@gouskos you have been requested to review this Pull request/Issue and eventually sign? Thanks

perrotta · 2021-01-14T15:26:00Z

DataFormats/PatCandidates and PhysicsTools/PatAlgos were just removed from the Analysis category: I wonder whether they should stay under xpog now (in addition to reconstruction): @cms-sw/xpog-l2 what do you think?

cmsbuild · 2021-01-14T15:52:03Z

-1

Failed Tests: INPUTRelVals
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-56c8c2/12284/summary.html
COMMIT: f18dfa4
CMSSW: CMSSW_11_3_X_2021-01-13-2300/slc7_amd64_gcc900

INPUTRelVals

140.5611 step2

140.5611_RunHI2018AOD+RunHI2018AOD+REMINIAODHID18+HARVESTHI18MINIAOD/step2_RunHI2018AOD+RunHI2018AOD+REMINIAODHID18+HARVESTHI18MINIAOD.log

Comparison Summary

Summary:

No significant changes to the logs found
ROOTFileChecks: Some differences in event products or their sizes found
Reco comparison results: 4 differences found in the comparisons
DQMHistoTests: Total files compared: 37
DQMHistoTests: Total histograms compared: 2716967
DQMHistoTests: Total failures: 7
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 2716938
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 36 files compared)
Checked 156 log files, 37 edm output root files, 37 DQM output files

mandrenguyen · 2021-01-14T20:47:10Z

Do I interpret correctly that the failing test has to do with input files?

slava77 · 2021-01-14T21:40:36Z

Do I interpret correctly that the failing test has to do with input files?

no; the workflows ~~outputs are less easy to find now~~ are now extended to more tests and "INPUTS" here means that the jobs are not redoing GEN-SIM if one exists.

in the results "Matrix INPUT Tests Outputs" https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-56c8c2/12284/runTheMatrixINPUT-results/140.5611_RunHI2018AOD+RunHI2018AOD+REMINIAODHID18+HARVESTHI18MINIAOD/step2_RunHI2018AOD+RunHI2018AOD+REMINIAODHID18+HARVESTHI18MINIAOD.log

An exception of category 'ProductNotFound' occurred while
   [0] Processing  Event run: 326479 lumi: 15 event: 3808176 stream: 0
   [1] Running path 'MINIAODoutput_step'
   [2] Prefetching for module PoolOutputModule/'MINIAODoutput'
   [3] Calling method for module PackedGenParticleSignalProducer/'packedGenParticlesSignal'
Exception Message:
Principal::getByToken: Found zero products matching all criteria
Looking for type: edm::Association<std::vector<pat::PackedGenParticle> >
Looking for module label: packedGenParticles
Looking for productInstanceName:

slava77 · 2021-01-14T21:40:56Z

genParticles should not be running on data

slava77 · 2021-01-14T21:44:24Z

the workflows outputs are less easy to find now

that was a wrong statement; I corrected it now. We have more short tests done and they are placed in the "INPUTRelVals" category of tests.

cmsbuild · 2021-01-18T12:59:47Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-32668/20777

This PR adds an extra 16KB to repository
There are other open Pull requests which might conflict with changes you have proposed:
- File DataFormats/PatCandidates/src/classes_def_objects.xml modified in PR(s): Add track-based isolation, recHit energy sum to IsolatedTrack class #31399

cmsbuild · 2021-01-18T13:00:09Z

Pull request #32668 was updated. @perrotta, @gouskos, @cmsbuild, @fgolf, @slava77, @jpata, @mariadalfonso can you please check and sign again.

mandrenguyen · 2021-01-18T13:06:01Z

@perrotta The MC input file in relval is not representative. It's a pythia event embedded into a very, very peripheral (b=12) PbPb event. Running on normal embedded MC, the output miniAOD is only a fraction of a percent smaller.
The file I tested is:
/store/himc/HINPbPbAutumn18DR/Bjet_pThat-15_TuneCP5_HydjetDrumMB_5p02TeV_Pythia8/AODSIM/mva98_103X_upgrade2018_realistic_HI_v11-v1/30000/7D8C962E-9A46-9541-94AA-69C01C817F2E.root

perrotta · 2021-01-18T14:38:48Z

please test

cmsbuild · 2021-01-18T17:21:28Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-56c8c2/12325/summary.html
COMMIT: e21b2a0
CMSSW: CMSSW_11_3_X_2021-01-17-2300/slc7_amd64_gcc900

Comparison Summary

Summary:

No significant changes to the logs found
ROOTFileChecks: Some differences in event products or their sizes found
Reco comparison results: 4 differences found in the comparisons
DQMHistoTests: Total files compared: 37
DQMHistoTests: Total histograms compared: 2716961
DQMHistoTests: Total failures: 6
DQMHistoTests: Total nulls: 1
DQMHistoTests: Total successes: 2716932
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: -0.004 KiB( 36 files compared)
DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
Checked 156 log files, 37 edm output root files, 37 DQM output files

perrotta · 2021-01-18T17:47:44Z

+1

The new code adds a PackedGenParticleRefVector with refs to selected "signal" generated particles, in HI MC
Jenkins tests pass and show no difference but the additional collection in HI MC workflows

mariadalfonso · 2021-01-20T12:28:30Z

+xpog

cmsbuild · 2021-01-20T12:28:54Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

qliphy · 2021-01-20T12:37:24Z

+1

collisionId_ is not kept in pat::PackedGenParticle, use "packedGenParticlesSignal" (added by cms-sw#32668) to tag particles from signal process

* add HiGenAnalyzer This analyzer is copied from its AOD counterpart https://github.com/CmsHI/cmssw/blob/2c806f88506f7ef732b725142ae85750a31dc646/HeavyIonsAnalysis/EventAnalysis/src/HiEvtAnalyzer.cc and adapted for gen info in miniAOD Notes : GenHIEvent is currently missing from miniAOD * fix sube collisionId_ is not kept in pat::PackedGenParticle, use "packedGenParticlesSignal" (added by cms-sw#32668) to tag particles from signal process

mandrenguyen added 3 commits January 13, 2021 22:57

Store references to packedGenParticles w/ collision ID=0

7b0cc4c

code checks

395db33

switch to iterator + clean-up

f18dfa4

cmsbuild added this to the CMSSW_11_3_X milestone Jan 14, 2021

cmsbuild added analysis-pending code-checks-pending orp-pending pending-signatures reconstruction-pending tests-pending labels Jan 14, 2021

cmsbuild added code-checks-approved and removed code-checks-pending labels Jan 14, 2021

cmsbuild added tests-started and removed tests-pending analysis-pending labels Jan 14, 2021

cmsbuild added the xpog-pending label Jan 14, 2021

cmsbuild added tests-rejected and removed tests-started labels Jan 14, 2021

Added collection moved to MC event content

160aa51

cmsbuild added code-checks-pending tests-pending labels Jan 18, 2021

forgot code format, argh

e21b2a0

cmsbuild added code-checks-approved and removed code-checks-pending labels Jan 18, 2021

cmsbuild added tests-started and removed tests-pending labels Jan 18, 2021

cmsbuild added tests-approved and removed tests-started labels Jan 18, 2021

cmsbuild added reconstruction-approved and removed reconstruction-pending labels Jan 18, 2021

mandrenguyen mentioned this pull request Jan 20, 2021

[11_2_X] Maintain access to genParticles from signal event in packed collection for HI miniAOD #32696

Merged

cmsbuild added fully-signed xpog-approved and removed pending-signatures xpog-pending labels Jan 20, 2021

cmsbuild added orp-approved and removed orp-pending labels Jan 20, 2021

cmsbuild merged commit 583cfcf into cms-sw:master Jan 20, 2021

ttrk added a commit to ttrk/cmssw that referenced this pull request Sep 7, 2021

fix sube

fea4738

collisionId_ is not kept in pat::PackedGenParticle, use "packedGenParticlesSignal" (added by cms-sw#32668) to tag particles from signal process

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Maintain access to genParticles from signal event in packed collection for HI miniAOD #32668

Maintain access to genParticles from signal event in packed collection for HI miniAOD #32668

mandrenguyen commented Jan 14, 2021 •

edited

cmsbuild commented Jan 14, 2021

cmsbuild commented Jan 14, 2021

slava77 commented Jan 14, 2021

perrotta commented Jan 14, 2021

cmsbuild commented Jan 14, 2021

perrotta commented Jan 14, 2021

cmsbuild commented Jan 14, 2021 •

edited by smuzaffar

mandrenguyen commented Jan 14, 2021

slava77 commented Jan 14, 2021 •

edited

slava77 commented Jan 14, 2021

slava77 commented Jan 14, 2021

cmsbuild commented Jan 18, 2021

cmsbuild commented Jan 18, 2021

mandrenguyen commented Jan 18, 2021

perrotta commented Jan 18, 2021

cmsbuild commented Jan 18, 2021

perrotta commented Jan 18, 2021

mariadalfonso commented Jan 20, 2021

cmsbuild commented Jan 20, 2021

qliphy commented Jan 20, 2021

Maintain access to genParticles from signal event in packed collection for HI miniAOD #32668

Maintain access to genParticles from signal event in packed collection for HI miniAOD #32668

Conversation

mandrenguyen commented Jan 14, 2021 • edited

PR description:

PR validation:

if this PR is a backport please specify the original PR and why you need to backport that PR:

cmsbuild commented Jan 14, 2021

cmsbuild commented Jan 14, 2021

slava77 commented Jan 14, 2021

perrotta commented Jan 14, 2021

cmsbuild commented Jan 14, 2021

perrotta commented Jan 14, 2021

cmsbuild commented Jan 14, 2021 • edited by smuzaffar

INPUTRelVals

Comparison Summary

mandrenguyen commented Jan 14, 2021

slava77 commented Jan 14, 2021 • edited

slava77 commented Jan 14, 2021

slava77 commented Jan 14, 2021

cmsbuild commented Jan 18, 2021

cmsbuild commented Jan 18, 2021

mandrenguyen commented Jan 18, 2021

perrotta commented Jan 18, 2021

cmsbuild commented Jan 18, 2021

Comparison Summary

perrotta commented Jan 18, 2021

mariadalfonso commented Jan 20, 2021

cmsbuild commented Jan 20, 2021

qliphy commented Jan 20, 2021

mandrenguyen commented Jan 14, 2021 •

edited

cmsbuild commented Jan 14, 2021 •

edited by smuzaffar

slava77 commented Jan 14, 2021 •

edited