New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Avoid writing off beginning of arrays in RPCMonitorClient #32674
Conversation
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-32674/20767
|
A new Pull Request was created by @Dr15Jones (Chris Jones) for master. It involves the following packages: DQM/RPCMonitorClient @andrius-k, @kmaeshima, @ErnestaP, @cmsbuild, @jfernan2, @fioriNTU can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
The UBSAN build reported that an index of -2 was being used as an index into the arrays.
5cd5a4e
to
6426de3
Compare
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-32674/20768
|
Pull request #32674 was updated. @andrius-k, @kmaeshima, @ErnestaP, @cmsbuild, @jfernan2, @fioriNTU can you please check and sign again. |
please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-086dfb/12311/summary.html Comparison SummarySummary:
|
6 variables are veing removed from RPC/EventInfo, @slezki @jeongsumin @andresib can you confirm this is fine from DQM RPC side? |
Hello, @jfernan2 , I'm sorry for check this late. There is no problem on the RPC DQM side. And FYI, now I joined the company this January. So I cannot work for CMSSW from now on. |
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
The UBSAN build reported that an index of -2 was being used as an index into the arrays.
PR validation:
Code compiles.