Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid writing off beginning of arrays in RPCMonitorClient #32674

Merged
merged 1 commit into from Jan 19, 2021

Conversation

Dr15Jones
Copy link
Contributor

PR description:

The UBSAN build reported that an index of -2 was being used as an index into the arrays.

PR validation:

Code compiles.

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-32674/20767

  • This PR adds an extra 16KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @Dr15Jones (Chris Jones) for master.

It involves the following packages:

DQM/RPCMonitorClient

@andrius-k, @kmaeshima, @ErnestaP, @cmsbuild, @jfernan2, @fioriNTU can you please review it and eventually sign? Thanks.
@acimmino this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

The UBSAN build reported that an index of -2 was being used as
an index into the arrays.
@Dr15Jones Dr15Jones changed the title Avoid writing off beginning of array in RPCDaqInfo Avoid writing off beginning of arrays in RPCMonitorClient Jan 16, 2021
@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-32674/20768

  • This PR adds an extra 16KB to repository

@cmsbuild
Copy link
Contributor

Pull request #32674 was updated. @andrius-k, @kmaeshima, @ErnestaP, @cmsbuild, @jfernan2, @fioriNTU can you please check and sign again.

@Dr15Jones
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-086dfb/12311/summary.html
COMMIT: 6426de3
CMSSW: CMSSW_11_3_X_2021-01-16-1100/slc7_amd64_gcc900

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 37
  • DQMHistoTests: Total histograms compared: 2716961
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2716938
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -7.803 KiB( 36 files compared)
  • DQMHistoSizes: changed ( 1000.0,... ): -0.289 KiB RPC/EventInfo
  • Checked 156 log files, 37 edm output root files, 37 DQM output files

@jfernan2
Copy link
Contributor

6 variables are veing removed from RPC/EventInfo, @slezki @jeongsumin @andresib can you confirm this is fine from DQM RPC side?

@jeongsumin
Copy link
Contributor

Hello, @jfernan2 , I'm sorry for check this late. There is no problem on the RPC DQM side.

And FYI, now I joined the company this January. So I cannot work for CMSSW from now on.
Instead of me, @Somhammer (klar.wind0425@gmail.com) will take over my work.

@jfernan2
Copy link
Contributor

+1
Thanks @jeongsumin Good luck in industry.
I take note of @Somhammer in https://twiki.cern.ch/twiki/bin/viewauth/CMS/DQMContacts#RPC

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@silviodonato
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit e59c63e into cms-sw:master Jan 19, 2021
@Dr15Jones Dr15Jones deleted the fixRPCDaqInfo branch January 29, 2021 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants