New jet flavour definition: Backport from 7_1_X to 5_3_X

[ferencek]

Backport of #2395, #3025, and #3228.

Update (Apr. 28, 2014): PR extended by also backporting #3509 which integrates the new jet flavor into PAT. However, compared to #3509, the old jet flavor definition is left as the default in the 5_3_X release cycle.

Update (Apr. 30, 2014): PR extended by also backporting #3601 which changes the data members of pat::Jet storing the flavor information. For backward compatibility an IOREAD rule has been added as well.

Update (May 9, 2014): PR extended by also backporting #3785 which replaces runtime cms::Exception calls with edm::LogError calls in the jet flavour code

Update (May 23, 2014): PR extended by also backporting #3994 which fixes the handling of pathological cases of Pt=0 groomed jets in the jet flavour clustering

[cmsbuild]

A new Pull Request was created by @ferencek (Dinko Ferencek) for CMSSW_5_3_X.

New jet flavour definition: Backport from 7_1_X to 5_3_X

It involves the following packages:

PhysicsTools/JetExamples
PhysicsTools/JetMCAlgos
PhysicsTools/JetMCUtils
SimDataFormats/JetMatching

@civanch, @nclopezo, @mdhildreth, @monttj, @cmsbuild, @vadler, @Degano can you please review it and eventually sign? Thanks.
@pvmulder this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@smuzaffar you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

[vadler]

@ferencek : Since this is 53X legacy, could you please confirm, that the original behavior does not change (default jet flavors stay identical) and only new (optional) stuff is added for analysis benefits?

[ferencek]

Correct, the old jet flavor code is left intact and the new code lives alongside the old one. Something to maybe think about is adding the new code as an optional feature in 53X PAT.

I will add the integration of the new flavor code to https://twiki.cern.ch/twiki/bin/view/CMSPublic/SWGuidePhysicsToolsProjects but this is not likely to happen for 7_1_0. Can this be implemented in one of the later 7_1_X releases or will it have to wait for 7_2_0?

[vadler]

The last open 71X is 710pre8 on Apr. 28th:
https://twiki.cern.ch/twiki/bin/viewauth/CMS/CMSSW_7_1_0
However, one can certainly backport from 72X to 71X.

[vadler]

+1

[vadler]

+1
S. #3994 (comment)

[cmsbuild]

Pull request #3268 was updated. @cmsbuild, @civanch, @Degano, @mdhildreth, @nclopezo can you please check and sign again.

[ferencek]

A monthly deadline for the next 5_3_X release is approaching. Any chance of getting this PR fully signed and merged? The list of packages that need to be checked out in a related PAT recipe at https://twiki.cern.ch/twiki/bin/view/CMSPublic/SWGuidePATReleaseNotes52X#Add_new_jet_flavour is a bit longish so it would be quite convenient to have the code integrated.

[ferencek]

@civanch, @mdhildreth Any chance of having this signed before June 9 deadline for the next 5_3_X_release? Thank you

[pvmulder]

@cmsbuild, @civanch, @Degano, @mdhildreth, @nclopezo
Is there an issue with this PR that prevents signing?

[smuzaffar]

+tested

[civanch]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_5_3_X IBs unless changes (tests are also fine). @smuzaffar can you please take care of it?