Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated phase 2 templates with extended angle space, backport of #32220 #32712

Conversation

mmusich
Copy link
Contributor

@mmusich mmusich commented Jan 22, 2021

backport of #32220

PR description:

This PR updates the phase2 template and genError objects to have extended angle coverage. This was needed in order to correct a previous issue where there were a good number of hits outside their angle space and lead to poor resolution.
The backport is needed in order to carry out certain performance studies within the phase-2 IT sensor performance Task Force.

PR validation:

Results validating these condition changes were shown at the phase 2 simulation meeting here

if this PR is a backport please specify the original PR and why you need to backport that PR:

This is a verbatim backport of part of #32220 (only commit cdc42ce)

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 22, 2021

A new Pull Request was created by @mmusich (Marco Musich) for CMSSW_11_2_X.

It involves the following packages:

CondFormats/SiPixelTransient
Configuration/AlCa

@perrotta, @yuanchao, @slava77, @christopheralanwest, @cmsbuild, @jpata, @tlampen, @ggovi, @pohsun can you please review it and eventually sign? Thanks.
@makortel, @tocheng, @VinInn, @Martin-Grunewald, @OzAmram, @ferencek, @mmusich, @dkotlins, @fabiocos, @seemasharmafnal, @tvami this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@mmusich
Copy link
Contributor Author

mmusich commented Jan 22, 2021

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c052e5/12451/summary.html
COMMIT: 4bdbd08
CMSSW: CMSSW_11_2_X_2021-01-21-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/32712/12451/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 3363 differences found in the comparisons
  • DQMHistoTests: Total files compared: 36
  • DQMHistoTests: Total histograms compared: 2529619
  • DQMHistoTests: Total failures: 33823
  • DQMHistoTests: Total nulls: 1
  • DQMHistoTests: Total successes: 2495773
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.004 KiB( 35 files compared)
  • DQMHistoSizes: changed ( 312.0 ): 0.004 KiB MessageLogger/Warnings
  • Checked 151 log files, 37 edm output root files, 36 DQM output files

@mmusich
Copy link
Contributor Author

mmusich commented Jan 22, 2021

type bug-fix

@slava77
Copy link
Contributor

slava77 commented Jan 22, 2021

backport of #32220

the bot wouldn't pick it up, apparently, from the PR title

@slava77
Copy link
Contributor

slava77 commented Jan 25, 2021

+1

for #32712 4bdbd08

  • code changes are in line with the PR description;
  • jenkins tests pass and comparisons with the baseline show (relevan) differences only in phase-2 workflows

@qliphy
Copy link
Contributor

qliphy commented Jan 26, 2021

ping @cms-sw/alca-l2 @cms-sw/db-l2

@ggovi
Copy link
Contributor

ggovi commented Jan 26, 2021

+1

@yuanchao
Copy link
Contributor

+1

  • matrix tests and unit tests all passed
  • no error/warnings on static build checks

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_11_2_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_11_3_X is complete. This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@qliphy
Copy link
Contributor

qliphy commented Jan 26, 2021

+1

@cmsbuild cmsbuild merged commit 85d4240 into cms-sw:CMSSW_11_2_X Jan 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants