(Backport) Hcal: Fix the TDC Simulation Algorithm

[lwang046]

back port of #32729.

This fix doesn't affect DIGI/RECO output in any workflow as TDC info it not used by any consumer at the moment. It's used (with explicit customization) only in special HCAL samples produced on demand for LLP physics studies

[cmsbuild]

A new Pull Request was created by @lwang046 for CMSSW_11_2_X.

It involves the following packages:

SimCalorimetry/HcalSimAlgos

@cmsbuild, @civanch, @mdhildreth can you please review it and eventually sign? Thanks.
@mariadalfonso, @abdoulline, @rovere this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[abdoulline]

@civanch Vladimir, could you do "please test"?

[civanch]

please test

[cmsbuild]

-1

Failed Tests: RelVals-INPUT
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-42f3cb/12535/summary.html
COMMIT: 19307aa
CMSSW: CMSSW_11_2_X_2021-01-25-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/32730/12535/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals-INPUT

• 4.764.76_ZMuSkim2012D+ZMuSkim2012D+HLTDSKIM2+RECODR1reHLT2+HARVESTDR1reHLT/step2_ZMuSkim2012D+ZMuSkim2012D+HLTDSKIM2+RECODR1reHLT2+HARVESTDR1reHLT.log

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 7 differences found in the comparisons
• DQMHistoTests: Total files compared: 36
• DQMHistoTests: Total histograms compared: 2529619
• DQMHistoTests: Total failures: 182
• DQMHistoTests: Total nulls: 1
• DQMHistoTests: Total successes: 2529414
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.004 KiB( 35 files compared)
• DQMHistoSizes: changed ( 312.0 ): 0.004 KiB MessageLogger/Warnings
• Checked 151 log files, 37 edm output root files, 36 DQM output files

[abdoulline]

(1) wf 4.76 fails as it couldn't get an access to its input data (as in other PRs)
(2) quick look at the DQM bin-by-bin shows difference solely in QIE11 (2018 HE, >=2021 HB/HE) TDC plots, as expected.

@lwang046 Long, please, take a look at (2)
https://cmssdt.cern.ch/SDT/jenkins-artifacts/baseLineComparisons/CMSSW_11_2_X_2021-01-25-2300+42f3cb/40982/dqm-histo-comparison-summary.html
to make sure the change in TDC distributions look as expected.

[lwang046]

From the available distributions in DQM they look reasonable and resemble what was saw about TDC info in 2018 isolation data.

[abdoulline]

OK, thanks!

…

On Tue, 26 Jan 2021, lwang046 wrote: From the available distributions in DQM they look reasonable and resemble what was saw about TDC info in 2018 isolation data. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, orunsubscribe.[ABGHJWVZ3267JF3QSYV3DP3S325QJA5CNFSM4WRQNOWKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63L NMVXHJKTDN5WW2ZLOORPWSZGOFW7ZVGY.gif]

[civanch]

+1

changes expected; failed WF is due to files absence not this PR.

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_11_2_X IBs (but tests are reportedly failing) and once validation in the development release cycle CMSSW_11_3_X is complete. This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[qliphy]

+1

[qliphy]

merge