Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DQM: setStatOverflows to use bool #32737

Merged
merged 2 commits into from Jan 26, 2021
Merged

DQM: setStatOverflows to use bool #32737

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
193cda7
setStatOverflows to use bool
jfernan2 Jan 25, 2021
baccbdd
Update MonitorElement.h
jfernan2 Jan 25, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion DQMServices/Core/interface/MonitorElement.h
View file
Open in desktop
Expand Up @@ -427,7 +427,7 @@ namespace dqm::impl {
virtual void setCanExtend(unsigned int value);
// We should decide if we support this (or make it default)
DQM_DEPRECATED
virtual void setStatOverflows(unsigned int value);
virtual void setStatOverflows(bool value);

// these should be non-const, since they are potentially not thread-safe
virtual TObject const *getRootObject() const;
Expand Down
2 changes: 1 addition & 1 deletion DQMServices/Core/src/MonitorElement.cc
View file
Open in desktop
Expand Up @@ -904,7 +904,7 @@ namespace dqm::impl {
access.value.object_->SetCanExtend(value);
}

void MonitorElement::setStatOverflows(unsigned int value) {
void MonitorElement::setStatOverflows(bool value) {
auto access = this->accessMut();
if (value == kTRUE)
access.value.object_->SetStatOverflows(TH1::kConsider);
Expand Down