(11.1.X) Follow-up of #32700 (Phase 2 Muon HLT)

[khaosmos93]

PR description:

Addressing comments in #32699 and #32713

PR validation:

Phase-2 muon workflow

if this PR is a backport please specify the original PR and why you need to backport that PR:

#32713

[cmsbuild]

A new Pull Request was created by @khaosmos93 (Minseok Oh) for CMSSW_11_1_X.

It involves the following packages:

HLTrigger/HLTfilters
HLTrigger/Muon
RecoMuon/L2MuonSeedGenerator

@perrotta, @Martin-Grunewald, @slava77, @cmsbuild, @fwyzard, @jpata can you please review it and eventually sign? Thanks.
@bellan, @abbiendi, @Fedespring, @Martin-Grunewald, @calderona, @HuguesBrun, @jhgoh, @trocino, @cericeci, @rociovilar this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

• Backported from Follow-up of #32699 (Phase 2 Muon HLT) #32713

[fwyzard]

please test

[fwyzard]

+hlt

[fwyzard]

backport #32713

[jpata]

Just in case, in the master branch, there is a range based loop here, https://github.com/cms-sw/cmssw/pull/32713/files#diff-70b2a719aac32ca979c0ac376047b49c9ed92e9098d0eca81fb05ea80b6ae16dR367-R369

              for (auto const &recHit : assoOffseed->recHits()) {
                container.push_back(recHit);
              }

so the backport and the original PR differ. Let me know if this was intentional.

[khaosmos93]

Yes it's intended. The TrajectorySeed class was updated to use edm::Range in 11_3:
877108f#diff-e4ad11aac7f1defe33fb2758bc5ae0ad95b2eb4964cc761285b22266f8e13d67L50

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-16e0f2/12563/summary.html
COMMIT: 50f5c4f
CMSSW: CMSSW_11_1_X_2021-01-26-1100/slc7_amd64_gcc820
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/32751/12563/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

The workflows 140.53 have different files in step1_dasquery.log than the ones found in the baseline. You may want to check and retrigger the tests if necessary. You can check it in the "files" directory in the results of the comparisons

Summary:

• No significant changes to the logs found
• Reco comparison results: 1260 differences found in the comparisons
• DQMHistoTests: Total files compared: 36
• DQMHistoTests: Total histograms compared: 2784828
• DQMHistoTests: Total failures: 1983
• DQMHistoTests: Total nulls: 44
• DQMHistoTests: Total successes: 2782751
• DQMHistoTests: Total skipped: 50
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: -45.703 KiB( 35 files compared)
• DQMHistoSizes: changed ( 140.53 ): -44.531 KiB Hcal/DigiRunHarvesting
• DQMHistoSizes: changed ( 140.53 ): -1.172 KiB RPC/DCSInfo
• Checked 152 log files, 31 edm output root files, 36 DQM output files

[jpata]

+reconstruction

• backport of Follow-up of #32699 (Phase 2 Muon HLT) #32713 and nothing else
• tests have no relevant differences (code does not run in tests, failures are unrelated)

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_11_1_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_11_3_X is complete. This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[qliphy]

+1