New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix small bugs in geometry DB payload scripts -- Backport of #32361 #32773
Conversation
A new Pull Request was created by @cvuosalo (Carl Vuosalo) for CMSSW_11_2_X. It involves the following packages: CondTools/Geometry @andrius-k, @Dr15Jones, @makortel, @cvuosalo, @ianna, @mdhildreth, @ErnestaP, @cmsbuild, @kmaeshima, @jfernan2, @ahmad3213, @civanch, @ggovi, @rvenditti can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
type bug-fix |
Pull request #32773 was updated. @andrius-k, @Dr15Jones, @makortel, @cvuosalo, @ianna, @mdhildreth, @ErnestaP, @cmsbuild, @kmaeshima, @jfernan2, @ahmad3213, @civanch, @ggovi, @rvenditti can you please check and sign again. |
@cmsbuild please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9cf278/12607/summary.html Comparison SummarySummary:
|
+1 |
+1 |
+1 |
This pull request is fully signed and it will be integrated in one of the next CMSSW_11_2_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_11_3_X is complete. This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
Several recent PRs inadvertently caused problems for the scripts that create and check geometry DB payloads. This PR fixes those problems.
PR validation:
These scripts are run by experts to create and check geometry DB payloads. They are not used in workflows. These changes were tested during the creation of new payloads.
This PR is a backport of #32361 from 11_3. It is needed because the GEM group has requested new geometry DB payloads for 11_2.