Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix small bugs in geometry DB payload scripts -- Backport of #32361 #32773

Merged
merged 3 commits into from Feb 2, 2021

Conversation

cvuosalo
Copy link
Contributor

Several recent PRs inadvertently caused problems for the scripts that create and check geometry DB payloads. This PR fixes those problems.

PR validation:

These scripts are run by experts to create and check geometry DB payloads. They are not used in workflows. These changes were tested during the creation of new payloads.

This PR is a backport of #32361 from 11_3. It is needed because the GEM group has requested new geometry DB payloads for 11_2.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @cvuosalo (Carl Vuosalo) for CMSSW_11_2_X.

It involves the following packages:

CondTools/Geometry
Geometry/TrackerGeometryBuilder
Validation/Geometry

@andrius-k, @Dr15Jones, @makortel, @cvuosalo, @ianna, @mdhildreth, @ErnestaP, @cmsbuild, @kmaeshima, @jfernan2, @ahmad3213, @civanch, @ggovi, @rvenditti can you please review it and eventually sign? Thanks.
@fabiocos, @vargasa, @makortel, @JanFSchulte, @rovere, @VinInn, @venturia, @apsallid, @lecriste, @mmusich, @rishabhCMS, @mtosi, @ebrondol, @rbartek this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@cvuosalo
Copy link
Contributor Author

type bug-fix

@cmsbuild
Copy link
Contributor

Pull request #32773 was updated. @andrius-k, @Dr15Jones, @makortel, @cvuosalo, @ianna, @mdhildreth, @ErnestaP, @cmsbuild, @kmaeshima, @jfernan2, @ahmad3213, @civanch, @ggovi, @rvenditti can you please check and sign again.

@cvuosalo
Copy link
Contributor Author

@cmsbuild please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9cf278/12607/summary.html
COMMIT: f22829e
CMSSW: CMSSW_11_2_X_2021-01-29-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/32773/12607/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 36
  • DQMHistoTests: Total histograms compared: 2529619
  • DQMHistoTests: Total failures: 7
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2529590
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 35 files compared)
  • Checked 151 log files, 37 edm output root files, 36 DQM output files

@jfernan2
Copy link
Contributor

+1

@ggovi
Copy link
Contributor

ggovi commented Feb 1, 2021

+1

@cvuosalo
Copy link
Contributor Author

cvuosalo commented Feb 1, 2021

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 1, 2021

This pull request is fully signed and it will be integrated in one of the next CMSSW_11_2_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_11_3_X is complete. This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@qliphy
Copy link
Contributor

qliphy commented Feb 2, 2021

+1

@cmsbuild cmsbuild merged commit f94e801 into cms-sw:CMSSW_11_2_X Feb 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants