Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include <algorithm> in CSCDBL1TPParametersExtended.cc for std::find #32779

Merged
merged 1 commit into from Feb 9, 2021
Merged

Include <algorithm> in CSCDBL1TPParametersExtended.cc for std::find #32779

merged 1 commit into from Feb 9, 2021

Conversation

guitargeek
Copy link
Contributor

PR description:

Adding a missing include to build the CondFormats on my laptop with gcc 10.2.0.

PR validation:

CMSSW compiles.

if this PR is a backport please specify the original PR and why you need to backport that PR:

No backport intended.

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-32779/20941

  • This PR adds an extra 16KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @guitargeek (Jonas Rembser) for master.

It involves the following packages:

CondFormats/CSCObjects

@yuanchao, @christopheralanwest, @cmsbuild, @tlampen, @ggovi, @pohsun can you please review it and eventually sign? Thanks.
@ptcox, @dildick, @mmusich, @seemasharmafnal, @tocheng this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@ggovi
Copy link
Contributor

ggovi commented Feb 1, 2021

please test

@guitargeek
Copy link
Contributor Author

Hi @ggovi, @sliviodonato, the bot test didn't get triggered :(

@qliphy
Copy link
Contributor

qliphy commented Feb 4, 2021

please abort

@qliphy
Copy link
Contributor

qliphy commented Feb 4, 2021

please test

@qliphy
Copy link
Contributor

qliphy commented Feb 4, 2021

Hi @ggovi, @sliviodonato, the bot test didn't get triggered :(

let's try again

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 4, 2021

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-1d5ed4/12704/summary.html
COMMIT: d304a00
CMSSW: CMSSW_11_3_X_2021-02-03-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/32779/12704/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 37
  • DQMHistoTests: Total histograms compared: 2752926
  • DQMHistoTests: Total failures: 6
  • DQMHistoTests: Total nulls: 1
  • DQMHistoTests: Total successes: 2752897
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -0.004 KiB( 36 files compared)
  • DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
  • Checked 156 log files, 37 edm output root files, 37 DQM output files

@christopheralanwest
Copy link
Contributor

+alca

@ggovi
Copy link
Contributor

ggovi commented Feb 9, 2021

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 9, 2021

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@qliphy
Copy link
Contributor

qliphy commented Feb 9, 2021

+1

@cmsbuild cmsbuild merged commit 0553ee4 into cms-sw:master Feb 9, 2021
@guitargeek guitargeek deleted the CSCDBL1TPParametersExtended_algorithm branch February 10, 2021 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants