Phase-2 Inner Tracker local reconstruction configuration updates

[mmusich]

PR description:

The purpose of this PR is to update the conditions and customizations used to deal with the Phase-2 Inner tracker local reconstruction.
With respect to last update (PR #32220) it has been found that:

1. a later version of pixel templates and GenError payloads was produced with enhanced angular span in cotα and cotβ,
2. the template reconstruction for the square pixels (geometry T22) is sub-optimal at the physical edges of modules and at very high rapidity (|η|>2.5) (see more details here). These effects are due to some limitation to the pixel template reconstruction code in presence of 50um long cells in the longitudinal direction. As it seems - at this point - unlikely to instrument the phase-2 inner tracker with 50x50 pixels especially at high rapidity due to low resilience to radiation damage, it has been instead preferred to avoid changing the reconstruction code and use the generic reconstruction instead, within the limited scope of producing reference resolution results in the not-irradiated simulation case.

The first point is addressed in commit 5e2562c by updating the autoCondPhase2.py file, while the second is addressed by introducing two Eras be used on top of the PixelCPEGeneric process modifier (N.B. its name has been changed since now is generic enough not to entail only phase2):

• Phase2C11T23 (targeting geometry T23, and 3D pixels in general) removes any usage of template / genError payloads from the reconstruction, as those are not yet available for 3D pixels
• Phase2C11T22 (targeting geometry T22 and square pixels in general) allows to use genErrors in the seeding step (when no track angles are available). This is needed because hardcoded errors in https://github.com/cms-sw/cmssw/blob/master/RecoLocalTracker/SiPixelRecHits/src/PixelCPEGeneric.cc#L113 have been optimized for rectangular 25x100 pixels, and in the current generic reco setup we use hardcoded errors for the first tracking pass (see PR Phase2 Updated Pixel Conditions and GenericCPE Seeding Errors Fix #29783)

PR validation:

Run successfully runTheMatrix.py --what upgrade -l 29806.0,30606.0,30206.0 to test technical soundness of the code changes.
Private internal validation of the new setup is available here: https://dinardo.web.cern.ch/dinardo/TMPshare/
In particular the pulls for the track parameters for T22 have changed from:

Before this PR	With this PR

In blue is T22 (with generic CPE) while in red is T21 (with template CPE, baseline).

if this PR is a backport please specify the original PR and why you need to backport that PR:

This PR is not a backport and no backport is needed.
cc:
@emiglior @tsusa @OzAmram @tvami @gennai @dinardo

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-32789/20957

• This PR adds an extra 24KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File Configuration/PyReleaseValidation/python/upgradeWorkflowComponents.py modified in PR(s): Adding GEN fragment (GluGluTo2Jets_ExHume) specific for PPS wf testing #32765, Introduce TritonService and workflows #32576, Squash all Patatrack developments on top of CMSSW_11_3_0_pre5 #27983, Track classifier using TensorFlow - continuation #32128, Patatrack integration - Pixel workflows (12/N) #31854

[mmusich]

@cmsbuild, please test

[cmsbuild]

A new Pull Request was created by @mmusich (Marco Musich) for master.

It involves the following packages:

Configuration/AlCa
Configuration/PyReleaseValidation
RecoLocalTracker/SiPixelRecHits

@perrotta, @malbouis, @yuanchao, @jordan-martins, @chayanit, @wajidalikhan, @slava77, @christopheralanwest, @kpedro88, @srimanob, @tlampen, @jpata, @pohsun, @francescobrivio can you please review it and eventually sign? Thanks.
@fabiocos, @makortel, @felicepantaleo, @GiacomoSguazzoni, @JanFSchulte, @rovere, @VinInn, @Martin-Grunewald, @gpetruc, @OzAmram, @tocheng, @ferencek, @mtosi, @mmusich, @dkotlins, @threus, @ebrondol, @slomeo, @tvami this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[chayanit]

+1

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c28da2/12645/summary.html
COMMIT: d6428e9
CMSSW: CMSSW_11_3_X_2021-02-01-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/32789/12645/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 3188 differences found in the comparisons
• DQMHistoTests: Total files compared: 37
• DQMHistoTests: Total histograms compared: 2752926
• DQMHistoTests: Total failures: 38227
• DQMHistoTests: Total nulls: 1
• DQMHistoTests: Total successes: 2714676
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: -0.004 KiB( 36 files compared)
• DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
• Checked 156 log files, 37 edm output root files, 37 DQM output files

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-32789/20982

• This PR adds an extra 24KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File Configuration/PyReleaseValidation/python/upgradeWorkflowComponents.py modified in PR(s): Adding GEN fragment (GluGluTo2Jets_ExHume) specific for PPS wf testing #32765, Squash all Patatrack developments on top of CMSSW_11_3_0_pre5 #27983, Track classifier using TensorFlow - continuation #32128, Patatrack integration - Pixel workflows (12/N) #31854, Introduce TritonService and workflows #32576

[slava77]

+1

for #32789 b6b3a4c

• code changes are in line with the PR description and the follow up review
• jenkins tests pass and comparisons with the baseline show small differences in the phase-2 workflows
  • it looks like perhaps larger changes are expected in T22 and T23 geometries, which are not a part of the short matrix set used in the comparisons

[cvuosalo]

+1

[chayanit]

+1

[civanch]

+1

[srimanob]

+Upgrade

[christopheralanwest]

+alca

[silviodonato]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will be automatically merged.