Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ignore autogenerated __init__.py files #328

Merged
merged 1 commit into from Aug 14, 2013

Conversation

fwyzard
Copy link
Contributor

@fwyzard fwyzard commented Aug 14, 2013

ignore autogenerated init.py files

ktf added a commit that referenced this pull request Aug 14, 2013
ignore autogenerated __init__.py files
@ktf ktf merged commit 3bfcb12 into cms-sw:CMSSW_7_0_X Aug 14, 2013
@Dr15Jones
Copy link
Contributor

Ignoring all init.py files isn't safe since we do have a few legitimate ones such as
PhysicsTools/PythonAnalysis/python/init.py
PhysicsTools/PythonAnalysis/python/rootplot/init.py

@ktf
Copy link
Contributor

ktf commented Aug 14, 2013

I discussed this with @fwyzard privately. .gitignore affects only untracked files, not tracked ones, so this only affects new legitimate __init__.py files which would have to be added explicitly via git add -f.

Between CMSSW_5_2_0 and CMSSW_7_0_0_pre0 (i.e. almost last two years) we had only 12 __init__.py files modified, in 11 cases it was automatically generated files being removed, in one case it was a one line modification (which the change in question would still allow as usual) and there were no cases in which a new __init__.py file was added. Between CMSSW_7_0_0_pre0 and CMSSW_7_0_0_pre2 (i.e. last two months) I could count already 2 __init__.py added by accident in a pull request (most likely via git add .). I think it's safer the setup Andrea proposes.

In any case once we move to generate files in a separate path, we can revert this.

makortel pushed a commit to makortel/cmssw that referenced this pull request Apr 22, 2015
get-pr-branch: Print the exception contents
fwyzard pushed a commit to fwyzard/cmssw that referenced this pull request Apr 23, 2019
Remove redundant calls to cuda::event_t::has_occurred(), since it is already part of CUDAProduct::isAvailable().
slava77 added a commit to slava77/cmssw that referenced this pull request Oct 9, 2021
Avoid frtree to be written in plots.root + other updates for standalone workflow (samples and only initialStep for BH, STD and CE builds)
FHead pushed a commit to FHead/cmssw that referenced this pull request Nov 5, 2021
* reco::Track::dzError() is to be used for HIN track ID

* fill nVtx and explicitly find maxPtSum vertex
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants