Remove GEM StripDigiSimLinks, only use GEMDigiSimLink

[watson-ij]

PR description:

Currently, there are two collections of SimLinks for GEM, GEMStripDigiSimLink and GEMDigiSimLink, which as far as I can see simply duplicate functionality. GEMStripDigiSimLink was only used in the GEMHitAssociator, but is easily replaced by GEMDigiSimLink which is used elsewhere in the codebase.

@jshlee @dildick

PR validation:

Checked the a phase 2 workflow runs to completion with no errors.

if this PR is a backport please specify the original PR and why you need to backport that PR:

Before submitting your pull requests, make sure you followed this checklist:

• verify that the PR is really intended for the chosen branch
• verify that changes follow CMS Naming, Coding, And Style Rules
• verify that the PR passes the basic test procedure suggested in the CMSSW PR instructions

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-32811/20996

• This PR adds an extra 20KB to repository

[cmsbuild]

A new Pull Request was created by @watson-ij (Ian J. Watson) for master.

It involves the following packages:

SimMuon/GEMDigitizer
SimMuon/MCTruth

@cmsbuild, @srimanob, @kpedro88, @mdhildreth, @civanch can you please review it and eventually sign? Thanks.
@battibass, @slomeo, @abbiendi, @Fedespring, @jshlee, @calderona, @HuguesBrun, @jhgoh, @dildick, @trocino, @cericeci this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[civanch]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4b0e03/12706/summary.html
COMMIT: 568b0ce
CMSSW: CMSSW_11_3_X_2021-02-03-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/32811/12706/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• ROOTFileChecks: Some differences in event products or their sizes found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 37
• DQMHistoTests: Total histograms compared: 2752926
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2752903
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 36 files compared)
• Checked 156 log files, 37 edm output root files, 37 DQM output files

[dildick]

@watson-ij Sounds good. AFAICT GEMStripDigiSimLink is not as useful as GEMDigiSimLink.

[dildick]

You can probably do the same for ME0DigiProducer (even if it will be phased out in due time)

[civanch]

+1

[watson-ij]

You can probably do the same for ME0DigiProducer (even if it will be phased out in due time)

Yes, thats a good point. I added a commit which also removed the additional SimLink from ME0

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-32811/21021

• This PR adds an extra 16KB to repository

[cmsbuild]

Pull request #32811 was updated. @cmsbuild, @srimanob, @kpedro88, @mdhildreth, @civanch can you please check and sign again.

[civanch]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4b0e03/12732/summary.html
COMMIT: 4f019b2
CMSSW: CMSSW_11_3_X_2021-02-04-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/32811/12732/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• ROOTFileChecks: Some differences in event products or their sizes found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 37
• DQMHistoTests: Total histograms compared: 2751765
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2751742
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 36 files compared)
• Checked 156 log files, 37 edm output root files, 37 DQM output files

[civanch]

+1

[srimanob]

+Upgrade

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[qliphy]

+1