Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove a few unneeded header inclusions in reco packages #32812

Merged
merged 2 commits into from Feb 5, 2021

Conversation

perrotta
Copy link
Contributor

@perrotta perrotta commented Feb 4, 2021

PR description:

Some sparse cleaning of a few header inclusions

PR validation:

It builds

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 4, 2021

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-32812/20998

  • This PR adds an extra 28KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

@@ -72,8 +71,8 @@ HiFJRhoFlowModulationProducer::HiFJRhoFlowModulationProducer(const edm::Paramete
evtPlaneToken_(consumes<reco::EvtPlaneCollection>(iConfig.getParameter<edm::InputTag>("EvtPlane"))) {
produces<std::vector<double>>("rhoFlowFitParams");
TMinuitMinimizer::UseStaticMinuit(false);
lineFit_p_ = std::unique_ptr<TF1>(new TF1("lineFit", lineFunction, -TMath::Pi(), TMath::Pi()));
flowFit_p_ = std::unique_ptr<TF1>(new TF1("flowFit", flowFunction, -TMath::Pi(), TMath::Pi()));
lineFit_p_ = std::make_unique<TF1>("lineFit", lineFunction, -TMath::Pi(), TMath::Pi());
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This update was automatically implemented by "scram b code-checks"

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 4, 2021

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-32812/20999

  • This PR adds an extra 28KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 4, 2021

A new Pull Request was created by @perrotta for master.

It involves the following packages:

RecoBTag/SecondaryVertex
RecoHI/HiJetAlgos
RecoParticleFlow/PFProducer

@perrotta, @jpata, @cmsbuild, @slava77 can you please review it and eventually sign? Thanks.
@mmarionncern, @yslai, @smoortga, @kurtejung, @emilbols, @jazzitup, @lgray, @JyothsnaKomaragiri, @yenjie, @hatakeyamak, @ferencek, @andrzejnovak, @yetkinyilmaz, @mandrenguyen, @dgulhan, @seemasharmafnal, @cbernet this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@perrotta
Copy link
Contributor Author

perrotta commented Feb 4, 2021

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 4, 2021

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-1d45e0/12708/summary.html
COMMIT: 357be33
CMSSW: CMSSW_11_3_X_2021-02-03-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/32812/12708/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 37
  • DQMHistoTests: Total histograms compared: 2752926
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2752903
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 36 files compared)
  • Checked 156 log files, 37 edm output root files, 37 DQM output files

@perrotta
Copy link
Contributor Author

perrotta commented Feb 4, 2021

+1

  • Technical, cleaning
  • Jenkins tests pass and show no effect on outputs

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 4, 2021

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@qliphy
Copy link
Contributor

qliphy commented Feb 5, 2021

+1

@cmsbuild cmsbuild merged commit ebf81a8 into cms-sw:master Feb 5, 2021
@perrotta perrotta deleted the removeUnneededHeaders branch February 9, 2021 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants