Run3-gex53 Correct ECAL algorithms for dd4hep #32823

bsunanda · 2021-02-04T22:27:30Z

PR description:

Correct ECAL algorithms for dd4hep (treatment of units)

PR validation:

Tested using cfg's in SimG4Core/Configuration/test

if this PR is a backport please specify the original PR and why you need to backport that PR:

Nothing special

cmsbuild · 2021-02-04T22:34:07Z

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-32823/21014

This PR adds an extra 40KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

code-format:
https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-32823/21014/code-format.patch
e.g. curl https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-32823/21014/code-format.patch | patch -p1
You can also run scram build code-format to apply code format directly

cmsbuild · 2021-02-04T22:47:29Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-32823/21015

This PR adds an extra 40KB to repository

cmsbuild · 2021-02-04T22:47:54Z

A new Pull Request was created by @bsunanda (Sunanda Banerjee) for master.

It involves the following packages:

Geometry/EcalCommonData

@civanch, @Dr15Jones, @makortel, @cvuosalo, @ianna, @mdhildreth, @cmsbuild can you please review it and eventually sign? Thanks.
@rchatter, @fabiocos, @thomreis, @argiro this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

bsunanda · 2021-02-04T23:11:22Z

@cmsbuild Please test

cmsbuild · 2021-02-05T01:38:19Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5283ff/12723/summary.html
COMMIT: 94f53cf
CMSSW: CMSSW_11_3_X_2021-02-04-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/32823/12723/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

No significant changes to the logs found
Reco comparison results: 4 differences found in the comparisons
DQMHistoTests: Total files compared: 37
DQMHistoTests: Total histograms compared: 2751765
DQMHistoTests: Total failures: 7
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 2751736
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 36 files compared)
Checked 156 log files, 37 edm output root files, 37 DQM output files

civanch · 2021-02-05T10:54:54Z

Geometry/EcalCommonData/plugins/dd4hep/DDEcalBarrelNewAlgo.cc

@@ -1146,7 +1150,7 @@ static long algorithm(dd4hep::Detector& /* description */, cms::DDParsingContext
            }
            unsigned int femCopy(0);
            for (unsigned int ilyFEM(0); ilyFEM != ily.vecIlyFEMZ.size(); ++ilyFEM) {
-              const double radius(ilyRMax - 1_mm - ily.fEMHeightHalf);
+              const double radius(ilyRMax - 1 * dd4hep::mm - ily.fEMHeightHalf);


@bsunanda , why we need "1 * dd4hep::mm"? May it be "dd4hep::mm"? or compiler is cleaver enough to recognize this?

keeping 1 to make it look 1 mm

civanch · 2021-02-05T10:56:18Z

Geometry/EcalCommonData/plugins/dd4hep/DDEcalBarrelNewAlgo.cc

@@ -1440,8 +1445,8 @@ static long algorithm(dd4hep::Detector& /* description */, cms::DDParsingContext

    // theta is angle in yz plane between z axis & leading edge of crystal
    double theta(90_deg);
-    double zee(0_mm);
-    double side(0_mm);
+    double zee(0 * dd4hep::mm);


why not simply (0.) in all places?

using 0 now

civanch · 2021-02-05T11:00:05Z

bug

civanch · 2021-02-05T11:02:18Z

bug-fix

bsunanda · 2021-02-05T18:21:20Z

@cvuosalo @civanch specification of unit says the type of measurement. I can remove that for 0 but for 1mm it is better to be explicit. I am in 2 mind what is the best even for 0.

cvuosalo · 2021-02-05T20:05:39Z

I prefer 1 * dd4hep::mm. For zero, I would prefer just double zee(0.); since zero is units-independent.

cmsbuild · 2021-02-05T23:42:22Z

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-32823/21039

This PR adds an extra 44KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

code-format:
https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-32823/21039/code-format.patch
e.g. curl https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-32823/21039/code-format.patch | patch -p1
You can also run scram build code-format to apply code format directly

cmsbuild · 2021-02-05T23:50:04Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-32823/21041

This PR adds an extra 44KB to repository

cmsbuild · 2021-02-05T23:50:28Z

Pull request #32823 was updated. @civanch, @Dr15Jones, @makortel, @cvuosalo, @ianna, @mdhildreth, @cmsbuild can you please check and sign again.

bsunanda · 2021-02-06T00:20:43Z

@cmsbuild Please test

cmsbuild · 2021-02-06T06:42:22Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5283ff/12746/summary.html
COMMIT: c1dad1f
CMSSW: CMSSW_11_3_X_2021-02-05-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/32823/12746/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

No significant changes to the logs found
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 37
DQMHistoTests: Total histograms compared: 2751765
DQMHistoTests: Total failures: 1
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 2751742
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 36 files compared)
Checked 156 log files, 37 edm output root files, 37 DQM output files

civanch · 2021-02-06T16:48:27Z

+1

Carl comments are implemented

cmsbuild · 2021-02-06T16:48:50Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

qliphy · 2021-02-07T03:43:52Z

+1

Correct ECAL algorithms for dd4hep

343d28f

cmsbuild added this to the CMSSW_11_3_X milestone Feb 4, 2021

cmsbuild added code-checks-pending geometry-pending orp-pending pending-signatures tests-pending labels Feb 4, 2021

cmsbuild added code-checks-rejected and removed code-checks-pending labels Feb 4, 2021

Code check

94f53cf

cmsbuild added code-checks-pending and removed code-checks-rejected labels Feb 4, 2021

cmsbuild added code-checks-approved and removed code-checks-pending labels Feb 4, 2021

cmsbuild added tests-started and removed tests-pending labels Feb 4, 2021

cmsbuild added tests-approved and removed tests-started labels Feb 5, 2021

civanch reviewed Feb 5, 2021

View reviewed changes

Change 0 * dd4hep_mm to 0

2876df6

cmsbuild added code-checks-pending tests-pending and removed tests-approved labels Feb 5, 2021

cmsbuild added code-checks-rejected and removed code-checks-pending labels Feb 5, 2021

Code check

c1dad1f

cmsbuild added code-checks-pending and removed code-checks-rejected labels Feb 5, 2021

cmsbuild added code-checks-approved and removed code-checks-pending labels Feb 5, 2021

cmsbuild added tests-started and removed tests-pending labels Feb 6, 2021

cmsbuild added tests-approved and removed tests-started labels Feb 6, 2021

mrodozov mentioned this pull request Feb 6, 2021

[DD4hep] Update to latest commit v01-15x cms-sw/cmsdist#6612

Merged

cmsbuild added fully-signed geometry-approved and removed geometry-pending pending-signatures labels Feb 6, 2021

cmsbuild added orp-approved and removed orp-pending labels Feb 7, 2021

cmsbuild merged commit 075d640 into cms-sw:master Feb 7, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Run3-gex53 Correct ECAL algorithms for dd4hep #32823

Run3-gex53 Correct ECAL algorithms for dd4hep #32823

bsunanda commented Feb 4, 2021

cmsbuild commented Feb 4, 2021

cmsbuild commented Feb 4, 2021

cmsbuild commented Feb 4, 2021

bsunanda commented Feb 4, 2021

cmsbuild commented Feb 5, 2021

civanch Feb 5, 2021

bsunanda Feb 6, 2021

civanch Feb 5, 2021

bsunanda Feb 6, 2021

civanch commented Feb 5, 2021

civanch commented Feb 5, 2021

bsunanda commented Feb 5, 2021

cvuosalo commented Feb 5, 2021

cmsbuild commented Feb 5, 2021

cmsbuild commented Feb 5, 2021

cmsbuild commented Feb 5, 2021

bsunanda commented Feb 6, 2021

cmsbuild commented Feb 6, 2021

civanch commented Feb 6, 2021 •

edited

cmsbuild commented Feb 6, 2021

qliphy commented Feb 7, 2021

Run3-gex53 Correct ECAL algorithms for dd4hep #32823

Run3-gex53 Correct ECAL algorithms for dd4hep #32823

Conversation

bsunanda commented Feb 4, 2021

PR description:

PR validation:

if this PR is a backport please specify the original PR and why you need to backport that PR:

cmsbuild commented Feb 4, 2021

cmsbuild commented Feb 4, 2021

cmsbuild commented Feb 4, 2021

bsunanda commented Feb 4, 2021

cmsbuild commented Feb 5, 2021

Comparison Summary

civanch Feb 5, 2021

Choose a reason for hiding this comment

bsunanda Feb 6, 2021

Choose a reason for hiding this comment

civanch Feb 5, 2021

Choose a reason for hiding this comment

bsunanda Feb 6, 2021

Choose a reason for hiding this comment

civanch commented Feb 5, 2021

civanch commented Feb 5, 2021

bsunanda commented Feb 5, 2021

cvuosalo commented Feb 5, 2021

cmsbuild commented Feb 5, 2021

cmsbuild commented Feb 5, 2021

cmsbuild commented Feb 5, 2021

bsunanda commented Feb 6, 2021

cmsbuild commented Feb 6, 2021

Comparison Summary

civanch commented Feb 6, 2021 • edited

cmsbuild commented Feb 6, 2021

qliphy commented Feb 7, 2021

civanch commented Feb 6, 2021 •

edited