Remove include of MessageLogger.h from DataFormats headers

[Dr15Jones]

PR description:

None of the headers needed the include.

PR validation:

The code compiles.

[Dr15Jones]

FYI @davidlange6

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-32824/21016

• This PR adds an extra 52KB to repository

[cmsbuild]

A new Pull Request was created by @Dr15Jones (Chris Jones) for master.

It involves the following packages:

DataFormats/EgammaCandidates
DataFormats/HLTReco
DataFormats/Luminosity
DataFormats/PatCandidates
DataFormats/SiStripCluster
DataFormats/TauReco

@perrotta, @Martin-Grunewald, @slava77, @cmsbuild, @fwyzard, @jpata can you please review it and eventually sign? Thanks.
@echabert, @Sam-Harper, @sobhatta, @afiqaize, @jainshilpi, @pieterdavid, @robervalwalsh, @rovere, @VinInn, @makortel, @gouskos, @threus, @hatakeyamak, @gpetruc, @mmusich, @lgray, @alesaggio, @varuns23, @cbernet, @ram1123 this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[Dr15Jones]

please test

[cmsbuild]

-1

Failed Tests: Build HeaderConsistency ClangBuild
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-fb2ca0/12721/summary.html
COMMIT: 37fdb67
CMSSW: CMSSW_11_3_X_2021-02-04-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/32824/12721/install.sh to create a dev area with all the needed externals and cmssw changes.

Build

I found compilation error when building:

>> Compiling edm plugin /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_3_X_2021-02-04-1100/src/RecoLocalTracker/SiStripRecHitConverter/plugins/SealModules.cc
>> Compiling edm plugin /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_3_X_2021-02-04-1100/src/RecoLocalTracker/SiStripRecHitConverter/plugins/SiStripRecHitConverter.cc
>> Compiling edm plugin /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_3_X_2021-02-04-1100/src/RecoLocalTracker/SiStripRecHitConverter/plugins/SiStripRecHitMatcherESProducer.cc
>> Compiling edm plugin /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_3_X_2021-02-04-1100/src/RecoLocalTracker/SiStripRecHitConverter/plugins/StripCPEESProducer.cc
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_3_X_2021-02-04-1100/src/RecoLocalTracker/SiStripRecHitConverter/plugins/SiStripRecHitConverter.cc: In member function 'virtual void SiStripRecHitConverter::produce(edm::Event&, const edm::EventSetup&)':
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_3_X_2021-02-04-1100/src/RecoLocalTracker/SiStripRecHitConverter/plugins/SiStripRecHitConverter.cc:48:3: error: 'LogDebug' was not declared in this scope; did you mean 'gDebug'?
   48 |   LogDebug("SiStripRecHitConverter") << "found\n"
      |   ^~~~~~~~
      |   gDebug
gmake: *** [tmp/slc7_amd64_gcc900/src/RecoLocalTracker/SiStripRecHitConverter/plugins/RecoLocalTrackerSiStripRecHitConverterPlugins/SiStripRecHitConverter.cc.o] Error 1
>> Building  edm plugin tmp/slc7_amd64_gcc900/src/RecoLocalTracker/SiStripRecHitConverter/plugins/RecoLocalTrackerSiStripRecHitConverterPlugins/libRecoLocalTrackerSiStripRecHitConverterPlugins.so


Clang Build

I found compilation error while trying to compile with clang. Command used:

USER_CUDA_FLAGS='--expt-relaxed-constexpr' USER_CXXFLAGS='-Wno-register -fsyntax-only' scram build -k -j 32 COMPILER='llvm compile'

>> Compiling  /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_3_X_2021-02-04-1100/src/DataFormats/TauReco/src/PFTau3ProngSummary.cc
>> Compiling  /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_3_X_2021-02-04-1100/src/DataFormats/TauReco/src/PFTauDecayMode.cc
>> Compiling  /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_3_X_2021-02-04-1100/src/DataFormats/TauReco/src/PFTauTagInfo.cc
>> Compiling  /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_3_X_2021-02-04-1100/src/DataFormats/TauReco/src/RecoTauPiZero.cc
>> Compiling  /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_3_X_2021-02-04-1100/src/DataFormats/TauReco/src/PFTauTransverseImpactParameter.cc
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_3_X_2021-02-04-1100/src/DataFormats/TauReco/src/PFTauDecayMode.cc:95:14: error: no member named 'LogError' in namespace 'edm'
        edm::LogError("PFTauDecayMode")
        ~~~~~^
1 error generated.
gmake: *** [tmp/slc7_amd64_gcc900/src/DataFormats/TauReco/src/DataFormatsTauReco/PFTauDecayMode.cc.o] Error 1
>> Building LCG reflex dict from header file src/DataFormats/TauReco/src/classes_1.h


[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-32824/21026

• This PR adds an extra 52KB to repository

[cmsbuild]

Pull request #32824 was updated. @perrotta, @Martin-Grunewald, @slava77, @cmsbuild, @fwyzard, @jpata can you please check and sign again.

[Dr15Jones]

please test

[jfernan2]

+1
Changes in Tracking folder seem to be transient indeed

[Martin-Grunewald]

+1

[civanch]

+1

[srimanob]

+Upgrade

[tlampen]

+alca

[Dr15Jones]

ping @cms-sw/analysis-l2

[santocch]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[qliphy]

+1