Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reverse dependency #32826

Merged
merged 2 commits into from Feb 5, 2021
Merged

Reverse dependency #32826

merged 2 commits into from Feb 5, 2021

Conversation

lecriste
Copy link
Contributor

@lecriste lecriste commented Feb 4, 2021

PR description:

This PR addresses this comment from a previously merged PR.
It also introduces a file (AssociatorTools.h) that will contain methods shared by different associators.
No changes are expected in the output.

PR validation:

runTheMatrix -l limited

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 4, 2021

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-32826/21020

  • This PR adds an extra 28KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 4, 2021

A new Pull Request was created by @lecriste (Leonardo Cristella) for master.

It involves the following packages:

SimCalorimetry/HGCalAssociatorProducers
SimDataFormats/Associations
Validation/Configuration
Validation/HGCalValidation

@andrius-k, @kmaeshima, @ErnestaP, @ahmad3213, @cmsbuild, @srimanob, @jfernan2, @mdhildreth, @civanch, @kpedro88, @rvenditti can you please review it and eventually sign? Thanks.
@vandreev11, @sethzenz, @bsunanda, @rovere, @lgray, @cseez, @apsallid, @pfs, @hatakeyamak, @fabiocos this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@jfernan2
Copy link
Contributor

jfernan2 commented Feb 5, 2021

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 5, 2021

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-85087c/12727/summary.html
COMMIT: 7169675
CMSSW: CMSSW_11_3_X_2021-02-04-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/32826/12727/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 37
  • DQMHistoTests: Total histograms compared: 2751765
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2751742
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 36 files compared)
  • Checked 156 log files, 37 edm output root files, 37 DQM output files

@jfernan2
Copy link
Contributor

jfernan2 commented Feb 5, 2021

+1

@civanch
Copy link
Contributor

civanch commented Feb 5, 2021

+1

@srimanob
Copy link
Contributor

srimanob commented Feb 5, 2021

+Upgrade

No change is expected, technical PR to make a proper dependency.

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 5, 2021

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@qliphy
Copy link
Contributor

qliphy commented Feb 5, 2021

+1

@cmsbuild cmsbuild merged commit 65f6c2e into cms-sw:master Feb 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants