Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed backward propagator #32833

Merged
merged 3 commits into from Feb 7, 2021
Merged

Conversation

civanch
Copy link
Contributor

@civanch civanch commented Feb 5, 2021

PR description:

GeometryProducer is used in order to prepare Geant4 geometry for use in backward propagation. The code is updated in order to take into account possible use of DDD and potentially DD4Hep. This addresses #31920 .

Also CMSSteppingVerbosity is improved, code-check warnings in Notification sub-library are fixed.

These modifications do not affect any WF used in validation.

PR validation:

private

if this PR is a backport please specify the original PR and why you need to backport that PR:

May require backport to 11_2_0

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 5, 2021

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-32833/21031

  • This PR adds an extra 16KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 5, 2021

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-32833/21032

  • This PR adds an extra 24KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 5, 2021

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-32833/21035

  • This PR adds an extra 24KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 5, 2021

A new Pull Request was created by @civanch (Vladimir Ivantchenko) for master.

It involves the following packages:

SimG4Core/GeometryProducer
SimG4Core/Notification

@cmsbuild, @civanch, @mdhildreth can you please review it and eventually sign? Thanks.
@makortel, @rovere, @fabiocos, @slomeo this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@civanch
Copy link
Contributor Author

civanch commented Feb 5, 2021

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 6, 2021

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-39c20b/12744/summary.html
COMMIT: 000f1b8
CMSSW: CMSSW_11_3_X_2021-02-05-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/32833/12744/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 3 differences found in the comparisons
  • DQMHistoTests: Total files compared: 37
  • DQMHistoTests: Total histograms compared: 2751765
  • DQMHistoTests: Total failures: 6
  • DQMHistoTests: Total nulls: 1
  • DQMHistoTests: Total successes: 2751736
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.004 KiB( 36 files compared)
  • DQMHistoSizes: changed ( 312.0 ): 0.004 KiB MessageLogger/Warnings
  • Checked 156 log files, 37 edm output root files, 37 DQM output files

@civanch
Copy link
Contributor Author

civanch commented Feb 6, 2021

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 6, 2021

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@civanch
Copy link
Contributor Author

civanch commented Feb 6, 2021

Type bug-fix

@qliphy
Copy link
Contributor

qliphy commented Feb 7, 2021

+1

@cmsbuild cmsbuild merged commit cd6de6a into cms-sw:master Feb 7, 2021
mmusich pushed a commit to mmusich/cmssw that referenced this pull request Apr 29, 2022
bendavid pushed a commit to bendavid/cmssw that referenced this pull request Jun 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants