New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed backward propagator #32833
Fixed backward propagator #32833
Conversation
-code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-32833/21031
Code check has found code style and quality issues which could be resolved by applying following patch(s)
|
-code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-32833/21032
Code check has found code style and quality issues which could be resolved by applying following patch(s)
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-32833/21035
|
A new Pull Request was created by @civanch (Vladimir Ivantchenko) for master. It involves the following packages: SimG4Core/GeometryProducer @cmsbuild, @civanch, @mdhildreth can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-39c20b/12744/summary.html Comparison SummarySummary:
|
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
Type bug-fix |
+1 |
PR description:
GeometryProducer is used in order to prepare Geant4 geometry for use in backward propagation. The code is updated in order to take into account possible use of DDD and potentially DD4Hep. This addresses #31920 .
Also CMSSteppingVerbosity is improved, code-check warnings in Notification sub-library are fixed.
These modifications do not affect any WF used in validation.
PR validation:
private
if this PR is a backport please specify the original PR and why you need to backport that PR:
May require backport to 11_2_0