Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DD4hep] Disable DT Geometry Builder unit test that can't work with new DD4hep #32834

Merged
merged 2 commits into from Feb 7, 2021

Conversation

cvuosalo
Copy link
Contributor

@cvuosalo cvuosalo commented Feb 5, 2021

The new version of DD4hep uses the Geant4 units convention. The validateDTGeometry_cfg.py unit test in the Geometry/DTGeometryBuilder package compares a reference geometry that may have the ROOT units convention with the current geometry that has the Geant4 units convention. This comparison somehow triggers a ROOT exception complaining about changing the units convention. Discussion with the DD4hep developers indicates there is no easy fix. Rather than block the new version of DD4hep, it was decided to disable this unit test. In the future, we may figure out a way to fix it, but it doesn't seem to be essential.

PR validation:

With the changes in this PR, the Geometry/DTGeometryBuilder unit tests were run successfully in a special build with the new version of DD4hep.

No backport is needed.

@cmsbuild cmsbuild changed the base branch from CMSSW_11_3_X to master February 5, 2021 22:57
@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 5, 2021

@cvuosalo, CMSSW_11_3_X branch is closed for direct updates. cms-bot is going to move this PR to master branch.
In future, please use cmssw master branch to submit your changes.

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 5, 2021

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-32834/21037

  • This PR adds an extra 12KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 5, 2021

A new Pull Request was created by @cvuosalo (Carl Vuosalo) for master.

It involves the following packages:

Geometry/DTGeometryBuilder

@civanch, @Dr15Jones, @makortel, @cvuosalo, @ianna, @mdhildreth, @cmsbuild can you please review it and eventually sign? Thanks.
@fabiocos, @slomeo, @battibass this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@cvuosalo
Copy link
Contributor Author

cvuosalo commented Feb 5, 2021

type bug-fix

@mrodozov
Copy link
Contributor

mrodozov commented Feb 6, 2021

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 6, 2021

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5aefd3/12748/summary.html
COMMIT: 48b0966
CMSSW: CMSSW_11_3_X_2021-02-06-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/32834/12748/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 37
  • DQMHistoTests: Total histograms compared: 2751765
  • DQMHistoTests: Total failures: 7
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2751736
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 36 files compared)
  • Checked 156 log files, 37 edm output root files, 37 DQM output files

@civanch
Copy link
Contributor

civanch commented Feb 6, 2021

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 6, 2021

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@qliphy
Copy link
Contributor

qliphy commented Feb 7, 2021

+1

@cmsbuild cmsbuild merged commit 0b40466 into cms-sw:master Feb 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants