New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DD4hep] Disable DT Geometry Builder unit test that can't work with new DD4hep #32834
Conversation
@cvuosalo, CMSSW_11_3_X branch is closed for direct updates. cms-bot is going to move this PR to master branch. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-32834/21037
|
A new Pull Request was created by @cvuosalo (Carl Vuosalo) for master. It involves the following packages: Geometry/DTGeometryBuilder @civanch, @Dr15Jones, @makortel, @cvuosalo, @ianna, @mdhildreth, @cmsbuild can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
type bug-fix |
please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5aefd3/12748/summary.html Comparison SummarySummary:
|
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
The new version of DD4hep uses the Geant4 units convention. The
validateDTGeometry_cfg.py
unit test in theGeometry/DTGeometryBuilder
package compares a reference geometry that may have the ROOT units convention with the current geometry that has the Geant4 units convention. This comparison somehow triggers a ROOT exception complaining about changing the units convention. Discussion with the DD4hep developers indicates there is no easy fix. Rather than block the new version of DD4hep, it was decided to disable this unit test. In the future, we may figure out a way to fix it, but it doesn't seem to be essential.PR validation:
With the changes in this PR, the
Geometry/DTGeometryBuilder
unit tests were run successfully in a special build with the new version of DD4hep.No backport is needed.