Remove MessageLoggerHeader from SimDataFormats headers

[Dr15Jones]

PR description:

Removed the use of FWCore/MessageLogger/interface/MessageLogger.h from SimDataFormats headers. Only one of the headers actually used MessageLogger and for that one it was actually more consistent to throw an exception instead.

PR validation:

The code and all of its dependencies compile.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-32847/21061

• This PR adds an extra 40KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File SimCalorimetry/EcalTestBeam/src/EcalTBDigiProducer.cc modified in PR(s): Migrate most of MixingModule and PreMixingModule to EventSetup consumes #31697

[cmsbuild]

A new Pull Request was created by @Dr15Jones (Chris Jones) for master.

It involves the following packages:

PhysicsTools/HepMCCandAlgos
SimCalorimetry/EcalSimAlgos
SimCalorimetry/EcalTestBeam
SimDataFormats/CaloTest
SimDataFormats/CrossingFrame
SimDataFormats/SimHitMaker
SimG4CMS/Calo
SimGeneral/PileupInformation

@cmsbuild, @civanch, @santocch, @mdhildreth can you please review it and eventually sign? Thanks.
@thomreis, @apsallid, @makortel, @rovere, @argiro, @rchatter, @lecriste, @fabiocos, @slomeo this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[Dr15Jones]

please test

[cmsbuild]

-1

Failed Tests: Build
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f8497e/12768/summary.html
COMMIT: 5465d63
CMSSW: CMSSW_11_3_X_2021-02-08-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/32847/12768/install.sh to create a dev area with all the needed externals and cmssw changes.

Build

I found compilation error when building:

>> Compiling  /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_3_X_2021-02-08-1100/src/SimMuon/GEMDigitizer/src/ME0PreRecoGaussianModel.cc
>> Compiling  /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_3_X_2021-02-08-1100/src/SimMuon/GEMDigitizer/src/ME0PreRecoNoSmearModel.cc
>> Compiling  /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_3_X_2021-02-08-1100/src/SimMuon/GEMDigitizer/src/ME0SimpleModel.cc
>> Compiling  /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_3_X_2021-02-08-1100/src/SimMuon/GEMDigitizer/src/SealModule.cc
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_3_X_2021-02-08-1100/src/SimMuon/GEMDigitizer/src/ME0SimpleModel.cc: In member function 'int ME0SimpleModel::getSimHitBx(const PSimHit*, CLHEP::HepRandomEngine*)':
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_3_X_2021-02-08-1100/src/SimMuon/GEMDigitizer/src/ME0SimpleModel.cc:135:5: error: 'LogDebug' was not declared in this scope; did you mean 'gDebug'?
  135 |     LogDebug("ME0SimpleModel") << "checktime "
      |     ^~~~~~~~
      |     gDebug
gmake: *** [tmp/slc7_amd64_gcc900/src/SimMuon/GEMDigitizer/src/SimMuonGEMDigitizer/ME0SimpleModel.cc.o] Error 1
>> Building  shared library tmp/slc7_amd64_gcc900/src/SimMuon/GEMDigitizer/src/SimMuonGEMDigitizer/libSimMuonGEMDigitizer.so


[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-32847/21080

• This PR adds an extra 48KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File SimCalorimetry/EcalTestBeam/src/EcalTBDigiProducer.cc modified in PR(s): Migrate most of MixingModule and PreMixingModule to EventSetup consumes #31697

[cmsbuild]

Pull request #32847 was updated. @civanch, @kpedro88, @cmsbuild, @srimanob, @mdhildreth, @santocch can you please check and sign again.

[Dr15Jones]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f8497e/12802/summary.html
COMMIT: 35640b1
CMSSW: CMSSW_11_3_X_2021-02-09-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/32847/12802/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 37
• DQMHistoTests: Total histograms compared: 2751765
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2751742
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 36 files compared)
• Checked 156 log files, 37 edm output root files, 37 DQM output files

[civanch]

+1

[Dr15Jones]

@cms-sw/analysis-l2 @cms-sw/upgrade-l2

[srimanob]

+Upgrade

[santocch]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[qliphy]

+1