fix lostTracks producer not setting lostInnerHits

[elusian]

PR description:

The lostTracks producer has a bug that leaves the lostInnerHits of the PackedCandidate unset (and thus at its default value of validHitInFirstPixelBarrelLayer). Other than in lostInnerHits the bug propagates in the number of valid pixel hits and the number of pixel and tracker layers with measurements in the HitPattern of the bestTrack of the candidate.

As agreed with xPOG and TAU POG ( @mariadalfonso , @gouskos , @mbluj ), this PR fixes the bug by adding the call to setLostInnerHits as the code from the packedPFCandidates producer does. This fix has been checked running the workflow 136.8311 and the issue was solved (see attached figures in the PR on master).

PR validation:

This PR has been validated with runTheMatrix.py -l limited -i all --ibeos and all checks are ok.
The final output is
35 34 33 25 16 4 1 1 1 tests passed, 0 0 0 0 0 0 0 0 0 failed
In particular the DQM output of 136.8311 shows the differences which are expected: inside Tracking/PackedCandidate/lostTracks, in diffLostInnerHits, diffHitPatternNumberOfLostPixelHits, diffHitPatternHasValidHitInFirstPixelBarrel, diffHitPatternNumberOfValidPixelHits, diffHitPatternPixelLayersWithMeasurement, diffHitPatternTrackerLayersWithMeasurement, see the attached plots in the PR on master

if this PR is a backport please specify the original PR and why you need to backport that PR:

This PR is a backport of #32814, needed for the reminiAOD for HeavyIon.

[cmsbuild]

A new Pull Request was created by @elusian for CMSSW_11_2_X.

It involves the following packages:

PhysicsTools/PatAlgos

@perrotta, @jpata, @cmsbuild, @slava77 can you please review it and eventually sign? Thanks.
@emilbols, @gouskos, @jdolen, @JyothsnaKomaragiri, @ahinzmann, @smoortga, @schoef, @rappoccio, @swozniewski, @jdamgov, @mbluj, @nhanvtran, @gkasieczka, @clelange, @hatakeyamak, @ferencek, @gpetruc, @andrzejnovak, @mariadalfonso, @seemasharmafnal, @mmarionncern this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[mariadalfonso]

@elusian
can you make the PR ready; now it's draft;

[elusian]

I was trying to actually add the plots that I mentioned, but I still cannot

[mariadalfonso]

please test

[mariadalfonso]

I was trying to actually add the plots that I mentioned, but I still cannot

are in the master PR. no need to re-add them

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-dd6896/12799/summary.html
COMMIT: 8fb2fb4
CMSSW: CMSSW_11_2_X_2021-02-09-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/32853/12799/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 80 differences found in the comparisons
• DQMHistoTests: Total files compared: 36
• DQMHistoTests: Total histograms compared: 2528845
• DQMHistoTests: Total failures: 112
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2528711
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 35 files compared)
• Checked 151 log files, 37 edm output root files, 36 DQM output files

[mariadalfonso]

type bugfix

[jpata]

+reconstruction

• bugfix
• identical backport of Fix lostTracks producer not setting lostInnerHits #32814, needed for the reminiAOD for HeavyIon
• reco changes only observed in qualityFlags & status

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_11_2_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_11_3_X is complete. This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[qliphy]

+1