Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PUID UL18 backport #32872

Merged
merged 4 commits into from Feb 14, 2021
Merged

PUID UL18 backport #32872

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
4bd90ca
PUID UL18 backport
singh-ramanpreet Feb 10, 2021
45501d8
PUID: following PR comments, do not change default run2 mini UL
singh-ramanpreet Feb 11, 2021
e8c384a
PUID: (part 2) following PR comments, do not change default run2 mini UL
singh-ramanpreet Feb 11, 2021
bc2beb8
Update RecoJets/JetProducers/python/PileupJetID_cfi.py
singh-ramanpreet Feb 11, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
5 changes: 5 additions & 0 deletions RecoJets/JetProducers/python/PileupJetIDCutParams_cfi.py
View file
Open in desktop
Expand Up @@ -67,6 +67,11 @@
Pt4050_Loose = cms.vdouble(-0.19, 0.22, -0.13, -0.03)
)

##########################################################
## Working points for the 106X UL18 training
###########################################################
full_106x_UL18_chs_wp = full_106x_UL17_chs_wp.clone()

###########################################################
## Working points for the 80X training
###########################################################
Expand Down
5 changes: 5 additions & 0 deletions RecoJets/JetProducers/python/PileupJetIDParams_cfi.py
View file
Open in desktop
Expand Up @@ -163,6 +163,11 @@
full_106x_UL17_chs.trainings[3].tmvaWeights = "RecoJets/JetProducers/data/pileupJetId_UL17_Eta3p0To5p0_chs_BDT.weights.xml.gz"
full_106x_UL17_chs.trainings[3].tmvaVariables = trainingVariables_106X_Eta3To5

####################################################################################################################
full_106x_UL18_chs = full_106x_UL17_chs.clone(JetIdParams = full_106x_UL18_chs_wp)
for train in full_106x_UL18_chs.trainings:
train.tmvaWeights = train.tmvaWeights.value().replace("UL17", "UL18")

####################################################################################################################
full_80x_chs = cms.PSet(
impactParTkThreshold = cms.double(1.),
Expand Down
5 changes: 4 additions & 1 deletion RecoJets/JetProducers/python/PileupJetID_cfi.py
View file
Open in desktop
@@ -1,5 +1,6 @@
import FWCore.ParameterSet.Config as cms
from Configuration.ProcessModifiers.run2_miniAOD_UL_cff import run2_miniAOD_UL
singh-ramanpreet marked this conversation as resolved.
Show resolved Hide resolved
from Configuration.Eras.Modifier_run2_jme_2017_cff import run2_jme_2017
from RecoJets.JetProducers.PileupJetIDParams_cfi import *

#_stdalgos_4x = cms.VPSet(full, cutbased,PhilV1)
Expand All @@ -14,6 +15,7 @@
_chsalgos_94x = cms.VPSet(full_94x_chs,cutbased)
_chsalgos_102x = cms.VPSet(full_102x_chs,cutbased)
_chsalgos_106X_UL17 = cms.VPSet(full_106x_UL17_chs,cutbased)
_chsalgos_106X_UL18 = cms.VPSet(full_106x_UL18_chs,cutbased)

_stdalgos = _chsalgos_81x

Expand All @@ -33,7 +35,8 @@
usePuppi = cms.bool(False),
# residualsTxt = cms.FileInPath("RecoJets/JetProducers/data/download.url") # must be an existing file
)
run2_miniAOD_UL.toModify(pileupJetId, algos = _chsalgos_106X_UL17)
run2_miniAOD_UL.toModify(pileupJetId, algos = _chsalgos_106X_UL18)
(run2_miniAOD_UL & run2_jme_2017).toModify(pileupJetId, algos = _chsalgos_106X_UL17)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
run2_miniAOD_UL.toModify(pileupJetId, algos = _chsalgos_106X_UL18)
(run2_miniAOD_UL & run2_jme_2017).toModify(pileupJetId, algos = _chsalgos_106X_UL17)
run2_miniAOD_UL.toModify(pileupJetId, algos = _chsalgos_106X_UL17)
(run2_miniAOD_devel & run2_jme_2018).toModify(pileupJetId, algos = _chsalgos_106X_UL18)

is what I understood is needed

  • the first line reverts back to the current default of the PR
  • the second enables the 2018 PU ID for the 2018 "devel" re-miniAOD

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there is no run2_jme_2018_cff, did you mean run2_miniAOD_devel.toModify(pileupJetId, algos = _chsalgos_106X_UL18) for second line?

Copy link
Contributor

@slava77 slava77 Feb 11, 2021 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

my expectation is that my proposed change above when used with --era Run2_2018,run2_miniAOD_devel --procModifiers run2_miniAOD_UL will give an updated UL re-mini with the 2018 PU ID for the 2018 era/setup. (to compare with the production default --era Run2_2018 --procModifiers run2_miniAOD_UL which is locked to use PU ID 2017 by the no-change policy due to the 2018 campaign being already in progress)

Copy link
Contributor

@slava77 slava77 Feb 11, 2021 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there is no run2_jme_2018_cff, did you mean run2_miniAOD_devel.toModify(pileupJetId, algos = _chsalgos_106X_UL18) for second line?

Ehm, it may be better that run2_jme_2018 actually existed.
Otherwise, the last line would have (run2_miniAOD_devel & (~run2_jme_2016) & (~run2_jme_2017)).


# Calculate variables, but don't run MVAs
pileupJetIdCalculator = pileupJetId.clone(
Expand Down