PUID UL18 for nanoAOD #32887

alefisico · 2021-02-12T10:06:49Z

PR description:

This PR implements the new PUID UL18 trainings Pileup Id training for UL18 #32418 for nanoAOD.
It is targeting to be used in nanoAODv9

PR validation:

Passes all the runTheMatrix.py -l limited -i all --ibeos tests.

FYI: @camclean @mariadalfonso @gouskos

cmsbuild · 2021-02-12T10:11:30Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-32887/21118

This PR adds an extra 20KB to repository

cmsbuild · 2021-02-12T10:11:52Z

A new Pull Request was created by @alefisico (Alejandro Gomez Espinosa) for master.

It involves the following packages:

PhysicsTools/NanoAOD

@cmsbuild, @mariadalfonso, @gouskos, @fgolf can you please review it and eventually sign? Thanks.
@gpetruc, @peruzzim, @swertz this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

gouskos · 2021-02-12T11:22:31Z

please test

cmsbuild · 2021-02-12T13:54:56Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2feac4/12855/summary.html
COMMIT: 6b886c7
CMSSW: CMSSW_11_3_X_2021-02-11-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/32887/12855/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

@slava77 comparisons for the following workflows were not done due to missing matrix map:

/data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-2feac4/11634.911_TTbar_14TeV+2021_DD4hep+TTbar_14TeV_TuneCP5_GenSim+Digi+Reco+HARVEST+ALCA

Summary:

No significant changes to the logs found
Reco comparison results: 3 differences found in the comparisons
DQMHistoTests: Total files compared: 37
DQMHistoTests: Total histograms compared: 2750846
DQMHistoTests: Total failures: 1
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 2750823
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 36 files compared)
Checked 156 log files, 37 edm output root files, 37 DQM output files

mariadalfonso · 2021-02-15T14:49:43Z

PhysicsTools/NanoAOD/python/jets_cff.py

+for modifier in run2_miniAOD_80XLegacy, run2_nanoAOD_94X2016, run2_nanoAOD_94XMiniAODv1, run2_nanoAOD_94XMiniAODv2, run2_nanoAOD_102Xv1:
+    modifier.toModify( jetTable.variables, puId = Var("userInt('pileupJetId:fullId')",int,doc="Pileup ID flags for pre-UL trainings") )


delete this
no reason to retouch the run2_miniAOD_80XLegacy, run2_nanoAOD_94X2016, run2_nanoAOD_94XMiniAODv1, run2_nanoAOD_94XMiniAODv2

sure.
I was thinking that it might be needed for old versions to keep the old pileupjetid, but I'll erase it.

mariadalfonso · 2021-02-15T14:50:55Z

PhysicsTools/NanoAOD/python/jets_cff.py

@@ -265,12 +267,15 @@
    )
 for modifier in run2_miniAOD_80XLegacy, run2_nanoAOD_94X2016:
    modifier.toModify( jetTable.variables, jetId = Var("userInt('tightIdLepVeto')*4+userInt('tightId')*2+userInt('looseId')",int,doc="Jet ID flags bit1 is loose, bit2 is tight, bit3 is tightLepVeto"))
+run2_nanoAOD_102Xv1.toModify( jetTable.variables, puIdDisc = Var("userFloat('puId102XDisc')",float,doc="Pileup ID discriminant with 102X (2018) training",precision=10) )


you can have

run2_nanoAOD_102Xv1.toModify( jetTable.variables, puIdDisc = Var("userFloat('puId102XDisc')",float,doc="Pileup ID discriminant with 102X (2018) training",precision=10) ) run2_nanoAOD_102Xv1.toModify( jetTable.variables, puId = Var("userInt('pileupJetId:fullId')",int,doc="Pileup ID flags for pre-UL trainings") )

mariadalfonso · 2021-02-15T14:57:51Z

PhysicsTools/NanoAOD/python/jets_cff.py

@@ -265,12 +267,15 @@
    )
 for modifier in run2_miniAOD_80XLegacy, run2_nanoAOD_94X2016:
    modifier.toModify( jetTable.variables, jetId = Var("userInt('tightIdLepVeto')*4+userInt('tightId')*2+userInt('looseId')",int,doc="Jet ID flags bit1 is loose, bit2 is tight, bit3 is tightLepVeto"))
+run2_nanoAOD_102Xv1.toModify( jetTable.variables, puIdDisc = Var("userFloat('puId102XDisc')",float,doc="Pileup ID discriminant with 102X (2018) training",precision=10) )
 run2_jme_2016.toModify( jetTable.variables, puIdDisc = Var("userFloat('pileupJetId:fullDiscriminant')",float,doc="Pileup ID discriminant with 80X (2016) training",precision=10))


before the PR , the UL-2016 took the puId was pileupJetId:fullId while now you changed into puId106XUL18Id
confirmed by the changes in the DQM plots.

add here
run2_jme_2016.toModify( jetTable.variables, puId = Var("userInt('pileupJetId:fullId')",int,doc="Pileup ID flags for pre-UL trainings"))

so that no changes appear here and we will change when the UL16 is available

cmsbuild · 2021-02-16T09:01:18Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-32887/21149

This PR adds an extra 20KB to repository

cmsbuild · 2021-02-16T09:01:45Z

Pull request #32887 was updated. @cmsbuild, @mariadalfonso, @gouskos, @fgolf can you please check and sign again.

mariadalfonso · 2021-02-16T09:04:12Z

please test

cmsbuild · 2021-02-16T11:34:53Z

-1

Failed Tests: RelVals-INPUT
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2feac4/12912/summary.html
COMMIT: 3ea59a5
CMSSW: CMSSW_11_3_X_2021-02-15-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/32887/12912/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals-INPUT

4.764.76_ZMuSkim2012D+ZMuSkim2012D+HLTDSKIM2+RECODR1reHLT2+HARVESTDR1reHLT/step2_ZMuSkim2012D+ZMuSkim2012D+HLTDSKIM2+RECODR1reHLT2+HARVESTDR1reHLT.log

Comparison Summary

@slava77 comparisons for the following workflows were not done due to missing matrix map:

/build/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-2feac4/11634.911_TTbar_14TeV+2021_DD4hep+TTbar_14TeV_TuneCP5_GenSim+Digi+Reco+HARVEST+ALCA

Summary:

No significant changes to the logs found
Reco comparison results: 6 differences found in the comparisons
DQMHistoTests: Total files compared: 37
DQMHistoTests: Total histograms compared: 2750846
DQMHistoTests: Total failures: 15
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 2750809
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 36 files compared)
Checked 156 log files, 37 edm output root files, 37 DQM output files

alefisico · 2021-02-16T13:32:21Z

The error in the test is related to the opening of the file:

Exception Message:
Failed to open the file 'root://cms-xrd-global.cern.ch//store/data/Run2012D/SingleMu/RAW-RECO/ZMu-15Apr2014-v1/00000/007A3BD1-02CD-E311-853B-002590D0AFC8.root'

smuzaffar · 2021-02-16T13:35:28Z

ignore this error, this has been fixed

mariadalfonso · 2021-02-16T14:42:20Z

please test

cmsbuild · 2021-02-16T17:46:00Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2feac4/12925/summary.html
COMMIT: 3ea59a5
CMSSW: CMSSW_11_3_X_2021-02-16-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/32887/12925/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

@slava77 comparisons for the following workflows were not done due to missing matrix map:

/data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-2feac4/11634.911_TTbar_14TeV+2021_DD4hep+TTbar_14TeV_TuneCP5_GenSim+Digi+Reco+HARVEST+ALCA

Summary:

No significant changes to the logs found
Reco comparison results: 11 differences found in the comparisons
DQMHistoTests: Total files compared: 37
DQMHistoTests: Total histograms compared: 2750846
DQMHistoTests: Total failures: 14
DQMHistoTests: Total nulls: 1
DQMHistoTests: Total successes: 2750809
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: -0.004 KiB( 36 files compared)
DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
Checked 156 log files, 37 edm output root files, 37 DQM output files

mariadalfonso · 2021-02-19T12:17:01Z

+xpog
changes in the PUvariable for AK4 jets for UL18 only as expected

cmsbuild · 2021-02-19T12:17:28Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

qliphy · 2021-02-19T12:24:00Z

+1

mariadalfonso · 2021-02-25T10:06:04Z

@alefisico
can we have a backport in 11_2 (should be identical to master)

alefisico added 2 commits February 11, 2021 19:10

adding PUID UL18

a21ab25

adding PUID UL18 nanoAOD

6b886c7

cmsbuild added this to the CMSSW_11_3_X milestone Feb 12, 2021

cmsbuild added code-checks-pending orp-pending pending-signatures tests-pending xpog-pending labels Feb 12, 2021

cmsbuild added code-checks-approved and removed code-checks-pending labels Feb 12, 2021

cmsbuild added tests-started and removed tests-pending labels Feb 12, 2021

cmsbuild added tests-approved and removed tests-started labels Feb 12, 2021

mariadalfonso mentioned this pull request Feb 15, 2021

features for V9 nanoAOD cms-nanoAOD/cmssw#555

Closed

55 tasks

mariadalfonso reviewed Feb 15, 2021

View reviewed changes

fix PUID UL2018

3ea59a5

cmsbuild added code-checks-pending tests-pending and removed code-checks-approved tests-approved labels Feb 16, 2021

cmsbuild added code-checks-approved and removed code-checks-pending labels Feb 16, 2021

cmsbuild added tests-started and removed tests-pending labels Feb 16, 2021

cmsbuild added tests-rejected and removed tests-started labels Feb 16, 2021

cmsbuild added tests-started and removed tests-rejected labels Feb 16, 2021

cmsbuild added tests-approved and removed tests-started labels Feb 16, 2021

cmsbuild mentioned this pull request Feb 16, 2021

Add nConstituents to fat jets. #32927

Merged

cmsbuild added fully-signed xpog-approved and removed pending-signatures xpog-pending labels Feb 19, 2021

cmsbuild added orp-approved and removed orp-pending labels Feb 19, 2021

cmsbuild merged commit 06ca18d into cms-sw:master Feb 19, 2021

alefisico mentioned this pull request Feb 19, 2021

PUID UL18 for nanoAOD (backport) #32951

Merged

alefisico mentioned this pull request Feb 25, 2021

PUID UL18 for nanoAOD (backport to 11_2) #32995

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

PUID UL18 for nanoAOD #32887

PUID UL18 for nanoAOD #32887

alefisico commented Feb 12, 2021

cmsbuild commented Feb 12, 2021

cmsbuild commented Feb 12, 2021

gouskos commented Feb 12, 2021

cmsbuild commented Feb 12, 2021

mariadalfonso Feb 15, 2021

alefisico Feb 15, 2021

mariadalfonso Feb 15, 2021

mariadalfonso Feb 15, 2021

cmsbuild commented Feb 16, 2021

cmsbuild commented Feb 16, 2021

mariadalfonso commented Feb 16, 2021

cmsbuild commented Feb 16, 2021

alefisico commented Feb 16, 2021

smuzaffar commented Feb 16, 2021

mariadalfonso commented Feb 16, 2021

cmsbuild commented Feb 16, 2021

mariadalfonso commented Feb 19, 2021

cmsbuild commented Feb 19, 2021

qliphy commented Feb 19, 2021

mariadalfonso commented Feb 25, 2021

		for modifier in run2_miniAOD_80XLegacy, run2_nanoAOD_94X2016, run2_nanoAOD_94XMiniAODv1, run2_nanoAOD_94XMiniAODv2, run2_nanoAOD_102Xv1:
		modifier.toModify( jetTable.variables, puId = Var("userInt('pileupJetId:fullId')",int,doc="Pileup ID flags for pre-UL trainings") )

PUID UL18 for nanoAOD #32887

PUID UL18 for nanoAOD #32887

Conversation

alefisico commented Feb 12, 2021

PR description:

PR validation:

cmsbuild commented Feb 12, 2021

cmsbuild commented Feb 12, 2021

gouskos commented Feb 12, 2021

cmsbuild commented Feb 12, 2021

Comparison Summary

mariadalfonso Feb 15, 2021

Choose a reason for hiding this comment

alefisico Feb 15, 2021

Choose a reason for hiding this comment

mariadalfonso Feb 15, 2021

Choose a reason for hiding this comment

mariadalfonso Feb 15, 2021

Choose a reason for hiding this comment

cmsbuild commented Feb 16, 2021

cmsbuild commented Feb 16, 2021

mariadalfonso commented Feb 16, 2021

cmsbuild commented Feb 16, 2021

RelVals-INPUT

Comparison Summary

alefisico commented Feb 16, 2021

smuzaffar commented Feb 16, 2021

mariadalfonso commented Feb 16, 2021

cmsbuild commented Feb 16, 2021

Comparison Summary

mariadalfonso commented Feb 19, 2021

cmsbuild commented Feb 19, 2021

qliphy commented Feb 19, 2021

mariadalfonso commented Feb 25, 2021