Change ROOT::TF1 class def version from 10 to 12* #32890

mrodozov · 2021-02-12T12:07:37Z

PR description:

ROOT has changed their class version for TF1 in master from 10 to 11 in :
root-project/root#7035
I've requested a backport for the change to 6-22 root-project/root#7193
so we can have them consistent and
cms-sw/cmsdist#6631 integrated
Note that there is another such class version change in the same PR for TFormula from 12 to 13
and please let me know if anything else follows from the proposed changes (like should we change TFormula version somewhere)

in the meanwhile root updated TF1 to version 12 (in master)
root-project/root#7274

PR validation:

the test testSchemaEvolution is running

Resolves: #33053

ROOT has changed their class version for TF1 changed in master from 10 to 11 in : root-project/root#7035 I've requested a backport for the change to 6-22 root-project/root#7193 so we can have them consistent and have cms-sw/cmsdist#6631 integrated Note that there is another such class version change in the same PR for TFormula from 12 to 13 and please let me know if anything else follows from the proposed changes (like should we change TFormula version somewhere)

cmsbuild · 2021-02-12T12:13:06Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-32890/21121

This PR adds an extra 12KB to repository

cmsbuild · 2021-02-12T12:13:30Z

A new Pull Request was created by @mrodozov (Mircho Rodozov) for master.

It involves the following packages:

DQMServices/Components

@andrius-k, @kmaeshima, @ErnestaP, @ahmad3213, @cmsbuild, @jfernan2, @rvenditti can you please review it and eventually sign? Thanks.
@barvic this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

jfernan2 · 2021-02-12T12:24:45Z

please test

mrodozov · 2021-02-12T13:14:12Z

abort
this needs an external change from ROOT, just a sec to make it

mrodozov · 2021-02-12T13:31:20Z

please test with cms-sw/cmsdist#6644

mrodozov · 2021-02-12T23:29:39Z

please test with cms-sw/cmsdist#6644

cmsbuild · 2021-02-13T15:09:14Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a1786b/12872/summary.html
COMMIT: 948d5a3
CMSSW: CMSSW_11_3_X_2021-02-12-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/32890/12872/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

@slava77 comparisons for the following workflows were not done due to missing matrix map:

/data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-a1786b/11634.911_TTbar_14TeV+2021_DD4hep+TTbar_14TeV_TuneCP5_GenSim+Digi+Reco+HARVEST+ALCA

Summary:

You potentially added 8146070 lines to the logs
Reco comparison results: 11 differences found in the comparisons
DQMHistoTests: Total files compared: 37
DQMHistoTests: Total histograms compared: 2750846
DQMHistoTests: Total failures: 12
DQMHistoTests: Total nulls: 1
DQMHistoTests: Total successes: 2750811
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.004 KiB( 36 files compared)
DQMHistoSizes: changed ( 312.0 ): 0.004 KiB MessageLogger/Warnings
Checked 156 log files, 37 edm output root files, 37 DQM output files

jfernan2 · 2021-02-13T16:03:35Z

+1

cmsbuild · 2021-03-02T08:26:06Z

-1

Failed Tests: RelVals-INPUT
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a1786b/13180/summary.html
COMMIT: a4d4a41
CMSSW: CMSSW_11_3_X_2021-03-01-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/32890/13180/install.sh to create a dev area with all the needed externals and cmssw changes.

DAS Queries: The DAS query tests failed, see the summary page for details.

RelVals-INPUT

11725.0DAS Error
11925.0DAS Error

Comparison Summary

Summary:

No significant changes to the logs found
Reco comparison results: 4 differences found in the comparisons
DQMHistoTests: Total files compared: 37
DQMHistoTests: Total histograms compared: 2750983
DQMHistoTests: Total failures: 8
DQMHistoTests: Total nulls: 1
DQMHistoTests: Total successes: 2750952
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: -0.004 KiB( 36 files compared)
DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
Checked 156 log files, 37 edm output root files, 37 DQM output files

jfernan2 · 2021-03-03T15:17:04Z

+1
Apart from DAS errors

cmsbuild · 2021-03-03T15:17:30Z

This pull request is fully signed and it will be integrated in one of the next master IBs (but tests are reportedly failing). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

silviodonato · 2021-03-03T17:40:38Z

please test
@mrodozov could you confirm that we can merge this PR?

silviodonato · 2021-03-03T17:59:29Z

(cms-sw/cmsdist#6644 has been closed)

mrodozov · 2021-03-03T20:16:47Z

please test with cms-sw/cmsdist#6696

mrodozov · 2021-03-03T20:17:44Z

not , there are three tests failing (apart from the schema evolution test)

mrodozov · 2021-03-03T20:47:27Z

the unit tests are failing in the IB and on is te schemaEvolution but there are some reco diffs to check.

cmsbuild · 2021-03-04T09:50:30Z

-1

Failed Tests: UnitTests
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a1786b/13252/summary.html
COMMIT: a4d4a41
CMSSW: CMSSW_11_3_X_2021-03-03-1500/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/32890/13252/install.sh to create a dev area with all the needed externals and cmssw changes.

Unit Tests

I found errors in the following unit tests:

---> test testSSTGainPCL_fromRECO had ERRORS
---> test TestConfigDP had ERRORS
---> test checkMultiRunHarvestingOutput had ERRORS

Comparison Summary

Summary:

No significant changes to the logs found
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 37
DQMHistoTests: Total histograms compared: 2750983
DQMHistoTests: Total failures: 1
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 2750960
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 36 files compared)
Checked 156 log files, 37 edm output root files, 37 DQM output files

smuzaffar · 2021-03-05T08:26:13Z

@silviodonato , @qliphy feel free to merge this and cms-sw/cmsdist#6696 once 11.3.0.pre4 is out

silviodonato · 2021-03-05T10:50:31Z

merge
(the errors are already in the IB)

cmsbuild added this to the CMSSW_11_3_X milestone Feb 12, 2021

cmsbuild added code-checks-pending dqm-pending orp-pending pending-signatures tests-pending labels Feb 12, 2021

cmsbuild added code-checks-approved and removed code-checks-pending labels Feb 12, 2021

cmsbuild added tests-started and removed tests-pending labels Feb 12, 2021

cmsbuild added tests-pending and removed tests-started labels Feb 12, 2021

cmsbuild added requires-external tests-started and removed tests-pending labels Feb 12, 2021

cmsbuild added tests-approved and removed tests-started labels Feb 13, 2021

cmsbuild added dqm-approved fully-signed and removed dqm-pending pending-signatures labels Feb 13, 2021

mrodozov changed the title ~~Change ROOT::TF1 class def version from 10 to 11~~ Change ROOT::TF1 class def version from 10 to 12* Mar 1, 2021

cmsbuild added tests-rejected and removed tests-started labels Mar 2, 2021

mrodozov mentioned this pull request Mar 3, 2021

Adjust DQM code for new ClassDef version in TF1 and TFormula #33053

Closed

cmsbuild added dqm-approved fully-signed and removed dqm-pending pending-signatures labels Mar 3, 2021

cmsbuild added tests-started and removed requires-external tests-rejected labels Mar 3, 2021

cmsbuild added the requires-external label Mar 3, 2021

This was referenced Mar 3, 2021

Updated root to tip of 6-22 - cmsdist master cms-sw/cmsdist#6696

Merged

Updated root to tip of 6-22 - rootnext cms-sw/cmsdist#6697

Merged

cmsbuild added tests-rejected and removed tests-started labels Mar 4, 2021

cmsbuild added orp-approved and removed orp-pending labels Mar 5, 2021

cmsbuild merged commit 2e9911d into cms-sw:master Mar 5, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Change ROOT::TF1 class def version from 10 to 12* #32890

Change ROOT::TF1 class def version from 10 to 12* #32890

mrodozov commented Feb 12, 2021 •

edited

cmsbuild commented Feb 12, 2021

cmsbuild commented Feb 12, 2021

jfernan2 commented Feb 12, 2021

mrodozov commented Feb 12, 2021

mrodozov commented Feb 12, 2021

mrodozov commented Feb 12, 2021

cmsbuild commented Feb 13, 2021

jfernan2 commented Feb 13, 2021

cmsbuild commented Mar 2, 2021

jfernan2 commented Mar 3, 2021

cmsbuild commented Mar 3, 2021

silviodonato commented Mar 3, 2021

silviodonato commented Mar 3, 2021

mrodozov commented Mar 3, 2021

mrodozov commented Mar 3, 2021

mrodozov commented Mar 3, 2021 •

edited

cmsbuild commented Mar 4, 2021

smuzaffar commented Mar 5, 2021

silviodonato commented Mar 5, 2021

Change ROOT::TF1 class def version from 10 to 12* #32890

Change ROOT::TF1 class def version from 10 to 12* #32890

Conversation

mrodozov commented Feb 12, 2021 • edited

PR description:

PR validation:

cmsbuild commented Feb 12, 2021

cmsbuild commented Feb 12, 2021

jfernan2 commented Feb 12, 2021

mrodozov commented Feb 12, 2021

mrodozov commented Feb 12, 2021

mrodozov commented Feb 12, 2021

cmsbuild commented Feb 13, 2021

Comparison Summary

jfernan2 commented Feb 13, 2021

cmsbuild commented Mar 2, 2021

RelVals-INPUT

Comparison Summary

jfernan2 commented Mar 3, 2021

cmsbuild commented Mar 3, 2021

silviodonato commented Mar 3, 2021

silviodonato commented Mar 3, 2021

mrodozov commented Mar 3, 2021

mrodozov commented Mar 3, 2021

mrodozov commented Mar 3, 2021 • edited

cmsbuild commented Mar 4, 2021

Unit Tests

Comparison Summary

smuzaffar commented Mar 5, 2021

silviodonato commented Mar 5, 2021

mrodozov commented Feb 12, 2021 •

edited

mrodozov commented Mar 3, 2021 •

edited