Adding HGCAL SuperCluster Regressions #32901
Conversation
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-32901/21129
|
|
A new Pull Request was created by @Sam-Harper (Sam Harper) for master. It involves the following packages: Configuration/AlCa @perrotta, @smuzaffar, @Dr15Jones, @malbouis, @makortel, @slava77, @christopheralanwest, @Martin-Grunewald, @cmsbuild, @yuanchao, @tlampen, @jpata, @fwyzard, @pohsun, @francescobrivio can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
enable profiling |
|
@cmsbuild please test |
|
In the jenkins pages I found "PR #32901 slc7_amd64_gcc900 prefiling " |
|
@slava77 , yes there was a typo and this is fixed now. |
@smuzaffar do I understand correctly that this cms-cmpwg/profiling@249813e#diff-2d467ee7db6fbd691d551a712660bc304f2ecad307660feed209a5f400cf1a0eR40 |
|
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5906b2/12867/summary.html Comparison Summary@slava77 comparisons for the following workflows were not done due to missing matrix map:
Summary:
|
|
Sorry about that. I was doing some profiling work at NERSC and changed the default to 100. The environment variable EVENTS should override the default in the script. |
|
@smuzaffar I updated the pr profling job to set EVENTS as the ib profiling jobs does. |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-32901/21206
|
|
Pull request #32901 was updated. @perrotta, @smuzaffar, @Dr15Jones, @malbouis, @makortel, @slava77, @christopheralanwest, @Martin-Grunewald, @cmsbuild, @yuanchao, @tlampen, @jpata, @fwyzard, @pohsun, @francescobrivio can you please check and sign again. |
|
please test |
|
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5906b2/13037/summary.html Comparison SummarySummary:
|
|
+alca |
|
+1 |
|
+1
|
|
+1 |
cmsbuild
added
core-approved
fully-signed
and removed
core-pending
pending-signatures
labels
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
|
+1 |
PR description:
First this PR is a collaboration with @SohamBhattacharya and @swagata87
This PR extends the supercluster energy correction to support the HGCAL. The supercluster correction class was modernised during this process. Additionally the new HGCalShowerHelper class had to be restructured to give it better const behaviour (ie its methods are now all const).
The HGCalShowerHelper class had an internal cache. This cache has now been separated out to its own object, which now corresponds to a specific object and selection cuts. Finally it was deemed that the rVal makes no sense if divided by another energy than the raw energy so the accessor was changed to force this and avoid accidents.
The primary purpose was to enable this energy correction for the phase II HLT. It has been tested on 100K dielectron events and the performance is as expected for both reco and HLT (modulo a minor bug in reco which has now been fixed)
No changes are expected to non-phase-II workflows beyond the HLT superclusters now getting a resolution estimate (which they dont use) and the only change in phase-II workflows are HGCAL superclusters are now corrected.
PR validation:
super cluster energy of 500 RelValZEE Run3 events
There was a minor bug in the offline HGCAL regression so that is being redone but the HLT HGCAL regression is below
if this PR is a backport please specify the original PR and why you need to backport that PR: