Correct muon unconstrained pT scale #32906

dinyar · 2021-02-13T14:41:43Z

PR description:

During the MWGR it was noticed that unconstrained pT in the DQM maxed out at 125 GeV. The reason for this is that in the Muon unpacker and uGMT emulator the step size for unconstrained pT was 0.5 GeV (as it is for standard pT), however in firmware it is actually 1 GeV. This PR fixes the discrepancy in both the unpacker and emulator.

This should also go in for the next MWGR in March and therefore assume I should make a backport, but please confirm. (attn @rekovic)

PR validation:

I have locally run the DQM on a streamer file taken last week and verified correctness.

Backport 11_2_X: #32913

Unlike standard pT which has a step size of 0.5 GeV, unconstrained pT has a LSB of 1 GeV.

cmsbuild · 2021-02-13T14:47:57Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-32906/21133

This PR adds an extra 20KB to repository

cmsbuild · 2021-02-13T14:48:16Z

A new Pull Request was created by @dinyar (Dinyar Rabady) for master.

It involves the following packages:

L1Trigger/L1TMuon

@cmsbuild, @rekovic, @jmduarte can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @thomreis this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

rekovic · 2021-02-15T06:46:43Z

please test

rekovic · 2021-02-15T06:48:25Z

@dinyar
Yes, please make a 11_2_X backport.

cmsbuild · 2021-02-15T09:19:05Z

-1

Failed Tests: RelVals-INPUT
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-883ab8/12880/summary.html
COMMIT: dafaa1f
CMSSW: CMSSW_11_3_X_2021-02-14-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/32906/12880/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals-INPUT

4.764.76_ZMuSkim2012D+ZMuSkim2012D+HLTDSKIM2+RECODR1reHLT2+HARVESTDR1reHLT/step2_ZMuSkim2012D+ZMuSkim2012D+HLTDSKIM2+RECODR1reHLT2+HARVESTDR1reHLT.log

Comparison Summary

@slava77 comparisons for the following workflows were not done due to missing matrix map:

/data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-883ab8/11634.911_TTbar_14TeV+2021_DD4hep+TTbar_14TeV_TuneCP5_GenSim+Digi+Reco+HARVEST+ALCA

Summary:

No significant changes to the logs found
Reco comparison results: 4 differences found in the comparisons
DQMHistoTests: Total files compared: 37
DQMHistoTests: Total histograms compared: 2750846
DQMHistoTests: Total failures: 19
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 2750805
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 36 files compared)
Checked 156 log files, 37 edm output root files, 37 DQM output files

dinyar · 2021-02-15T10:28:17Z

Hi @rekovic

I checked the source of the error and it looks like the EDM file wasn't found for the failing workflow[1]. Should we try again?

Cheers,
Dinyar

[1] https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-883ab8/12880/runTheMatrixINPUT-results/4.76_ZMuSkim2012D+ZMuSkim2012D+HLTDSKIM2+RECODR1reHLT2+HARVESTDR1reHLT/step2_ZMuSkim2012D+ZMuSkim2012D+HLTDSKIM2+RECODR1reHLT2+HARVESTDR1reHLT.log

silviodonato · 2021-02-15T15:58:55Z

The error is not related to this PR

----- Begin Fatal Exception 15-Feb-2021 13:15:41 CET-----------------------
An exception of category 'FileOpenError' occurred while
   [0] Constructing the EventProcessor
   [1] Constructing input source of type PoolSource
   [2] Calling RootInputFileSequence::initTheFile()
   [3] Calling StorageFactory::open()
   [4] Calling XrdFile::open()
Exception Message:
Failed to open the file 'root://cms-xrd-global.cern.ch//store/data/Run2012D/SingleMu/RAW-RECO/ZMu-15Apr2014-v1/00000/007A3BD1-02CD-E311-853B-002590D0AFC8.root'
   Additional Info:
      [a] Calling RootInputFileSequence::initTheFile(): fail to open the file with name root://eoscms.cern.ch//eos/cms/store/user/cmsbuild/store/data/Run2012D/SingleMu/RAW-RECO/ZMu-15Apr2014-v1/00000/007A3BD1-02CD-E311-853B-002590D0AFC8.root
      [b] Input file root://cms-xrd-global.cern.ch//store/data/Run2012D/SingleMu/RAW-RECO/ZMu-15Apr2014-v1/00000/007A3BD1-02CD-E311-853B-002590D0AFC8.root could not be opened.
      [c] XrdCl::File::Open(name='root://cms-xrd-global.cern.ch//store/data/Run2012D/SingleMu/RAW-RECO/ZMu-15Apr2014-v1/00000/007A3BD1-02CD-E311-853B-002590D0AFC8.root', flags=0x10, permissions=0660) => error '[ERROR] Server responded with an error: [3011] No servers are available to read the file.�
' (errno=3011, code=400). No additional data servers were found.
      [d] Last URL tried: root://cms-xrd-global.cern.ch:1094//store/data/Run2012D/SingleMu/RAW-RECO/ZMu-15Apr2014-v1/00000/007A3BD1-02CD-E311-853B-002590D0AFC8.root?tried=&xrdcl.requuid=6bf4650c-fe39-4d9b-b4d0-51868268f097
      [e] Problematic data server: cms-xrd-global.cern.ch:1094
      [f] Disabled source: cms-xrd-global.cern.ch:1094
----- End Fatal Exception -------------------------------------------------

silviodonato · 2021-02-15T15:59:00Z

please test

cmsbuild · 2021-02-15T18:48:39Z

-1

Failed Tests: RelVals-INPUT
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-883ab8/12893/summary.html
COMMIT: dafaa1f
CMSSW: CMSSW_11_3_X_2021-02-15-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/32906/12893/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals-INPUT

4.764.76_ZMuSkim2012D+ZMuSkim2012D+HLTDSKIM2+RECODR1reHLT2+HARVESTDR1reHLT/step2_ZMuSkim2012D+ZMuSkim2012D+HLTDSKIM2+RECODR1reHLT2+HARVESTDR1reHLT.log

Comparison Summary

@slava77 comparisons for the following workflows were not done due to missing matrix map:

/data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-883ab8/11634.911_TTbar_14TeV+2021_DD4hep+TTbar_14TeV_TuneCP5_GenSim+Digi+Reco+HARVEST+ALCA

Summary:

No significant changes to the logs found
Reco comparison results: 4 differences found in the comparisons
DQMHistoTests: Total files compared: 37
DQMHistoTests: Total histograms compared: 2750846
DQMHistoTests: Total failures: 19
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 2750805
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 36 files compared)
Checked 156 log files, 37 edm output root files, 37 DQM output files

qliphy · 2021-02-16T15:13:37Z

please test

cmsbuild · 2021-02-16T18:35:46Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-883ab8/12928/summary.html
COMMIT: dafaa1f
CMSSW: CMSSW_11_3_X_2021-02-16-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/32906/12928/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

@slava77 comparisons for the following workflows were not done due to missing matrix map:

/data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-883ab8/11634.911_TTbar_14TeV+2021_DD4hep+TTbar_14TeV_TuneCP5_GenSim+Digi+Reco+HARVEST+ALCA

Summary:

No significant changes to the logs found
Reco comparison results: 4 differences found in the comparisons
DQMHistoTests: Total files compared: 37
DQMHistoTests: Total histograms compared: 2750846
DQMHistoTests: Total failures: 20
DQMHistoTests: Total nulls: 1
DQMHistoTests: Total successes: 2750803
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: -0.004 KiB( 36 files compared)
DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
Checked 156 log files, 37 edm output root files, 37 DQM output files

silviodonato · 2021-02-17T15:45:42Z

urgent
for the next MWGR

silviodonato · 2021-02-17T15:55:47Z

I think this PR can go,
@rekovic @jmduarte could you check and sign?
We need to merge the backport for the MWGR

rekovic · 2021-02-17T16:21:51Z

This was just discussed in detail in the L1T Offline SW meeting. Yes, this can go in.

rekovic · 2021-02-17T16:21:58Z

+1

cmsbuild · 2021-02-17T16:22:10Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

silviodonato · 2021-02-17T16:53:39Z

+1

Correct muon unconstrained pT scale

dafaa1f

Unlike standard pT which has a step size of 0.5 GeV, unconstrained pT has a LSB of 1 GeV.

cmsbuild added this to the CMSSW_11_3_X milestone Feb 13, 2021

cmsbuild added code-checks-pending l1-pending orp-pending pending-signatures tests-pending labels Feb 13, 2021

cmsbuild added code-checks-approved and removed code-checks-pending labels Feb 13, 2021

cmsbuild added tests-started and removed tests-pending labels Feb 15, 2021

cmsbuild added tests-rejected and removed tests-started labels Feb 15, 2021

dinyar mentioned this pull request Feb 15, 2021

(Backport for 11_2_X) Correct muon unconstrained pT scale #32913

Merged

cmsbuild added tests-started and removed tests-rejected labels Feb 15, 2021

cmsbuild added tests-rejected and removed tests-started labels Feb 15, 2021

cmsbuild added tests-started and removed tests-rejected labels Feb 16, 2021

cmsbuild added tests-approved and removed tests-started labels Feb 16, 2021

cmsbuild added the urgent label Feb 17, 2021

cmsbuild added fully-signed l1-approved and removed l1-pending pending-signatures labels Feb 17, 2021

cmsbuild added orp-approved and removed orp-pending labels Feb 17, 2021

cmsbuild merged commit f91490f into cms-sw:master Feb 17, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Correct muon unconstrained pT scale #32906

Correct muon unconstrained pT scale #32906

dinyar commented Feb 13, 2021 •

edited by silviodonato

cmsbuild commented Feb 13, 2021

cmsbuild commented Feb 13, 2021

rekovic commented Feb 15, 2021

rekovic commented Feb 15, 2021

cmsbuild commented Feb 15, 2021

dinyar commented Feb 15, 2021

silviodonato commented Feb 15, 2021

silviodonato commented Feb 15, 2021

cmsbuild commented Feb 15, 2021

qliphy commented Feb 16, 2021

cmsbuild commented Feb 16, 2021

silviodonato commented Feb 17, 2021

silviodonato commented Feb 17, 2021

rekovic commented Feb 17, 2021

rekovic commented Feb 17, 2021

cmsbuild commented Feb 17, 2021

silviodonato commented Feb 17, 2021

Correct muon unconstrained pT scale #32906

Correct muon unconstrained pT scale #32906

Conversation

dinyar commented Feb 13, 2021 • edited by silviodonato

PR description:

PR validation:

cmsbuild commented Feb 13, 2021

cmsbuild commented Feb 13, 2021

rekovic commented Feb 15, 2021

rekovic commented Feb 15, 2021

cmsbuild commented Feb 15, 2021

RelVals-INPUT

Comparison Summary

dinyar commented Feb 15, 2021

silviodonato commented Feb 15, 2021

silviodonato commented Feb 15, 2021

cmsbuild commented Feb 15, 2021

RelVals-INPUT

Comparison Summary

qliphy commented Feb 16, 2021

cmsbuild commented Feb 16, 2021

Comparison Summary

silviodonato commented Feb 17, 2021

silviodonato commented Feb 17, 2021

rekovic commented Feb 17, 2021

rekovic commented Feb 17, 2021

cmsbuild commented Feb 17, 2021

silviodonato commented Feb 17, 2021

dinyar commented Feb 13, 2021 •

edited by silviodonato