Add nConstituents to fat jets. #32930

laurenhay · 2021-02-16T20:00:49Z

PR description:

For use with AK8 PF Candidate jet tables.

PR validation:

Trivial inspection. See jetTable.

if this PR is a backport please specify the original PR and why you need to backport that PR:

#32927
Needed for NANO v9.

#### PR description: For use with AK8 PF Candidate jet tables. #### PR validation: Trivial inspection. See jetTable. #### if this PR is a backport please specify the original PR and why you need to backport that PR: NA

smuzaffar · 2021-02-16T20:48:12Z

ping bot

cmsbuild · 2021-02-16T20:48:33Z

A new Pull Request was created by @laurenhay for CMSSW_10_6_X.

It involves the following packages:

PhysicsTools/NanoAOD

@cmsbuild, @mariadalfonso, @gouskos, @fgolf can you please review it and eventually sign? Thanks.
@gpetruc, @peruzzim, @swertz this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

qliphy · 2021-03-02T09:01:02Z

@laurenhay Can you update this to the master PR #32927 accordingly?

cmsbuild · 2021-03-03T17:08:13Z

Pull request #32930 was updated. @cmsbuild, @mariadalfonso, @gouskos, @fgolf can you please check and sign again.

mariadalfonso · 2021-03-05T10:17:19Z

@laurenhay
to safeguard the current ongoing v8 production in 10_6_X, can you add something like
(run2_nanoAOD_106Xv1 and ~run2_nanoAOD_devel).toModify(fatJetTable , nConstituents = None)

laurenhay · 2021-03-05T18:58:10Z

@laurenhay
to safeguard the current ongoing v8 production in 10_6_X, can you add something like
(run2_nanoAOD_106Xv1 and ~run2_nanoAOD_devel).toModify(fatJetTable , nConstituents = None)

Yes! Just pushed. Please let me know if this is what you were thinking.

cmsbuild · 2021-03-05T18:58:56Z

Pull request #32930 was updated. @cmsbuild, @mariadalfonso, @gouskos, @fgolf can you please check and sign again.

mariadalfonso · 2021-03-05T20:21:48Z

@laurenhay
to safeguard the current ongoing v8 production in 10_6_X, can you add something like
(run2_nanoAOD_106Xv1 and ~run2_nanoAOD_devel).toModify(fatJetTable , nConstituents = None)

Yes! Just pushed. Please let me know if this is what you were thinking.

uhm, what you implemented switch off the addition for run2_nanoAOD_106Xv1 no matter how the run2_nanoAOD_devel is set.
what we want to wo switch off only when happens this (run2_nanoAOD_106Xv1 and ~run2_nanoAOD_devel)

cmsbuild · 2021-03-05T21:46:04Z

Pull request #32930 was updated. @cmsbuild, @mariadalfonso, @gouskos, @fgolf can you please check and sign again.

laurenhay · 2021-03-05T21:46:36Z

@laurenhay
to safeguard the current ongoing v8 production in 10_6_X, can you add something like
(run2_nanoAOD_106Xv1 and ~run2_nanoAOD_devel).toModify(fatJetTable , nConstituents = None)

Yes! Just pushed. Please let me know if this is what you were thinking.

uhm, what you implemented switch off the addition for run2_nanoAOD_106Xv1 no matter how the run2_nanoAOD_devel is set.
what we want to wo switch off only when happens this (run2_nanoAOD_106Xv1 and ~run2_nanoAOD_devel)

Sorry about that! I wasn't familiar with that convenient syntax! Hopefully I got it right now.

mariadalfonso · 2021-03-07T12:44:53Z

please test

cmsbuild · 2021-03-07T13:48:11Z

-1

Failed Tests: RelVals RelVals-INPUT
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ce3140/13316/summary.html
COMMIT: 62cc888
CMSSW: CMSSW_10_6_X_2021-03-07-0000/slc7_amd64_gcc700
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/32930/13316/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals

1325.811325.81_TTbar_13_106Xv1NanoAODINPUT+TTbar_13_106Xv1NanoAODINPUT+NANOEDMMC2017_106XMiniAODv1+HARVESTNANOAODMC2017_106XMiniAODv1/step2_TTbar_13_106Xv1NanoAODINPUT+TTbar_13_106Xv1NanoAODINPUT+NANOEDMMC2017_106XMiniAODv1+HARVESTNANOAODMC2017_106XMiniAODv1.log

RelVals-INPUT

136.8522136.8522_RunJetHT2018A_nanoUL+RunJetHT2018A_nanoUL+NANOEDM2018_106Xv1+HARVESTNANOAOD2018_106Xv1/step2_RunJetHT2018A_nanoUL+RunJetHT2018A_nanoUL+NANOEDM2018_106Xv1+HARVESTNANOAOD2018_106Xv1.log
1325.611325.61_TTbar_13_106Xv1NanoAODINPUT+TTbar_13_106Xv1NanoAODINPUT+NANOAODMC2017_106XMiniAODv1/step2_TTbar_13_106Xv1NanoAODINPUT+TTbar_13_106Xv1NanoAODINPUT+NANOAODMC2017_106XMiniAODv1.log
1325.811325.81_TTbar_13_106Xv1NanoAODINPUT+TTbar_13_106Xv1NanoAODINPUT+NANOEDMMC2017_106XMiniAODv1+HARVESTNANOAODMC2017_106XMiniAODv1/step2_TTbar_13_106Xv1NanoAODINPUT+TTbar_13_106Xv1NanoAODINPUT+NANOEDMMC2017_106XMiniAODv1+HARVESTNANOAODMC2017_106XMiniAODv1.log

PhysicsTools/NanoAOD/python/jets_cff.py

silviodonato · 2021-03-15T09:21:49Z

kind reminder @laurenhay

gouskos · 2021-03-15T09:49:11Z

@laurenhay
please also include the modifiers for the DQM plots [not inlcude the additional plot in nanoAOD-v8].
You can use the following example as a guide: https://github.com/cms-sw/cmssw/pull/33075/files#diff-5f4338f7d7671c8348d9097ff44f255cc0b36d204c639782856a7c36cbc8fbda

cmsbuild · 2021-03-16T14:02:35Z

Pull request #32930 was updated. @cmsbuild, @mariadalfonso, @gouskos, @fgolf can you please check and sign again.

cmsbuild · 2021-05-20T14:36:48Z

Pull request #32930 was updated. @cmsbuild, @mariadalfonso, @gouskos, @fgolf can you please check and sign again.

mariadalfonso · 2021-05-20T20:47:36Z

please test

mariadalfonso · 2021-05-20T21:35:32Z

PhysicsTools/NanoAOD/python/nanoDQM_cff.py

+_sv_plots_nom = copy.deepcopy(nanoDQM.vplots.SV.plots)
+_sv_plots_106Xv1 = cms.VPSet()
+for plot in _sv_plots_nom:
+    if (plot.name.value() != "charge"):
+        _sv_plots_106Xv1.append(plot)
+(run2_nanoAOD_106Xv1 & ~run2_nanoAOD_devel).toModify(nanoDQM.vplots.SV, plots = _sv_plots_106Xv1 )


I suspect this is still rebased on top of an old IB.
this part of the sv plots is unrelated to this PR and is already in the 10_6_X
https://github.com/cms-sw/cmssw/blob/CMSSW_10_6_X/PhysicsTools/NanoAOD/python/nanoDQM_cff.py#L105-L108

Sorry! Idk what happened since I did the rebasing in the CMSSW_10_6_X_2021-05-17-2300, but I've removed the sv lines.

cmsbuild · 2021-05-20T23:49:42Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ce3140/15219/summary.html
COMMIT: 7624890
CMSSW: CMSSW_10_6_X_2021-05-20-1100/slc7_amd64_gcc700
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/32930/15219/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

No significant changes to the logs found
Reco comparison results: 36 differences found in the comparisons
DQMHistoTests: Total files compared: 35
DQMHistoTests: Total histograms compared: 3215551
DQMHistoTests: Total failures: 1
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3215216
DQMHistoTests: Total skipped: 334
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.183 KiB( 34 files compared)
DQMHistoSizes: changed ( 136.8523 ): 0.183 KiB Physics/NanoAODDQM
Checked 143 log files, 29 edm output root files, 35 DQM output files
TriggerResults: no differences found

Get rid of extraneous sv no-change policy

cmsbuild · 2021-05-21T18:40:41Z

Pull request #32930 was updated. @cmsbuild, @mariadalfonso, @gouskos, @fgolf can you please check and sign again.

mariadalfonso · 2021-05-22T08:44:01Z

please test

cmsbuild · 2021-05-22T11:43:19Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ce3140/15252/summary.html
COMMIT: b769e8e
CMSSW: CMSSW_10_6_X_2021-05-21-2300/slc7_amd64_gcc700
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/32930/15252/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

No significant changes to the logs found
Reco comparison results: 36 differences found in the comparisons
DQMHistoTests: Total files compared: 35
DQMHistoTests: Total histograms compared: 3215551
DQMHistoTests: Total failures: 1
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3215216
DQMHistoTests: Total skipped: 334
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.183 KiB( 34 files compared)
DQMHistoSizes: changed ( 136.8523 ): 0.183 KiB Physics/NanoAODDQM
Checked 143 log files, 29 edm output root files, 35 DQM output files
TriggerResults: no differences found

mariadalfonso · 2021-05-22T13:16:37Z

+xpog

added variable to FatJet table; no changes for nanov8
full set of results here
https://gitlab.cern.ch/cms-nanoAOD/nanoAOD-integration/-/issues/87

cmsbuild · 2021-05-22T13:17:02Z

This pull request is fully signed and it will be integrated in one of the next CMSSW_10_6_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_12_0_X is complete. This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

qliphy · 2021-05-22T14:44:25Z

@cms-sw/xpog-l2 It seems there are some reco differences: "Reco comparison results: 36 differences found in the comparisons", and even on particleNetMD score and Nsubjettiness, do you know why?:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/baseLineComparisons/CMSSW_10_6_X_2021-05-21-2300+ce3140/42922/validateJR/all_OldVSNew_RunJetHT2018CnanoEDM106Xv2wf136p8523/

mariadalfonso · 2021-05-22T18:02:49Z

@cms-sw/xpog-l2 It seems there are some reco differences: "Reco comparison results: 36 differences found in the comparisons", and even on particleNetMD score and Nsubjettiness, do you know why?:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/baseLineComparisons/CMSSW_10_6_X_2021-05-21-2300+ce3140/42922/validateJR/all_OldVSNew_RunJetHT2018CnanoEDM106Xv2wf136p8523/

the comparison you point is done based on a counter so when you add a variable, the new tree get offset respect to the reference.
This PR add a variable, so the amount of differences is not reliable; seen many other times
#31696 (comment)

if you look at the DQM results instead you see that the addition is only on the number of constituents of the FatJet (and for the nanov8 when there is no difference even there ) https://gitlab.cern.ch/cms-nanoAOD/nanoAOD-integration/-/issues/87

qliphy · 2021-05-23T01:58:38Z

+1

Add nConstituents to fat jets.

e87ad3d

#### PR description: For use with AK8 PF Candidate jet tables. #### PR validation: Trivial inspection. See jetTable. #### if this PR is a backport please specify the original PR and why you need to backport that PR: NA

cmsbuild added this to the CMSSW_10_6_X milestone Feb 16, 2021

cmsbuild added orp-pending pending-signatures tests-pending xpog-pending labels Feb 16, 2021

rappoccio mentioned this pull request Feb 17, 2021

Association validation cms-jet/PFNano#30

Open

mariadalfonso mentioned this pull request Feb 26, 2021

features for V9 nanoAOD cms-nanoAOD/cmssw#555

Closed

55 tasks

cmsbuild added tests-started and removed tests-pending labels Mar 7, 2021

cmsbuild added tests-rejected and removed tests-started labels Mar 7, 2021

mariadalfonso reviewed Mar 7, 2021

View reviewed changes

PhysicsTools/NanoAOD/python/jets_cff.py Outdated Show resolved Hide resolved

cmsbuild added tests-pending and removed tests-rejected labels Mar 16, 2021

cmsbuild added tests-started and removed tests-pending labels May 20, 2021

mariadalfonso reviewed May 20, 2021

View reviewed changes

cmsbuild added tests-approved and removed tests-started labels May 20, 2021

Update nanoDQM_cff.py

b769e8e

Get rid of extraneous sv no-change policy

cmsbuild added tests-pending and removed tests-approved labels May 21, 2021

cmsbuild added tests-started and removed tests-pending labels May 22, 2021

cmsbuild added tests-approved and removed tests-started labels May 22, 2021

cmsbuild added fully-signed xpog-approved and removed pending-signatures xpog-pending labels May 22, 2021

cmsbuild added orp-approved and removed orp-pending labels May 23, 2021

cmsbuild merged commit ad64f32 into cms-sw:CMSSW_10_6_X May 23, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add nConstituents to fat jets. #32930

Add nConstituents to fat jets. #32930

laurenhay commented Feb 16, 2021

smuzaffar commented Feb 16, 2021

cmsbuild commented Feb 16, 2021

qliphy commented Mar 2, 2021

cmsbuild commented Mar 3, 2021

mariadalfonso commented Mar 5, 2021

laurenhay commented Mar 5, 2021

cmsbuild commented Mar 5, 2021

mariadalfonso commented Mar 5, 2021

cmsbuild commented Mar 5, 2021

laurenhay commented Mar 5, 2021

mariadalfonso commented Mar 7, 2021

cmsbuild commented Mar 7, 2021

silviodonato commented Mar 15, 2021

gouskos commented Mar 15, 2021 •

edited

cmsbuild commented Mar 16, 2021

cmsbuild commented May 20, 2021

mariadalfonso commented May 20, 2021

mariadalfonso May 20, 2021

laurenhay May 21, 2021

cmsbuild commented May 20, 2021

cmsbuild commented May 21, 2021

mariadalfonso commented May 22, 2021

cmsbuild commented May 22, 2021

mariadalfonso commented May 22, 2021

cmsbuild commented May 22, 2021

qliphy commented May 22, 2021

mariadalfonso commented May 22, 2021

qliphy commented May 23, 2021

Add nConstituents to fat jets. #32930

Add nConstituents to fat jets. #32930

Conversation

laurenhay commented Feb 16, 2021

PR description:

PR validation:

if this PR is a backport please specify the original PR and why you need to backport that PR:

smuzaffar commented Feb 16, 2021

cmsbuild commented Feb 16, 2021

qliphy commented Mar 2, 2021

cmsbuild commented Mar 3, 2021

mariadalfonso commented Mar 5, 2021

laurenhay commented Mar 5, 2021

cmsbuild commented Mar 5, 2021

mariadalfonso commented Mar 5, 2021

cmsbuild commented Mar 5, 2021

laurenhay commented Mar 5, 2021

mariadalfonso commented Mar 7, 2021

cmsbuild commented Mar 7, 2021

RelVals

RelVals-INPUT

silviodonato commented Mar 15, 2021

gouskos commented Mar 15, 2021 • edited

cmsbuild commented Mar 16, 2021

cmsbuild commented May 20, 2021

mariadalfonso commented May 20, 2021

mariadalfonso May 20, 2021

Choose a reason for hiding this comment

laurenhay May 21, 2021

Choose a reason for hiding this comment

cmsbuild commented May 20, 2021

Comparison Summary

cmsbuild commented May 21, 2021

mariadalfonso commented May 22, 2021

cmsbuild commented May 22, 2021

Comparison Summary

mariadalfonso commented May 22, 2021

cmsbuild commented May 22, 2021

qliphy commented May 22, 2021

mariadalfonso commented May 22, 2021

qliphy commented May 23, 2021

gouskos commented Mar 15, 2021 •

edited