Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migration to DD4hep for GEM DB loader #32982

Merged
merged 7 commits into from Mar 1, 2021

Conversation

slomeo
Copy link
Contributor

@slomeo slomeo commented Feb 24, 2021

PR description:

This PR (only for GEM) followed what I did for DT in the PR #32781 (to be signed and merged) .

PR validation:

  1. Validation by using "cmsRun CondTools/Geometry/test/gemgeometrywriter.py" (with DDD and DD4hep):
    by checking printouts for both DD & DD4Hep build methods within the GEMGeometryParsFromDD Class in order to compare some DetId parameters (see below):

//DDD

(0) GEMGeometryParsFromDD - DDD
(1) DDD, tran vector 1877.54 331.06 5695.5
(4) DDD, Chamber DetID 687898914 Name GEMBox11L dx1 141.087 dx2 254.993 dy 641.5 dz 17.35
(1) DDD, tran vector 2377.3 419.183 5692.09
(5) DDD, Eta Partion DetID 688423202 Name GHA101 dx1 205.701 dx2 222.929 dy 97.025 dz 1.4875 nStrips 384 nPads 192 dPhi 0.177151

and so on...

//DD4Hep

(0) GEMGeometryParsFromDD - DD4HEP
(1) DD4HEP, tran vector 1877.54 331.06 5695.5
(4) DD4HEP, Chamber DetID 687898914 Name GEMBox11L dx1 141.087 dx2 254.993 dy 641.5 dz 17.35
(1) DD4HEP, tran vector 2377.3 419.183 5692.09
(5) DD4HEP, Eta Partion DetID 688423202 Name GHA101 dx1 205.701 dx2 222.929 dy 97.025 dz 1.4875 nStrips 384 nPads 192 dPhi 0.177151

and so on..

The DD part of the code has not been touched by this PR (except for the printouts). Added "/ dd4hep::mm;", where it was necessary, in the DD4Hep part of the code.

  1. Validation by using a dump script, not included in this PR (because it uses a local .mb file).
    Details are present in [*] at the end of this PR description.

// DDD

GEMGeometryESModule::produce :: GEMGeometryBuilder builder db
GEMGeometry found with 2 regions

Region 0:-1 with 1 staions

Station 0:1:GE-1/1 with 1 rings

Ring 0:1 with 36 superChambers

SuperChamber 0: Re -1 Ri 1 St 1 La 0 Ch 35 Ro 0 with 2 chambers

Chamber 0: Re -1 Ri 1 St 1 La 1 Ch 35 Ro 0 with 8 etaPartitions

EtaPartition 0: Re -1 Ri 1 St 1 La 1 Ch 35 Ro 1 GHA111 with 384 strips of pitch 0.10517 and 192 pads of pitch 0.21034

EtaPartition 1: Re -1 Ri 1 St 1 La 1 Ch 35 Ro 2 GHA112 with 384 strips of pitch 0.0974638 and 192 pads of pitch 0.194927

EtaPartition 2: Re -1 Ri 1 St 1 La 1 Ch 35 Ro 3 GHA113 with 384 strips of pitch 0.0903565 and 192 pads of pitch 0.180713

EtaPartition 3: Re -1 Ri 1 St 1 La 1 Ch 35 Ro 4 GHA114 with 384 strips of pitch 0.0838485 and 192 pads of pitch 0.167697

EtaPartition 4: Re -1 Ri 1 St 1 La 1 Ch 35 Ro 5 GHA115 with 384 strips of pitch 0.077825 and 192 pads of pitch 0.15565

EtaPartition 5: Re -1 Ri 1 St 1 La 1 Ch 35 Ro 6 GHA116 with 384 strips of pitch 0.0722858 and 192 pads of pitch 0.144572

EtaPartition 6: Re -1 Ri 1 St 1 La 1 Ch 35 Ro 7 GHA117 with 384 strips of pitch 0.0671505 and 192 pads of pitch 0.134301

EtaPartition 7: Re -1 Ri 1 St 1 La 1 Ch 35 Ro 8 GHA118 with 384 strips of pitch 0.0624191 and 192 pads of pitch 0.124838

and so on

// DD4Hep

GEMGeometryESModule::produce :: GEMGeometryBuilder builder db
GEMGeometry found with 2 regions

Region 0:-1 with 1 staions

Station 0:1:GE-1/1 with 1 rings

Ring 0:1 with 36 superChambers

SuperChamber 0: Re -1 Ri 1 St 1 La 0 Ch 35 Ro 0 with 2 chambers

Chamber 0: Re -1 Ri 1 St 1 La 1 Ch 35 Ro 0 with 8 etaPartitions

EtaPartition 0: Re -1 Ri 1 St 1 La 1 Ch 35 Ro 1 GHA111 with 384 strips of pitch 0.10517 and 192 pads of pitch 0.21034

EtaPartition 1: Re -1 Ri 1 St 1 La 1 Ch 35 Ro 2 GHA112 with 384 strips of pitch 0.0974638 and 192 pads of pitch 0.194927

EtaPartition 2: Re -1 Ri 1 St 1 La 1 Ch 35 Ro 3 GHA113 with 384 strips of pitch 0.0903565 and 192 pads of pitch 0.180713

EtaPartition 3: Re -1 Ri 1 St 1 La 1 Ch 35 Ro 4 GHA114 with 384 strips of pitch 0.0838485 and 192 pads of pitch 0.167697

EtaPartition 4: Re -1 Ri 1 St 1 La 1 Ch 35 Ro 5 GHA115 with 384 strips of pitch 0.077825 and 192 pads of pitch 0.15565

EtaPartition 5: Re -1 Ri 1 St 1 La 1 Ch 35 Ro 6 GHA116 with 384 strips of pitch 0.0722858 and 192 pads of pitch 0.144572

EtaPartition 6: Re -1 Ri 1 St 1 La 1 Ch 35 Ro 7 GHA117 with 384 strips of pitch 0.0671505 and 192 pads of pitch 0.134301

EtaPartition 7: Re -1 Ri 1 St 1 La 1 Ch 35 Ro 8 GHA118 with 384 strips of pitch 0.0624191 and 192 pads of pitch 0.124838

and so on

The conclusion is that the validation of the GEM DB Loader Migration to DD4Hep is fine.

if this PR is a backport please specify the original PR and why you need to backport that PR:

nothing special

[*]

In CMSSW_11_3_X_2021-02-21-0000 (for DDD) and CMSSW_11_3_X_2021-02-21-2300 (for DD4Hep)

a) In /condTools/Geom/test
cp writehelp/* .

b) ./createExtended2021Payload.sh 113YV10 (for DDD and 113YV11 for DD4Hep)

Then I created a
script called "dumpGEMGeometry_DB_cfg.py" and the lines are:
+++++++
import FWCore.ParameterSet.Config as cms

process = cms.Process('DUMP')

process.load("CondCore.CondDB.CondDB_cfi")
process.load("Configuration.StandardSequences.FrontierConditions_GlobalTag_cff")
process.load('Geometry.MuonCommonData.testGE0XML_cfi')
process.load("FWCore.MessageLogger.MessageLogger_cfi")
process.load("Geometry.MuonNumbering.muonGeometryConstants_cff")
process.load("Geometry.GEMGeometryBuilder.gemGeometryDB_cfi")
process.load("Geometry.GEMGeometryBuilder.gemGeometryDump_cfi")

process.MessageLogger = cms.Service("MessageLogger",
destinations = cms.untracked.vstring('myLogGEM'),
myLogGEM = cms.untracked.PSet(
threshold = cms.untracked.string('INFO'),
)
)

process.muonGeometryConstants.fromDD4Hep = True

from Configuration.AlCa.autoCond import autoCond
process.GlobalTag.globaltag = autoCond['mc']
process.GlobalTag.toGet = cms.VPSet(cms.PSet(record = cms.string('GEMRecoGeometryRcd'),
tag = cms.string('GEMRECO_Geometry_113YV10'),
connect = cms.string("sqlite_file:/afs/cern.ch/user/s/slomeo/CMSSW_11_3_X_2021-02-21-0000/src/CondTools/Geometry/test/myfile.db")))

process.source = cms.Source('EmptySource')

process.maxEvents = cms.untracked.PSet(
input = cms.untracked.int32(1)
)

process.p = cms.Path(process.gemGeometryDump)
++++++++++++

This script (not included in this PR) is located in https://cmssdt.cern.ch/lxr/source/Geometry/GEMGeometryBuilder/test/python/
and calls GEMGeometryDump Class (already present) by using "cmsRun dumpGEMGeometry_DB_cfg.py"

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-32982/21233

  • This PR adds an extra 24KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @slomeo (Sergio Lo Meo) for master.

It involves the following packages:

CondTools/Geometry
Geometry/GEMGeometryBuilder

@civanch, @Dr15Jones, @makortel, @cvuosalo, @ianna, @mdhildreth, @cmsbuild, @srimanob, @kpedro88, @ggovi can you please review it and eventually sign? Thanks.
@cvuosalo, @watson-ij, @jshlee, @dildick, @mmusich, @fabiocos this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@civanch
Copy link
Contributor

civanch commented Feb 24, 2021

please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d2a395/13060/summary.html
COMMIT: b062d1a
CMSSW: CMSSW_11_3_X_2021-02-23-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/32982/13060/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 11 differences found in the comparisons
  • DQMHistoTests: Total files compared: 37
  • DQMHistoTests: Total histograms compared: 2750983
  • DQMHistoTests: Total failures: 9
  • DQMHistoTests: Total nulls: 1
  • DQMHistoTests: Total successes: 2750951
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -0.004 KiB( 36 files compared)
  • DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
  • Checked 156 log files, 37 edm output root files, 37 DQM output files

@cvuosalo
Copy link
Contributor

+1

@ggovi
Copy link
Contributor

ggovi commented Feb 26, 2021

+1

@srimanob
Copy link
Contributor

srimanob commented Mar 1, 2021

+Upgrade

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 1, 2021

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@qliphy
Copy link
Contributor

qliphy commented Mar 1, 2021

+1

@cmsbuild cmsbuild merged commit 482bdb2 into cms-sw:master Mar 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants