Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add Phase2C11T22M9 and Phase2C11T23M9 to Eras.py #32987

Merged
merged 1 commit into from Feb 25, 2021

Conversation

mmusich
Copy link
Contributor

@mmusich mmusich commented Feb 24, 2021

fixes #32986

PR description:

Title says it all, missed in #32952

PR validation:

run successfully

runTheMatrix.py -l 35434.0, 35834.0 -j 0

if this PR is a backport please specify the original PR and why you need to backport that PR:

This is not a backport, no backport is needed.

@mmusich
Copy link
Contributor Author

mmusich commented Feb 24, 2021

@srimanob FYI

@srimanob
Copy link
Contributor

srimanob commented Feb 24, 2021

OK, thanks. I am doing the same, but this is good.

@srimanob
Copy link
Contributor

test parameters:

  • workflows = 35434.0, 35834.0

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-32987/21242

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @mmusich (Marco Musich) for master.

It involves the following packages:

Configuration/StandardSequences

@silviodonato, @cmsbuild, @franzoni, @qliphy, @fabiocos, @davidlange6 can you please review it and eventually sign? Thanks.
@fabiocos, @makortel, @felicepantaleo, @GiacomoSguazzoni, @rovere, @VinInn, @Martin-Grunewald, @lecriste, @mtosi, @dgulhan, @slomeo this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@srimanob
Copy link
Contributor

Please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ec26a1/13066/summary.html
COMMIT: 6f5455d
CMSSW: CMSSW_11_3_X_2021-02-23-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/32987/13066/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

@slava77 comparisons for the following workflows were not done due to missing matrix map:

  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-ec26a1/35434.0_TTbar_14TeV+2026D78+TTbar_14TeV_TuneCP5_GenSimHLBeamSpot14+DigiTrigger+RecoGlobal+HARVESTGlobal
  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-ec26a1/35834.0_TTbar_14TeV+2026D79+TTbar_14TeV_TuneCP5_GenSimHLBeamSpot14+DigiTrigger+RecoGlobal+HARVESTGlobal

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 28 differences found in the comparisons
  • DQMHistoTests: Total files compared: 37
  • DQMHistoTests: Total histograms compared: 2750983
  • DQMHistoTests: Total failures: 26
  • DQMHistoTests: Total nulls: 1
  • DQMHistoTests: Total successes: 2750934
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -0.004 KiB( 36 files compared)
  • DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
  • Checked 156 log files, 37 edm output root files, 37 DQM output files

@srimanob
Copy link
Contributor

@silviodonato @qliphy @makortel
Two additional workflows of D78 and D79 run successfully. I think this PR is good to go.

@qliphy
Copy link
Contributor

qliphy commented Feb 25, 2021

type bug-fix

@qliphy
Copy link
Contributor

qliphy commented Feb 25, 2021

+operations

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@qliphy
Copy link
Contributor

qliphy commented Feb 25, 2021

+1

@cmsbuild cmsbuild merged commit 28074e4 into cms-sw:master Feb 25, 2021
@mmusich mmusich deleted the fixNewTrackerEras branch February 25, 2021 07:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Workflow failures caused by Phase2C11T2{2,3}M9
4 participants