[PPS] Fix of validation script

[forthommel]

PR description:

This PR fixes the failure observed in CMSSW_11_3_X_2021-02-25-1100 IB for the TestCTPPSDirectProtonSimulation unit test after the merge of #32971 (a leftover (std::string)label → (edm::InputTag)tag was not modified in base configuration). This was reported in #32996.
Curiously this did not trigger any failure in the review process of this latter...

PR validation:

Previously failing unit test passes.

if this PR is a backport please specify the original PR and why you need to backport that PR: N/A

Before submitting your pull requests, make sure you followed this checklist:

• verify that the PR is really intended for the chosen branch
• verify that changes follow CMS Naming, Coding, And Style Rules
• verify that the PR passes the basic test procedure suggested in the CMSSW PR instructions

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-32998/21267

• This PR adds an extra 12KB to repository

[cmsbuild]

A new Pull Request was created by @forthommel (Laurent Forthomme) for master.

It involves the following packages:

Validation/CTPPS

@andrius-k, @kmaeshima, @ErnestaP, @ahmad3213, @cmsbuild, @jfernan2, @rvenditti can you please review it and eventually sign? Thanks.
@jan-kaspar this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[jfernan2]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3a7311/13094/summary.html
COMMIT: 926e445
CMSSW: CMSSW_11_3_X_2021-02-25-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/32998/13094/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 2864 differences found in the comparisons
• DQMHistoTests: Total files compared: 37
• DQMHistoTests: Total histograms compared: 2750983
• DQMHistoTests: Total failures: 63395
• DQMHistoTests: Total nulls: 1
• DQMHistoTests: Total successes: 2687565
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: -0.004 KiB( 36 files compared)
• DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
• Checked 156 log files, 37 edm output root files, 37 DQM output files

[forthommel]

Among this crazy number of differences in 11634.911 none seem related to PPS...

[qliphy]

As for differences in 11634.911, @cvuosalo can you have a look?

[forthommel]

Any news about this comparison failure? I did not manage to reproduce with a local matrix test and a few 1-to-1 comparisons with the IB.

[smuzaffar]

please test
lets re-run it based on latest IB

[forthommel]

595 595 592 553 115 41 3 1 1 tests passed, 0 0 0 0 0 0 0 0 0 failed...
This is becoming more and more interesting :)

[cmsbuild]

+1

Failed Tests: RelVals-INPUT
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3a7311/13116/summary.html
COMMIT: 926e445
CMSSW: CMSSW_11_3_X_2021-02-25-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/32998/13116/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 37
• DQMHistoTests: Total histograms compared: 2750983
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2750960
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 36 files compared)
• Checked 156 log files, 37 edm output root files, 37 DQM output files

[smuzaffar]

bot marked the input tests failed as it found the following message in the log file [a]. It might be due to some glitch, let me re-run the input tests to see if it is reproducible

[a]

2021/02/26 11:59:48 ERROR DAS QL ERROR, query=file block = /MinimumBias/Run2011A-ValSkim-08Nov2011-v1/RAW-RECO#239c497e-0fae-11e1-a8b1-00221959e72f run = 165121 site = T2_CH_CERN, idx=0, msg=unable to parse DAS query

[smuzaffar]

@vkuznet , we get a DAS QL ERROR while running das query

>dasgoclient --limit 0 --query 'file block=/MinimumBias/Run2011A-ValSkim-08Nov2011-v1/RAW-RECO#239c497e-0fae-11e1-a8b1-00221959e72f run=165121 site=T2_CH_CERN'
2021/02/26 11:59:48 ERROR DAS QL ERROR, query=file block = /MinimumBias/Run2011A-ValSkim-08Nov2011-v1/RAW-RECO#239c497e-0fae-11e1-a8b1-00221959e72f run = 165121 site = T2_CH_CERN, idx=0, msg=unable to parse DAS query

I can not reproducible it now. any idea why das client failed to parse this query?

[smuzaffar]

this looks good now

[vkuznet]

if parser fails it most likely did not get das maps to process your query. Since I don't know the setup you use I can't say how this happen, but I can tell you the logic how dasmaps are obtained. The das code look-up maps in $HOME/.dasmaps/das_maps_dbs_prod.js file. If this files does not exists or if its mod time is more than 1 day, DAS fetches maps from github and put them into this file. This operation potentially can fail due to github HTTP request failure. Therefore, if you want to avoid this potential rare hick-ups, you should ensure that your user has proper (new) dasmaps which you can fetch up-front from https://raw.githubusercontent.com/dmwm/DASMaps/master/js/das_maps_dbs_prod.js

[forthommel]

Are we all set for this PR review to proceed?

[cvuosalo]

@qliphy Somehow the PR tests triggered a new random seed for the 11634.911 workflow, which produced comparison differences that were merely statistical fluctuations. Note that 11634.911 is unusual in that it performs simulation every time, unlike most other workflows that simply re-use old GEN-SIM.
The subsequent PR tests show no differences because no new random seed was triggered for 11634.911.

[qliphy]

@cvuosalo thanks a lot! Yes, it looks good to me now.
Discussions also in #32963

@cms-sw/dqm-l2 Do you have any comment?

[jfernan2]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[qliphy]

+1