Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ecal DB PayloadInspector with one or two tags #33006

Merged
merged 1 commit into from Mar 10, 2021

Conversation

depasse
Copy link
Contributor

@depasse depasse commented Feb 26, 2021

PR description:

New features in DB PayloadInspector to compare IOVs in 2 different tags

PR validation:

Tests done in command line with getPayloadData.py, plots (png) correctly produced

if this PR is a backport please specify the original PR and why you need to backport that PR:

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33006/21282

  • This PR adds an extra 24KB to repository

@depasse
Copy link
Contributor Author

depasse commented Mar 5, 2021

Must I do stgh ?
In the past, I reeived a message "A new Pull Request was created by @depasse for master.
It involves the following packages:...etc..." Maybe it does not exist any more..
Thanks.

@silviodonato
Copy link
Contributor

code-checks

@silviodonato
Copy link
Contributor

abort

@silviodonato
Copy link
Contributor

code-checks

@silviodonato
Copy link
Contributor

ping bot

@silviodonato
Copy link
Contributor

@smuzaffar something weird is happening with @cmsbuild

@smuzaffar
Copy link
Contributor

as code-checks were already run so looks like bot is confused about the explicit code-checks command. Anyway I have ran the code-checks by hand in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 5, 2021

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33006/21398

  • This PR adds an extra 8KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 5, 2021

A new Pull Request was created by @depasse for master.

It involves the following packages:

CondCore/EcalPlugins

@ggovi, @cmsbuild can you please review it and eventually sign? Thanks.
@rchatter, @simonepigazzini, @mmusich, @thomreis, @argiro this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@silviodonato
Copy link
Contributor

please test
kind reminder @ggovi

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 9, 2021

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-92a0df/13365/summary.html
COMMIT: 87d3a63
CMSSW: CMSSW_11_3_X_2021-03-08-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/33006/13365/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 38
  • DQMHistoTests: Total histograms compared: 2849195
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2849172
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 37 files compared)
  • Checked 160 log files, 37 edm output root files, 38 DQM output files

@ggovi
Copy link
Contributor

ggovi commented Mar 9, 2021

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 9, 2021

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@qliphy
Copy link
Contributor

qliphy commented Mar 10, 2021

+1

@cmsbuild cmsbuild merged commit 0bd1555 into cms-sw:master Mar 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants