Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add EcalMustacheSCParameters and EcalSCDynamicDPhiParameters [11_2_X] #33011

Merged
merged 1 commit into from Mar 4, 2021
Merged

Add EcalMustacheSCParameters and EcalSCDynamicDPhiParameters [11_2_X] #33011

merged 1 commit into from Mar 4, 2021

Conversation

francescobrivio
Copy link
Contributor

PR description:

This PR is a backport of PR #32959 to add the EcalMustacheSCParameters and EcalSCDynamicDPhiParameters to 112X GTs.

The GT diffs are as follows:
Run 2 (L1 trigger stage 1)
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/112X_mcRun2_asymptotic_l1stage1_v2/112X_mcRun2_asymptotic_l1stage1_v3

2016 design
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/112X_mcRun2_design_v2/112X_mcRun2_design_v3

2016 realistic pre-VFP era
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/112X_mcRun2_asymptotic_preVFP_v3/112X_mcRun2_asymptotic_preVFP_v4

2016 realistic post-VFP era
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/112X_mcRun2_asymptotic_v3/112X_mcRun2_asymptotic_v4

2016 cosmics (asymptotic conditions)
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/112X_mcRun2cosmics_asymptotic_deco_v3/112X_mcRun2cosmics_asymptotic_deco_v4

Run 2 heavy ion
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/112X_mcRun2_HeavyIon_v2/112X_mcRun2_HeavyIon_v3

Run 2 proton-lead
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/112X_mcRun2_pA_v2/112X_mcRun2_pA_v3

Offline data
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/112X_dataRun2_v8/112X_dataRun2_v9

Offline data (HEM failure)
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/112X_dataRun2_HEfail_v8/112X_dataRun2_HEfail_v9

Offline data relval
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/112X_dataRun2_relval_v8/112X_dataRun2_relval_v9

Prompt-like HI data
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/112X_dataRun2_PromptLike_HI_v6/112X_dataRun2_PromptLike_HI_v7

2017 design
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/112X_mc2017_design_v3/112X_mc2017_design_v4

2017 realistic
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/112X_mc2017_realistic_v5/112X_mc2017_realistic_v6

2017 realistic cosmics (tracker deco mode)
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/112X_mc2017cosmics_realistic_deco_v5/112X_mc2017cosmics_realistic_deco_v6

2017 realistic cosmics (tracker peak mode)
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/112X_mc2017cosmics_realistic_peak_v5/112X_mc2017cosmics_realistic_peak_v6

2018 design
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/112X_upgrade2018_design_v5/112X_upgrade2018_design_v6

2018 realistic
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/112X_upgrade2018_realistic_v8/112X_upgrade2018_realistic_v9

2018 heavy ion
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/112X_upgrade2018_realistic_HI_v8/112X_upgrade2018_realistic_HI_v9

2018 realistic (HEM15/16 failure)
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/112X_upgrade2018_realistic_HEfail_v8/112X_upgrade2018_realistic_HEfail_v9

2018 cosmics (tracker deco mode)
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/112X_upgrade2018cosmics_realistic_deco_v8/112X_upgrade2018cosmics_realistic_deco_v9

2018 cosmics (tracker peak mode)
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/112X_upgrade2018cosmics_realistic_peak_v8/112X_upgrade2018cosmics_realistic_peak_v9

2021 design
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/112X_mcRun3_2021_design_v13/112X_mcRun3_2021_design_v14

2021 realistic
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/112X_mcRun3_2021_realistic_v16/112X_mcRun3_2021_realistic_v17

2021 cosmics
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/112X_mcRun3_2021cosmics_realistic_deco_v16/112X_mcRun3_2021cosmics_realistic_deco_v17

2021 heavy ion
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/112X_mcRun3_2021_realistic_HI_v16/112X_mcRun3_2021_realistic_HI_v17

2023 realistic
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/112X_mcRun3_2023_realistic_v16/112X_mcRun3_2023_realistic_v17

2024 realistic
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/112X_mcRun3_2024_realistic_v16/112X_mcRun3_2024_realistic_v17

PR validation:

A technical test was performed:
runTheMatrix.py -l limited,12024.0,7.23,159.0,12834.0,7.4,11024.2,11224.0,7.21,7.24,10424.0,136.8642,7.22,1325.516 --ibeos -j 9

if this PR is a backport please specify the original PR and why you need to backport that PR:

This PR is a backport of #32959

@francescobrivio
Copy link
Contributor Author

backport #32959

@cmsbuild cmsbuild added this to the CMSSW_11_2_X milestone Feb 27, 2021
@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 27, 2021 •
edited

A new Pull Request was created by @francescobrivio for CMSSW_11_2_X.

It involves the following packages:

Configuration/AlCa

@malbouis, @yuanchao, @christopheralanwest, @cmsbuild, @tlampen, @pohsun, @francescobrivio can you please review it and eventually sign? Thanks.
@makortel, @Martin-Grunewald, @mmusich, @fabiocos, @tocheng this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@francescobrivio
Copy link
Contributor Author

test parameters:

  • workflow = 12024.0,7.23,159.0,12834.0,7.4,11024.2,11224.0,7.21,7.24,10424.0,136.8642,7.22,1325.516

@francescobrivio
Copy link
Contributor Author

@cmsbuild please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d07409/13136/summary.html
COMMIT: a4bfe60
CMSSW: CMSSW_11_2_X_2021-02-26-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/33011/13136/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

@slava77 comparisons for the following workflows were not done due to missing matrix map:

  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-d07409/10424.0_TTbar_13+2017Design+TTbar_13TeV_TuneCUETP8M1_GenSim+Digi+RecoFakeHLT+HARVESTFakeHLT
  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-d07409/11024.2_TTbar_13UP18HEfailINPUT+TTbar_13UP18HEfailINPUT+DigiFullHEfail+RecoFullHEfail+HARVESTFullHEfail+NanoFullHEfail
  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-d07409/11224.0_TTbar_13+2018Design+TTbar_13TeV_TuneCUETP8M1_GenSim+Digi+RecoFakeHLT+HARVESTFakeHLT
  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-d07409/12024.0_TTbar_13+2021Design+TTbar_13TeV_TuneCUETP8M1_GenSim+Digi+Reco+HARVEST
  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-d07409/136.8642_RunJetHT2018BHEfail+RunJetHT2018BHEfail+HLTDR2_2018+RECODR2_2018reHLT_skimJetHT_Prompt_HEfail+HARVEST2018_HEfail
  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-d07409/7.21_Cosmics_UP17+Cosmics_UP17+DIGICOS_UP17+RECOCOS_UP17+ALCACOS_UP17+HARVESTCOS_UP17
  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-d07409/7.22_Cosmics_UP16+Cosmics_UP16+DIGICOS_UP16+RECOCOS_UP16+ALCACOS_UP16+HARVESTCOS_UP16
  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-d07409/7.23_Cosmics_UP21+Cosmics_UP21+DIGICOS_UP21+RECOCOS_UP21+ALCACOS_UP21+HARVESTCOS_UP21
  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-d07409/7.24_Cosmics_UP21_0T+Cosmics_UP21_0T+DIGICOS_UP21_0T+RECOCOS_UP21_0T+ALCACOS_UP21_0T+HARVESTCOS_UP21_0T

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 36
  • DQMHistoTests: Total histograms compared: 2528845
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2528822
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 35 files compared)
  • Checked 151 log files, 37 edm output root files, 36 DQM output files

@christopheralanwest
Copy link
Contributor

+1

  • backport consistent with PR to master
  • no changes in PR comparison tests, as expected for this technical change

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_11_2_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_11_3_X is complete. This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@francescobrivio
Copy link
Contributor Author

@silviodonato @dpiparo @qliphy do you need more information on this PR?

@qliphy
Copy link
Contributor

qliphy commented Mar 4, 2021

+1

@cmsbuild cmsbuild merged commit b0edbf9 into cms-sw:CMSSW_11_2_X Mar 4, 2021
@qliphy qliphy mentioned this pull request Mar 21, 2021
Closed
@francescobrivio francescobrivio deleted the alca-EcalMustacheSCParameters_11_2_X branch June 16, 2021 22:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
alca-approved backport-ok fully-signed orp-approved tests-approved
Projects
None yet
Milestone
CMSSW_11_2_X
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@francescobrivio @cmsbuild @christopheralanwest @qliphy