Utilities/StaticAnalyzer: Add check for func name in DiGraph before calling has_path.

[gartung]

Resolves cms-sw/framework-team#56

Fix for error in generating report from static analyzers:

+ ./create_statics_esd_reports.sh
Traceback (most recent call last):
  File "./data-class-funcs.py", line 95, in <module>
    for n,nbrdict in G.adjacency_iter():
AttributeError: 'DiGraph' object has no attribute 'adjacency_iter'
Traceback (most recent call last):
  File "./statics.py", line 43, in <module>
    if nx.has_path(G,tfunc,static): 
  File "/cvmfs/cms-ib.cern.ch/nweek-02669/slc7_amd64_gcc900/external/py2-networkx/2.2-ljfedo/lib/python2.7/site-packages/networkx/algorithms/shortest_paths/generic.py", line 40, in has_path
    nx.shortest_path(G, source, target)
  File "/cvmfs/cms-ib.cern.ch/nweek-02669/slc7_amd64_gcc900/external/py2-networkx/2.2-ljfedo/lib/python2.7/site-packages/networkx/algorithms/shortest_paths/generic.py", line 170, in shortest_path
    paths = nx.bidirectional_shortest_path(G, source, target)
  File "/cvmfs/cms-ib.cern.ch/nweek-02669/slc7_amd64_gcc900/external/py2-networkx/2.2-ljfedo/lib/python2.7/site-packages/networkx/algorithms/shortest_paths/unweighted.py", line 223, in bidirectional_shortest_path
    raise nx.NodeNotFound(msg.format(source, target))
networkx.exception.NodeNotFound: Either source edm::EventProcessor::beginRun(const edm::ProcessHistoryID &, edm::RunNumber_t, _Bool &, _Bool &) or target (anonymous namespace)::ChannelStatus is not in G
Traceback (most recent call last):
  File "/pool/condor/dir_27113/jenkins/workspace/ib-run-static-checks/CMSSW_11_3_X_2021-02-27-1100/bin/slc7_amd64_gcc900/edm-global-class.py", line 99, in <module>
    for n,nbrdict in G.adjacency_iter():
AttributeError: 'DiGraph' object has no attribute 'adjacency_iter'

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33018/21301

• This PR adds an extra 16KB to repository

[cmsbuild]

A new Pull Request was created by @gartung (Patrick Gartung) for master.

It involves the following packages:

Utilities/StaticAnalyzers

@makortel, @smuzaffar, @cmsbuild, @Dr15Jones can you please review it and eventually sign? Thanks.
@makortel, @wddgit this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33018/21302

• This PR adds an extra 16KB to repository

[cmsbuild]

Pull request #33018 was updated. @makortel, @smuzaffar, @cmsbuild, @Dr15Jones can you please check and sign again.

[gartung]

@smuzaffar

[gartung]

please test

[makortel]

Resolves makortel/framework#56

That should be put in the PR description for the automation.

[gartung]

@makortel Thanks!

[cmsbuild]

-1

Failed Tests: RelVals-INPUT
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7f5e03/13169/summary.html
COMMIT: 95911c1
CMSSW: CMSSW_11_3_X_2021-03-01-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/33018/13169/install.sh to create a dev area with all the needed externals and cmssw changes.

• DAS Queries: The DAS query tests failed, see the summary page for details.

RelVals-INPUT

• 11725.0DAS Error
• 11925.0DAS Error

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 5 differences found in the comparisons
• DQMHistoTests: Total files compared: 37
• DQMHistoTests: Total histograms compared: 2750983
• DQMHistoTests: Total failures: 11
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2750950
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 36 files compared)
• Checked 156 log files, 37 edm output root files, 37 DQM output files

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33018/21338

• This PR adds an extra 12KB to repository

[cmsbuild]

Pull request #33018 was updated. @makortel, @smuzaffar, @cmsbuild, @Dr15Jones can you please check and sign again.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33018/21339

• This PR adds an extra 16KB to repository

[cmsbuild]

Pull request #33018 was updated. @makortel, @smuzaffar, @cmsbuild, @Dr15Jones can you please check and sign again.

[gartung]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7f5e03/13211/summary.html
COMMIT: dab7f93
CMSSW: CMSSW_11_3_X_2021-03-02-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/33018/13211/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 37
• DQMHistoTests: Total histograms compared: 2750983
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2750960
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 36 files compared)
• Checked 156 log files, 37 edm output root files, 37 DQM output files

[gartung]

@makortel

[makortel]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[qliphy]

+1