Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes for TensorFlow 2.4 support. #33021

Merged
merged 1 commit into from Mar 2, 2021
Merged

Conversation

riga
Copy link
Contributor

@riga riga commented Mar 1, 2021

PR description

TensorFlow is going to be updated to version 2.4.1 in cms-sw/cmsdist#6674 (superseding cms-sw/cmsdist#6545), which drops Python 2 support.

This PR updates the TF test cases to use Python 3 instead. Currently, no changes to the C++ interface are required.

PR validation

All existing TF test cases pass. cms-sw/cmsdist#6674 is required to run validation builds.

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 1, 2021

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33021/21307

  • This PR adds an extra 12KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 1, 2021

A new Pull Request was created by @riga (Marcel R.) for master.

It involves the following packages:

PhysicsTools/TensorFlow

@perrotta, @jpata, @cmsbuild, @slava77 can you please review it and eventually sign? Thanks.
@makortel this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@smuzaffar
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 1, 2021

-1

Failed Tests: RelVals-INPUT
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c61010/13165/summary.html
COMMIT: ec0951e
CMSSW: CMSSW_11_3_X_2021-02-28-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/33021/13165/install.sh to create a dev area with all the needed externals and cmssw changes.

  • DAS Queries: The DAS query tests failed, see the summary page for details.

RelVals-INPUT

  • 11725.0DAS Error
  • 11925.0DAS Error

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 2 differences found in the comparisons
  • DQMHistoTests: Total files compared: 37
  • DQMHistoTests: Total histograms compared: 2750983
  • DQMHistoTests: Total failures: 9
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2750952
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 36 files compared)
  • Checked 156 log files, 37 edm output root files, 37 DQM output files

@smuzaffar
Copy link
Contributor

das errors are unrelated to this PR.

@perrotta
Copy link
Contributor

perrotta commented Mar 1, 2021

+1

  • Technical
  • Jenkins tests pass

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 1, 2021

This pull request is fully signed and it will be integrated in one of the next master IBs (but tests are reportedly failing). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@silviodonato
Copy link
Contributor

+1

@silviodonato
Copy link
Contributor

merge

@cmsbuild cmsbuild merged commit 502d254 into cms-sw:master Mar 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants