Replace roll to ieta in GEM

[yeckang]

PR description:

• Replace roll to ieta in GEMDetId for consistency between software and hardware words.
• But we keep the roll() to backward compatible.

PR validation:

• The branch has tested with following commands to check if it works in 2 different geometry versions.
  runTheMatrix.py -w upgrade -l 31011.0
runTheMatrix.py -w upgrade -l 23211.0
• The code format has applied with scram build code-format

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33029/21321

• This PR adds an extra 36KB to repository

[cmsbuild]

A new Pull Request was created by @yeckang (Yechan Kang) for master.

It involves the following packages:

DataFormats/MuonDetId
Validation/MuonGEMDigis
Validation/MuonGEMHits
Validation/MuonGEMRecHits

@andrius-k, @kmaeshima, @ErnestaP, @ahmad3213, @cmsbuild, @jfernan2, @mdhildreth, @civanch, @rvenditti can you please review it and eventually sign? Thanks.
@battibass, @abbiendi, @watson-ij, @jhgoh, @jshlee, @calderona, @HuguesBrun, @Fedespring, @ptcox, @rovere, @trocino, @cericeci this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[jfernan2]

please test

[cmsbuild]

-1

Failed Tests: Build
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2d1fd5/13178/summary.html
COMMIT: aec34b7
CMSSW: CMSSW_11_3_X_2021-03-01-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/33029/13178/install.sh to create a dev area with all the needed externals and cmssw changes.

Build

I found compilation error when building:

>> Compiling  /build/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_3_X_2021-03-01-1100/src/CondFormats/GEMObjects/src/T_EventSetup_GEMELMap.cc
>> Compiling  /build/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_3_X_2021-03-01-1100/src/CondFormats/GEMObjects/src/T_EventSetup_GEMMaskedStrips.cc
>> Compiling  /build/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_3_X_2021-03-01-1100/src/CondFormats/GEMObjects/src/T_EventSetup_GEMeMap.cc
>> Compiling  tmp/slc7_amd64_gcc900/src/CondFormats/GEMObjects/src/CondFormatsGEMObjects/a/Serialization.cc
/build/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_3_X_2021-03-01-1100/src/CondFormats/GEMObjects/src/GEMELMap.cc: In member function 'void GEMELMap::convertDummy(GEMROmap&)':
/build/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_3_X_2021-03-01-1100/src/CondFormats/GEMObjects/src/GEMELMap.cc:66:48: error: 'maxRollId' is not a member of 'GEMDetId'
   66 |           for (int roll = 1; roll <= GEMDetId::maxRollId; ++roll) {
      |                                                ^~~~~~~~~
/build/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_3_X_2021-03-01-1100/src/CondFormats/GEMObjects/src/GEMeMap.cc: In member function 'void GEMeMap::convertDummy(GEMROMapping&)':
/build/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_3_X_2021-03-01-1100/src/CondFormats/GEMObjects/src/GEMeMap.cc:109:50: error: 'maxRollId' is not a member of 'GEMDetId'
  109 |             for (int roll = 1; roll <= GEMDetId::maxRollId; ++roll) {


[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33029/21323

• This PR adds an extra 36KB to repository

[cmsbuild]

Pull request #33029 was updated. @andrius-k, @kmaeshima, @ErnestaP, @ahmad3213, @cmsbuild, @jfernan2, @mdhildreth, @civanch, @rvenditti can you please check and sign again.

[civanch]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2d1fd5/13185/summary.html
COMMIT: 6552faf
CMSSW: CMSSW_11_3_X_2021-03-01-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/33029/13185/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 5 differences found in the comparisons
• DQMHistoTests: Total files compared: 37
• DQMHistoTests: Total histograms compared: 2750623
• DQMHistoTests: Total failures: 8
• DQMHistoTests: Total nulls: 1
• DQMHistoTests: Total successes: 2750592
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 1.049 KiB( 36 files compared)
• DQMHistoSizes: changed ( 10024.0,... ): 0.070 KiB MuonGEMRecHitsV/GEMRecHitsTask
• DQMHistoSizes: changed ( 23234.0,... ): 0.141 KiB MuonGEMRecHitsV/GEMRecHitsTask
• DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
• Checked 156 log files, 37 edm output root files, 37 DQM output files

[jfernan2]

@yeckang can you please add your name and github account to the corresponding e-group on
https://twiki.cern.ch/twiki/bin/view/CMS/DQMContacts#GEM
?
Thanks

[yeckang]

@jfernan2 I just added myself to Validation DQM Developer(s) e-groups. I'm waiting for approval.
Thanks

[jfernan2]

Thank you @yeckang
Can you please confirm that the changes introduced by this PR are what you expect?
https://cmssdt.cern.ch/SDT/jenkins-artifacts/baseLineComparisons/CMSSW_11_3_X_2021-03-01-2300+2d1fd5/41445/dqm-histo-comparison-summary.html

[yeckang]

@jfernan2
What I expected for this PR is changing the names and titles that contain 'roll' in it. And I see the titles are changed correctly.
Thanks

[civanch]

+1

[jfernan2]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[qliphy]

+1