Update GEM Offline DQM #33031

seungjin-yang · 2021-03-02T05:28:29Z

PR description:

Regarding GEMEfficiencyAnalyzer,
- Update the way to propagate muons into GEM layers because the existing way is not decent to cosmics scenario.
- Combine plots for odd/even chambers into one for reducing memory usage.
- Update the way to book MonitorElements. Remove BookingHelper, which is the wrapper of IBooker. Use GEMDetId as a key of MEMap rather than tuple of int numbers.
- Create cfi files for comics scenario.
Exclude GEMOfflineMonitor from GEM offline DQM sequence. GEMOfflineMonitor creates only GEMDigi and GEMRecHit occupancy plots but these plots are moved to the online DQM. However, GEMOfflineMonitor is not removed because it will make more diverse plots (mainly GEMSegment) in the near future.

Here is a link to slides

PR validation:

The offline DQM GUI server is running at the local server. Link to DQM GUI.
Please check out the manual of GUI at the last page of the slides

This PR is tested with two workflows:

For pp, runTheMatrix.py -w upgrade -l 12411.0, which is TenMuExtendedE_0_200+2023.
For comics, I used custom UndergroundCosmicMu_cfi without magnetic field, whose result is shown in GUI.

@jshlee, @szaleski

* GEMEfficiencyAnalyzer * supports both pp and cosmics now. * propagate muons to each GEM layer plane rather than each GEM chamber. * use delta rphi as the muon-hit matching cut. * GEMOfflineMonitor * is deprecated and so is removed from GEM offline DQM sequence.

cmsbuild · 2021-03-02T05:34:53Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33031/21325

This PR adds an extra 40KB to repository

cmsbuild · 2021-03-02T05:35:26Z

A new Pull Request was created by @seungjin-yang for master.

It involves the following packages:

DQMOffline/Configuration
DQMOffline/Muon

@andrius-k, @kmaeshima, @ErnestaP, @ahmad3213, @cmsbuild, @jfernan2, @rvenditti can you please review it and eventually sign? Thanks.
@barvic, @bellan, @threus, @abbiendi, @Fedespring, @calderona, @HuguesBrun, @jhgoh, @ptcox, @trocino, @cericeci, @rociovilar this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

jfernan2 · 2021-03-02T08:40:25Z

please test

cmsbuild · 2021-03-02T08:49:27Z

-1

Failed Tests: Build ClangBuild
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6b1581/13186/summary.html
COMMIT: 266fcea
CMSSW: CMSSW_11_3_X_2021-03-01-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/33031/13186/install.sh to create a dev area with all the needed externals and cmssw changes.

Build

I found compilation warning when building: See details on the summary page.

Clang Build

I found compilation warning while trying to compile with clang. Command used:

USER_CUDA_FLAGS='--expt-relaxed-constexpr' USER_CXXFLAGS='-Wno-register -fsyntax-only' scram build -k -j 64 COMPILER='llvm compile'

See details on the summary page.

…tics

cmsbuild · 2021-03-02T10:18:05Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33031/21327

This PR adds an extra 40KB to repository

cmsbuild · 2021-03-02T13:38:27Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33031/21329

This PR adds an extra 40KB to repository

cmsbuild · 2021-03-02T13:38:52Z

Pull request #33031 was updated. @andrius-k, @kmaeshima, @ErnestaP, @ahmad3213, @cmsbuild, @jfernan2, @rvenditti can you please check and sign again.

seungjin-yang · 2021-03-02T13:48:53Z

The variable name change was incomplete. phase2_GEM.toModify was taking the old variable name (etaHigh) as an named argument. The new commit fixed it and is tested with workflow 34611.0, which is TenMuExtendedE_0_200+2026D76.

jfernan2 · 2021-03-02T14:16:10Z

please test

cmsbuild · 2021-03-02T16:50:20Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6b1581/13197/summary.html
COMMIT: 36f0860
CMSSW: CMSSW_11_3_X_2021-03-01-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/33031/13197/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

No significant changes to the logs found
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 37
DQMHistoTests: Total histograms compared: 2747627
DQMHistoTests: Total failures: 1
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 2747604
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: -689.759 KiB( 36 files compared)
DQMHistoSizes: changed ( 11634.0,... ): -144.873 KiB GEM/GEMEfficiency
DQMHistoSizes: changed ( 11634.0,... ): 80.748 KiB GEM/Efficiency
DQMHistoSizes: changed ( 11634.0,... ): -20.975 KiB GEM/GEMOfflineMonitor
DQMHistoSizes: changed ( 23234.0,... ): -218.818 KiB GEM/GEMEfficiency
DQMHistoSizes: changed ( 23234.0,... ): 141.314 KiB GEM/Efficiency
DQMHistoSizes: changed ( 23234.0,... ): -38.949 KiB GEM/GEMOfflineMonitor
Checked 156 log files, 37 edm output root files, 37 DQM output files

jfernan2 · 2021-03-02T20:20:43Z

@seungjin-yang plots look fine but all are empty, I guess due to stats of the Jenkins test samples

seungjin-yang · 2021-03-03T03:41:15Z

@seungjin-yang plots look fine but all are empty, I guess ue to stats of the Jenkins test samples

Yes, GEM detectors cover the high eta region. Neither TTBar nor ZMM will produce a sufficient number of muons flying into the high eta region. So, I have generated muon gun samples with the GEM eta coverage option and a lot of cosmic muons. What should I do?

jfernan2 · 2021-03-03T08:27:13Z

No problem @seungjin-yang your validation plots show enough stats

jfernan2 · 2021-03-03T08:27:19Z

+1

cmsbuild · 2021-03-03T08:27:38Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

silviodonato · 2021-03-03T17:38:14Z

+1

seungjin-yang added 6 commits February 23, 2021 16:18

Check if skewness is nan. need to check other values.

2500cae

Apply code-checks and code-format

02bff67

remove pull_phi

6a3c003

Add eff vs chamber and removed unused variables

dafdb78

Fix typos

266fcea

cmsbuild added this to the CMSSW_11_3_X milestone Mar 2, 2021

cmsbuild added code-checks-pending dqm-pending orp-pending pending-signatures tests-pending labels Mar 2, 2021

seungjin-yang changed the title ~~Gem offline dqm update from cmssw 11 3 0 pre3~~ Update GEM Offline DQM Mar 2, 2021

cmsbuild added code-checks-approved and removed code-checks-pending labels Mar 2, 2021

seungjin-yang mentioned this pull request Mar 2, 2021

Update GEM Offline DQM, backport to CMSSW_11_2_X #33032

Merged

cmsbuild added tests-started tests-rejected and removed tests-pending tests-started labels Mar 2, 2021

Apply an extra token at end of #ifndef and remove abused move seman…

0cf17e1

…tics

cmsbuild added code-checks-pending tests-pending and removed code-checks-approved tests-rejected labels Mar 2, 2021

Fix a variable name that was not updated

36f0860

cmsbuild added code-checks-pending tests-pending and removed code-checks-approved tests-rejected labels Mar 2, 2021

cmsbuild added code-checks-approved and removed code-checks-pending labels Mar 2, 2021

cmsbuild added tests-started and removed tests-pending labels Mar 2, 2021

cmsbuild added tests-approved and removed tests-started labels Mar 2, 2021

cmsbuild added dqm-approved fully-signed and removed dqm-pending pending-signatures labels Mar 3, 2021

cmsbuild added orp-approved and removed orp-pending labels Mar 3, 2021

cmsbuild merged commit f77e926 into cms-sw:master Mar 3, 2021

seungjin-yang mentioned this pull request Mar 30, 2021

Update the GEM offline DQM part. dmwm/deployment#1042

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update GEM Offline DQM #33031

Update GEM Offline DQM #33031

seungjin-yang commented Mar 2, 2021

cmsbuild commented Mar 2, 2021

cmsbuild commented Mar 2, 2021

jfernan2 commented Mar 2, 2021

cmsbuild commented Mar 2, 2021

cmsbuild commented Mar 2, 2021

cmsbuild commented Mar 2, 2021

cmsbuild commented Mar 2, 2021

seungjin-yang commented Mar 2, 2021 •

edited

jfernan2 commented Mar 2, 2021

cmsbuild commented Mar 2, 2021

jfernan2 commented Mar 2, 2021 •

edited

seungjin-yang commented Mar 3, 2021

jfernan2 commented Mar 3, 2021

jfernan2 commented Mar 3, 2021

cmsbuild commented Mar 3, 2021

silviodonato commented Mar 3, 2021

Update GEM Offline DQM #33031

Update GEM Offline DQM #33031

Conversation

seungjin-yang commented Mar 2, 2021

PR description:

PR validation:

cmsbuild commented Mar 2, 2021

cmsbuild commented Mar 2, 2021

jfernan2 commented Mar 2, 2021

cmsbuild commented Mar 2, 2021

Build

Clang Build

cmsbuild commented Mar 2, 2021

cmsbuild commented Mar 2, 2021

cmsbuild commented Mar 2, 2021

seungjin-yang commented Mar 2, 2021 • edited

jfernan2 commented Mar 2, 2021

cmsbuild commented Mar 2, 2021

Comparison Summary

jfernan2 commented Mar 2, 2021 • edited

seungjin-yang commented Mar 3, 2021

jfernan2 commented Mar 3, 2021

jfernan2 commented Mar 3, 2021

cmsbuild commented Mar 3, 2021

silviodonato commented Mar 3, 2021

seungjin-yang commented Mar 2, 2021 •

edited

jfernan2 commented Mar 2, 2021 •

edited