Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add additional capability (filtering by decay R/Z) to MCMultiParticle… #33033

Conversation

kfjack
Copy link
Contributor

@kfjack kfjack commented Mar 2, 2021

…Filter; fill up vectors with defaults if necessary for MCSmartSingleParticleFilter

PR description:

  • Additional capability (filtering according to the decay region, the same functionality which has been already implemented in the MCSmartSingleParticleFilter) is added to the MCMultiParticleFilter. A small typo (bug, but no real effect) for loading motherID_ in the original filter has been fixed.

  • Fill up vectors with defaults if necessary, fix both MCMultiParticleFilter and MCSmartSingleParticleFilter filters.

PR validation:

Managed to filter the B(s,d) -> hh -> mumu events by adding such a filter (requiring two muon decaying from K/pi, and within the detector volume) to the process:
mugenfilter = cms.EDFilter(
"MCMultiParticleFilter",
ParticleID = cms.vint32(-13, 13, -13, 13),
MotherID = cms.untracked.vint32(321, -321, 211, -211),
MaxDecayRadius = cms.untracked.vdouble(2000.0, 2000.0, 2000.0, 2000.0),
MaxDecayZ = cms.untracked.vdouble(4000.0, 4000.0, 4000.0, 4000.0),
MinDecayZ = cms.untracked.vdouble(-4000.0, -4000.0, -4000.0, -4000.0),
EtaMax = cms.vdouble(2.5, 2.5, 2.5, 2.5),
PtMin = cms.vdouble(3.5, 3.5, 3.5, 3.5),
Status = cms.vint32(1,1,1,1),
NumRequired = cms.int32(2),
AcceptMore = cms.bool(True)
)

if this PR is a backport please specify the original PR and why you need to backport that PR:

Backport from PR #32999, in order to enable the generation for Run-2 UL

…Filter; fill up vectors with defaults if necessary for MCSmartSingleParticleFilter
@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 2, 2021

A new Pull Request was created by @kfjack (Kai-Feng Chen) for CMSSW_10_6_X.

It involves the following packages:

GeneratorInterface/GenFilters

@SiewYan, @mkirsano, @cmsbuild, @GurpreetSinghChahal, @agrohsje, @alberto-sanchez can you please review it and eventually sign? Thanks.
@alberto-sanchez, @mkirsano this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@SiewYan
Copy link
Contributor

SiewYan commented Mar 2, 2021

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 2, 2021

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-649e75/13204/summary.html
COMMIT: 2553638
CMSSW: CMSSW_10_6_X_2021-03-02-1100/slc7_amd64_gcc700
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/33033/13204/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 35
  • DQMHistoTests: Total histograms compared: 3215540
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3215205
  • DQMHistoTests: Total skipped: 334
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 34 files compared)
  • Checked 143 log files, 29 edm output root files, 35 DQM output files

@agrohsje
Copy link

agrohsje commented Mar 2, 2021

+generators

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 2, 2021

This pull request is fully signed and it will be integrated in one of the next CMSSW_10_6_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_11_3_X is complete. This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@qliphy
Copy link
Contributor

qliphy commented Mar 3, 2021

+1

@cmsbuild cmsbuild merged commit bd54aa5 into cms-sw:CMSSW_10_6_X Mar 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants