Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move DTDriftTimeParameters.icc #33049

Merged
merged 1 commit into from Mar 5, 2021
Merged

Conversation

davidlange6
Copy link
Contributor

move .icc into interface as its used by other packages. Move from nearly empty package into DT package. Adjust BuildFiles accordingly.

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 3, 2021

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33049/21350

  • This PR adds an extra 64KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 3, 2021

A new Pull Request was created by @davidlange6 (David Lange) for master.

It involves the following packages:

DataFormats/DTRecHit
RecoLocalMuon/DTRecHit
SimMuon/DTDigitizer

@perrotta, @civanch, @mdhildreth, @cmsbuild, @slava77, @jpata can you please review it and eventually sign? Thanks.
@battibass, @abbiendi, @jhgoh, @bellan, @HuguesBrun, @Fedespring, @calderona, @cericeci, @rovere, @trocino, @slomeo this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@davidlange6
Copy link
Contributor Author

davidlange6 commented Mar 3, 2021 via email

@slava77
Copy link
Contributor

slava77 commented Mar 4, 2021

@cmsbuild please test

it seems like the last attempt got stuck

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 4, 2021

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-aae797/13272/summary.html
COMMIT: d02de12
CMSSW: CMSSW_11_3_X_2021-03-04-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/33049/13272/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 2867 differences found in the comparisons
  • DQMHistoTests: Total files compared: 37
  • DQMHistoTests: Total histograms compared: 2748956
  • DQMHistoTests: Total failures: 64469
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2684465
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 36 files compared)
  • Checked 156 log files, 37 edm output root files, 37 DQM output files

@slava77
Copy link
Contributor

slava77 commented Mar 4, 2021

+1

for #33049 d02de12

  • technical
  • jenkins tests pass without differences (ignoring the repeatedly non-reproducible DD4HEP workflow results 11634.911)

@civanch
Copy link
Contributor

civanch commented Mar 5, 2021

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 5, 2021

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@qliphy
Copy link
Contributor

qliphy commented Mar 5, 2021

+1

@cmsbuild cmsbuild merged commit 47cd51b into cms-sw:master Mar 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants