New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move DTDriftTimeParameters.icc #33049
Conversation
…rly empty package into DT package
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33049/21350
|
A new Pull Request was created by @davidlange6 (David Lange) for master. It involves the following packages: DataFormats/DTRecHit @perrotta, @civanch, @mdhildreth, @cmsbuild, @slava77, @jpata can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test
… On Mar 3, 2021, at 9:16 AM, cmsbuild ***@***.***> wrote:
A new Pull Request was created by @davidlange6 (David Lange) for master.
It involves the following packages:
DataFormats/DTRecHit
RecoLocalMuon/DTRecHit
SimMuon/DTDigitizer
@perrotta, @civanch, @mdhildreth, @cmsbuild, @slava77, @jpata can you please review it and eventually sign? Thanks.
@battibass, @abbiendi, @jhgoh, @bellan, @HuguesBrun, @Fedespring, @calderona, @cericeci, @rovere, @trocino, @slomeo this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.
cms-bot commands are listed here
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or unsubscribe.
|
@cmsbuild please test it seems like the last attempt got stuck |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-aae797/13272/summary.html Comparison SummarySummary:
|
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
move .icc into interface as its used by other packages. Move from nearly empty package into DT package. Adjust BuildFiles accordingly.