Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hgc geometry v4 #3305

Merged
merged 3 commits into from Apr 16, 2014
Merged

Conversation

vandreev11
Copy link
Contributor

HGCal concept granularity parameters
@pfs, @bsunanda, @ianna

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @vandreev11 for CMSSW_6_2_X_SLHC.

Hgc geometry v4

It involves the following packages:

Geometry/HGCalCommonData

@civanch, @Dr15Jones, @ianna, @mdhildreth, @cmsbuild, @nclopezo, @Degano, @ktf can you please review it and eventually sign? Thanks.
@ghellwig this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@andersonjacob, @mark-grimes you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@ianna
Copy link
Contributor

ianna commented Apr 11, 2014

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_6_2_X_SLHC IBs unless changes or unless it breaks tests. @andersonjacob, @mark-grimes can you please take care of it?

@mark-grimes
Copy link

merge

Tests 10000, 10200, 10400, 11200, 11400, 12000, 12800, 13000, 13600 and 14600 pass all steps.
Tests 12200, 12400, 12600, 13800, 14000, 14200 and 14400 fail in step 2 with known errors.

cmsbuild added a commit that referenced this pull request Apr 16, 2014
@cmsbuild cmsbuild merged commit f540b16 into cms-sw:CMSSW_6_2_X_SLHC Apr 16, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants