Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

migrate Alignment/LaserAlignment to esConsumes #33054

Merged
merged 2 commits into from Mar 8, 2021

Conversation

mmusich
Copy link
Contributor

@mmusich mmusich commented Mar 3, 2021

PR description:

Title says it all.
Part of #31061.

PR validation:

It compiles.

if this PR is a backport please specify the original PR and why you need to backport that PR:

Not a backport, no backport needed.

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 3, 2021

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33054/21358

  • This PR adds an extra 28KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 3, 2021

A new Pull Request was created by @mmusich (Marco Musich) for master.

It involves the following packages:

Alignment/LaserAlignment

@malbouis, @yuanchao, @christopheralanwest, @cmsbuild, @tlampen, @pohsun, @francescobrivio can you please review it and eventually sign? Thanks.
@mmusich, @tocheng, @adewit this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@mmusich
Copy link
Contributor Author

mmusich commented Mar 3, 2021

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 3, 2021

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-0f1ce2/13246/summary.html
COMMIT: afcf4b6
CMSSW: CMSSW_11_3_X_2021-03-03-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/33054/13246/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 2868 differences found in the comparisons
  • DQMHistoTests: Total files compared: 37
  • DQMHistoTests: Total histograms compared: 2750983
  • DQMHistoTests: Total failures: 4928
  • DQMHistoTests: Total nulls: 1
  • DQMHistoTests: Total successes: 2746032
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.004 KiB( 36 files compared)
  • DQMHistoSizes: changed ( 312.0 ): 0.004 KiB MessageLogger/Warnings
  • Checked 156 log files, 37 edm output root files, 37 DQM output files

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 4, 2021

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33054/21373

  • This PR adds an extra 36KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 4, 2021

Pull request #33054 was updated. @malbouis, @yuanchao, @christopheralanwest, @cmsbuild, @tlampen, @pohsun, @francescobrivio can you please check and sign again.

@mmusich
Copy link
Contributor Author

mmusich commented Mar 4, 2021

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 4, 2021

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-0f1ce2/13262/summary.html
COMMIT: e8bfa76
CMSSW: CMSSW_11_3_X_2021-03-03-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/33054/13262/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 2869 differences found in the comparisons
  • DQMHistoTests: Total files compared: 37
  • DQMHistoTests: Total histograms compared: 2749431
  • DQMHistoTests: Total failures: 64469
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2684940
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 36 files compared)
  • Checked 156 log files, 37 edm output root files, 37 DQM output files

@mmusich
Copy link
Contributor Author

mmusich commented Mar 4, 2021

DQMHistoTests: Total failures: 64469

All failures are concentrated in a single wf: 11634.911, clearly nothing to do with the PR.

@yuanchao
Copy link
Contributor

yuanchao commented Mar 8, 2021

+1

  • regardless the comparison failure on WF 11634.911, all matrix tests and unit tests passed
  • static build warnings are not part of the PR

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 8, 2021

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@qliphy
Copy link
Contributor

qliphy commented Mar 8, 2021

+1

@cmsbuild cmsbuild merged commit 061171c into cms-sw:master Mar 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants