Add more pixel payload inspections

[mmusich]

PR description:

The goal of this PR is expand the set of Pixel conditions browsable with the Payload Inspector.
It adds inspectors for:

• SiPixelQualityProbabilities
• SiPixelFEDChannelContainer
• SiPixel2DTemplateDBObject

I profit of this PR to add a README file for the package

PR validation:

Run successfully the unit tests of this package as well as private testing of the added plots.
Example plot obtained with:

 getPayloadData.py \
     --plugin pluginSiPixelFEDChannelContainer_PayloadInspector \
     --plot plot_SiPixelFEDChannelContainerTest \
     --tag SiPixelStatusScenarios_UltraLegacy2018_v0_mc \
     --time_type Run --iovs '{"start_iov": "1", "end_iov" : "1"}' \
     --db Prod \
     --input_params '{"Scenarios":"320824_103,316758_983,320934_254"}' \
     --test ;

and example plot obtained with:

getPayloadData.py \
    --plugin pluginSiPixelFEDChannelContainer_PayloadInspector \
    --plot plot_SiPixelFEDChannelContainerScenarios \
    --tag SiPixelStatusScenarios_UltraLegacy2017_v0_mc \
    --time_type Run --iovs '{"start_iov": "1", "end_iov" : "1"}' \
    --db Prod \
    --test ;

if this PR is a backport please specify the original PR and why you need to backport that PR:

Not a backport, no backport needed.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33070/21381

• This PR adds an extra 40KB to repository

[cmsbuild]

A new Pull Request was created by @mmusich (Marco Musich) for master.

It involves the following packages:

CondCore/SiPixelPlugins

@ggovi, @cmsbuild can you please review it and eventually sign? Thanks.
@VinInn, @OzAmram, @ferencek, @mmusich, @dkotlins, @tvami this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[mmusich]

@cmsbuild, please test

[cmsbuild]

-1

Failed Tests: ClangBuild
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2e701f/13279/summary.html
COMMIT: fdf92bb
CMSSW: CMSSW_11_3_X_2021-03-04-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/33070/13279/install.sh to create a dev area with all the needed externals and cmssw changes.

Clang Build

I found compilation warning while trying to compile with clang. Command used:

USER_CUDA_FLAGS='--expt-relaxed-constexpr' USER_CXXFLAGS='-Wno-register -fsyntax-only' scram build -k -j 64 COMPILER='llvm compile'

See details on the summary page.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33070/21383

• This PR adds an extra 40KB to repository

[cmsbuild]

Pull request #33070 was updated. @ggovi, @cmsbuild can you please check and sign again.

[mmusich]

@cmsbuild, please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2e701f/13281/summary.html
COMMIT: 69500a9
CMSSW: CMSSW_11_3_X_2021-03-04-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/33070/13281/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 2869 differences found in the comparisons
• DQMHistoTests: Total files compared: 37
• DQMHistoTests: Total histograms compared: 2748956
• DQMHistoTests: Total failures: 64468
• DQMHistoTests: Total nulls: 1
• DQMHistoTests: Total successes: 2684465
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: -0.004 KiB( 36 files compared)
• DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
• Checked 156 log files, 37 edm output root files, 37 DQM output files

[silviodonato]

kind reminder @ggovi

[ggovi]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[qliphy]

@mmusich the test results show "CMSSW code rules violation":
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2e701f/13281/summary.html
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2e701f/13281/codeRules/cmsCodeRule1.txt

Can you have a check? You may also refer to #25301

[mmusich]

@qliphy

the test results show "CMSSW code rules violation":
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2e701f/13281/summary.html
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2e701f/13281/codeRules/cmsCodeRule1.txt

Can you have a check? You may also refer to #25301

few remarks:

1. I didn't add the namespace in the current PR, It was already included in the baseline:

   cmssw/CondCore/SiPixelPlugins/interface/SiPixelTemplateHelper.h

   Line 31 in 835a0cf

   using namespace cond::payloadInspector;

2. obeying the rule would in my opinion clutter the file with a lot of cond::payloadInspector that would make the file less readable.
3. I have another branch that I should submit as a PR shortly that is touching this same package. As this PR is already signed in the interest of saving time, can we merge it as is? I'll propose changes in the subsequent one.

Thank you

[qliphy]

Thanks @mmusich
I think your point make sense. Adding @silviodonato who may comment more or move forward this PR.

[silviodonato]

using namespace cond::payloadInspector; was already there, so I'm ok with this PR.

[qliphy]

+1

[silviodonato]

PS. the using namespace is inside a namespace scope. This should prevent using namespace from having "long-range" effects, so we should not be worried about this.